Browse Source

exclude `name` for `country` result labels

pull/633/head
Stephen Hess 9 years ago
parent
commit
1b83247964
  1. 10
      helper/labelGenerator.js
  2. 8
      test/unit/helper/labelGenerator_default.js

10
helper/labelGenerator.js

@ -56,10 +56,20 @@ function getInitialLabel(record) {
return [];
}
if (isCountry(record.layer)) {
return [];
}
return [record.name];
}
// this can go away once geonames is no longer supported
// https://github.com/pelias/wof-admin-lookup/issues/49
function isCountry(layer) {
return 'country' === layer;
}
function isRegion(layer) {
return 'region' === layer;
}

8
test/unit/helper/labelGenerator_default.js

@ -175,14 +175,14 @@ module.exports.tests.default_country = function(test, common) {
t.end();
});
test('country', function(t) {
test('country layer labels should only use the `country` field and not the `name`', function(t) {
var doc = {
'name': 'country name',
'name': 'source country name',
'layer': 'country',
'country_a': 'country code',
'country': 'country name'
'country': 'hierarchy country name'
};
t.equal(generator(doc),'country name');
t.equal(generator(doc),'hierarchy country name');
t.end();
});

Loading…
Cancel
Save