From 2fd67fcc58ad03352e007acf5050ef08c84f6c1b Mon Sep 17 00:00:00 2001 From: Peter Johnson Date: Thu, 18 Sep 2014 14:50:10 +0100 Subject: [PATCH] refactor; add tests --- query/suggest.js | 4 ++-- test/unit/query/indeces.js | 23 +++++++++++++++++++++++ test/unit/query/suggest.js | 29 +++++++++++++++++++++++++++++ test/unit/run.js | 4 +++- 4 files changed, 57 insertions(+), 3 deletions(-) create mode 100644 test/unit/query/indeces.js create mode 100644 test/unit/query/suggest.js diff --git a/query/suggest.js b/query/suggest.js index b54e2518..9ba2e5c8 100644 --- a/query/suggest.js +++ b/query/suggest.js @@ -3,7 +3,7 @@ var logger = require('../src/logger'); // Build pelias suggest query function generate( params ){ - + var cmd = { 'pelias' : { 'text' : params.input, @@ -23,7 +23,7 @@ function generate( params ){ } }; - logger.log( 'cmd', JSON.stringify( cmd, null, 2 ) ); + // logger.log( 'cmd', JSON.stringify( cmd, null, 2 ) ); return cmd; } diff --git a/test/unit/query/indeces.js b/test/unit/query/indeces.js new file mode 100644 index 00000000..d074f620 --- /dev/null +++ b/test/unit/query/indeces.js @@ -0,0 +1,23 @@ + +var indeces = require('../../../query/indeces'); + +module.exports.tests = {}; + +module.exports.tests.interface = function(test, common) { + test('valid interface', function(t) { + t.true(Array.isArray(indeces), 'valid array'); + t.equal(indeces.length, 7, 'valid array'); + t.end(); + }); +}; + +module.exports.all = function (tape, common) { + + function test(name, testFunction) { + return tape('indeces ' + name, testFunction); + } + + for( var testCase in module.exports.tests ){ + module.exports.tests[testCase](test, common); + } +}; \ No newline at end of file diff --git a/test/unit/query/suggest.js b/test/unit/query/suggest.js new file mode 100644 index 00000000..ce7f8861 --- /dev/null +++ b/test/unit/query/suggest.js @@ -0,0 +1,29 @@ + +var query = require('../../../query/suggest'); + +module.exports.tests = {}; + +module.exports.tests.interface = function(test, common) { + test('valid interface', function(t) { + t.equal(typeof query, 'function', 'valid function'); + t.end(); + }); +}; + +module.exports.tests.interface = function(test, common) { + test('valid interface', function(t) { + t.equal(typeof query, 'function', 'valid function'); + t.end(); + }); +}; + +module.exports.all = function (tape, common) { + + function test(name, testFunction) { + return tape('suggest query ' + name, testFunction); + } + + for( var testCase in module.exports.tests ){ + module.exports.tests[testCase](test, common); + } +}; \ No newline at end of file diff --git a/test/unit/run.js b/test/unit/run.js index ffc77c68..d9b2041e 100644 --- a/test/unit/run.js +++ b/test/unit/run.js @@ -5,7 +5,9 @@ var common = {}; var tests = [ require('./controller/index'), require('./controller/suggest'), - require('./sanitiser/suggest') + require('./sanitiser/suggest'), + require('./query/indeces'), + require('./query/suggest') ]; tests.map(function(t) {