From eca8a82818b4b98d47815e654a1c77a9a98b8378 Mon Sep 17 00:00:00 2001
From: Severyn Kozak <severyn.kozak@gmail.com>
Date: Tue, 12 May 2015 10:36:21 -0400
Subject: [PATCH] Remove singleton expected query object.

test/unit/query/search.js
	-Rather than maintaining a "singleton" expected query object,
	which poses problems for tests that want to slightly modify it
	(for instance, by conditionally adding a constraint to
	`filter.bool.must`), make a function that returns it on demand,
	thereby creating a new one each time.
---
 test/unit/query/search.js | 73 ++++++++++++++++++++-------------------
 1 file changed, 37 insertions(+), 36 deletions(-)

diff --git a/test/unit/query/search.js b/test/unit/query/search.js
index cc8f7342..19ba8d91 100644
--- a/test/unit/query/search.js
+++ b/test/unit/query/search.js
@@ -71,44 +71,45 @@ var sort = [
   }
 ];
 
-var expected = {
-  'query': {
-    'filtered': {
-      'query': {
-        'bool': {
-          'must': [{ 
-              'match': {
-                'name.default': 'test'
+function createExpectedQuery(){
+  return {
+    'query': {
+      'filtered': {
+        'query': {
+          'bool': {
+            'must': [{ 
+                'match': {
+                  'name.default': 'test'
+                }
               }
-            }
-          ]   
-        }
-      },
-      'filter': {
-        'bool': {
-          'must': [
-            {
-              'geo_bounding_box': {
-                'center_point': {
-                  'top': '47.47',
-                  'right': '-61.84',
-                  'bottom':'11.51',
-                  'left': '-103.16'
-                },
-                '_cache': true,
-                'type': 'indexed'
+            ]   
+          }
+        },
+        'filter': {
+          'bool': {
+            'must': [
+              {
+                'geo_bounding_box': {
+                  'center_point': {
+                    'top': '47.47',
+                    'right': '-61.84',
+                    'bottom':'11.51',
+                    'left': '-103.16'
+                  },
+                  '_cache': true,
+                  'type': 'indexed'
+                }
               }
-            }
-          ]
+            ]
+          }
         }
       }
-    }
-  },
-  'sort': sort,
-  'size': 10,
-  'track_scores': true
-};
-
+    },
+    'sort': sort,
+    'size': 10,
+    'track_scores': true
+  };
+}
 module.exports.tests.query = function(test, common) {
   test('valid query', function(t) {
     var query = generate({
@@ -123,7 +124,7 @@ module.exports.tests.query = function(test, common) {
       layers: ['test']
     });
 
-    t.deepEqual(query, expected, 'valid search query');
+    t.deepEqual(query, createExpectedQuery(), 'valid search query');
     t.end();
   });
 
@@ -139,7 +140,7 @@ module.exports.tests.query = function(test, common) {
       layers: ['test']
     });
     
-    t.deepEqual(query, expected, 'valid search query');
+    t.deepEqual(query, createExpectedQuery(), 'valid search query');
     t.end();
   });