pelias/api - api - CogtoSrc

Commit Graph

Author	SHA1	Message	Date
Julian Simioni	103a52cff5	Calculate intersection of types requested by source and layers params	9 years ago
Julian Simioni	b4e7793426	Fix reference to geoname This is just in a unit test, so it technically passes, but geonames is not a valid layer option (geoname, singular, is used instead), so it's best to correct.	9 years ago
Julian Simioni	3383fa0321	Add source parameter sanitiser	9 years ago
Julian Simioni	2ebc935295	Rename query/indidces to query/types It didn't really contain a list of indices.	9 years ago
Julian Simioni	6f92189519	Remove default_layers_set flag! After refactoring, this flag is no longer needed, as all areas of the code that care about layers do so by setting a key within clean.types, and then the types helper intelligently combines those together later.	9 years ago
Julian Simioni	258fa4390e	Move cmd.type setting logic to types helper	9 years ago
Julian Simioni	7a6ac8541b	Separate concerns of address parser The address parser currently does two things: 1.) make some intelligent guesses as to possible admin regions to explicitly search against to improve the quality of results returned 2.) make some intelligent guesses as to when no part of the query needs to search against anything other than admin regions. This somewhat improves the quality of results returned but mostly improves the speed of the Elasticsearch query since it's searching significantly fewer recoords. These two concerns are now split into two separate methods within the query_parser helper module. They are mostly independent today, but don't have to be in the future.	9 years ago
Julian Simioni	bc8eabe4e6	Remove loops and many global checks from sanitiser tests Modifying these sanitiser tests became extremely hard because almost all of them were looping over lots of individual test cases, which places assumptions about the common behavior of potentialy very different test cases, as well as making assertions about huge swaths of output when only a small amount of that output was really under test. Hopefully these changes will make our tests easier to modify, and not really lose any ability to catch bugs.	9 years ago
Julian Simioni	1fae622c39	Remove layer configuration based on address parsing This code doesn't seem like it will be triggered very often (due to it comapring space delimited words with comma delimited words from the text field), and also has the potential to cause quite a bit of weird behavior.	9 years ago
Julian Simioni	82d3a6603c	Store sanitised types from layers parameter This moves the list of types created by sanitising the layer API parameter from clean.layers to clean.types.from_layers. In subsequent commits, types created from address parsing, and the yet-to-be-implemented source parameter will also live in the clean.types object. This will allow moving logic to set cmd.type out of controllers, and into separate logic that can be a littler smarter. Also, it will no longer require the clean.default_layers_set flag to be passed all around like a nasty global variable.	9 years ago
Julian Simioni	e71fb7cfd4	Whitespace	9 years ago
Peter Johnson	f5e182c63b	fix tests, clean by moving fixtures to fixtures dir	9 years ago
Diana Shkolnikov	2eccfc5c9a	Fix unit test	9 years ago
Diana Shkolnikov	f7044d2435	Add content for `attribution` static endpoint Fixes #212	9 years ago
Julian Simioni	a479de7527	Calculate intersection of types requested by source and layers params	9 years ago
Julian Simioni	eed010835b	Fix reference to geoname This is just in a unit test, so it technically passes, but geonames is not a valid layer option (geoname, singular, is used instead), so it's best to correct.	9 years ago
Julian Simioni	3479325fa8	Add source parameter sanitiser	9 years ago
Julian Simioni	24349a3839	Rename query/indidces to query/types It didn't really contain a list of indices.	9 years ago
Julian Simioni	3ff1752434	Remove default_layers_set flag! After refactoring, this flag is no longer needed, as all areas of the code that care about layers do so by setting a key within clean.types, and then the types helper intelligently combines those together later.	9 years ago
Julian Simioni	1573f3a3fa	Move cmd.type setting logic to types helper	9 years ago
Julian Simioni	b9152dbe29	Separate concerns of address parser The address parser currently does two things: 1.) make some intelligent guesses as to possible admin regions to explicitly search against to improve the quality of results returned 2.) make some intelligent guesses as to when no part of the query needs to search against anything other than admin regions. This somewhat improves the quality of results returned but mostly improves the speed of the Elasticsearch query since it's searching significantly fewer recoords. These two concerns are now split into two separate methods within the query_parser helper module. They are mostly independent today, but don't have to be in the future.	9 years ago
Julian Simioni	d35544cdf4	Remove loops and many global checks from sanitiser tests Modifying these sanitiser tests became extremely hard because almost all of them were looping over lots of individual test cases, which places assumptions about the common behavior of potentialy very different test cases, as well as making assertions about huge swaths of output when only a small amount of that output was really under test. Hopefully these changes will make our tests easier to modify, and not really lose any ability to catch bugs.	9 years ago
Julian Simioni	ad8db9b8e9	Remove layer configuration based on address parsing This code doesn't seem like it will be triggered very often (due to it comapring space delimited words with comma delimited words from the text field), and also has the potential to cause quite a bit of weird behavior.	9 years ago
Julian Simioni	4037c49c4b	Store sanitised types from layers parameter This moves the list of types created by sanitising the layer API parameter from clean.layers to clean.types.from_layers. In subsequent commits, types created from address parsing, and the yet-to-be-implemented source parameter will also live in the clean.types object. This will allow moving logic to set cmd.type out of controllers, and into separate logic that can be a littler smarter. Also, it will no longer require the clean.default_layers_set flag to be passed all around like a nasty global variable.	9 years ago
Julian Simioni	fb0cf514e9	Whitespace	9 years ago
Diana Shkolnikov	562338635c	Confidence score calculation Fixes pelias/pelias#120	9 years ago
Julian Simioni	63d0447b25	Update ciao tests for /v1	9 years ago
Diana Shkolnikov	1d8db6e5d1	Change type back to layer... oooops	9 years ago
Diana Shkolnikov	1b4b401a66	More property renaming/mapping * Rename `layer` to `type` and `source` * Rename `address` block and merge properties to main `geocoding` namespace	9 years ago
Diana Shkolnikov	db0e063d8c	Refactor controllers to be simple midddleware Refactor search and doc controllers to allow for post-processing middleware to handle geojson and response sending. Allows for a much more flexible routing scheme.	9 years ago
Julian Simioni	b547111d52	Remove latitude restrictions	9 years ago
Julian Simioni	396f27dcba	Mark previously invalid lat/lon test values as valid These examples should all now pass with the lat/lon wrapping.	9 years ago
Severyn Kozak	9b77b4434f	Add more test-cases for invalid bbox values. test/unit/sanitiser/search.js -Add some more sanity-check test-cases to verify that bbox validation is working as expected.	9 years ago
Severyn Kozak	762ef85f5c	Fix longitude-sanitization tests. test/unit/sanitiser/(search, suggest, reverse).js -Update/fix all of the tests that started failing as a result of the removal of longitude sanitization in `90a7683`.	9 years ago
Julian Simioni	167547a6c1	Rename doc endpoint to place	9 years ago
Julian Simioni	2fce64f75a	Move files	9 years ago
Julian Simioni	4e74e9b681	Whitespace	9 years ago
Peter Johnson	776b0ce1e1	update unit test	9 years ago
Diana Shkolnikov	49d439425e	Use address_weights.js in tests instead of hardcoding boost values	10 years ago
Diana Shkolnikov	743d8efa54	Remove proxyquire from adminField test Add comments and refactor a bit more for clarity in query/search.js	10 years ago
Diana Shkolnikov	ab436d5dfb	Search query builder not checking all available admin values Fixes #187	10 years ago
Peter Johnson	d8e86d5f17	phrase slop query modifications	10 years ago
Harish Krishna	e57d0b38ed	keys -> key It's easy to misread and think keys contains a collection of some kind	10 years ago
Harish Krishna	b3d958fe5a	Revert "match the whole query with phrase.default" This reverts commit `1c763eeb75`.	10 years ago
Harish Krishna	1c763eeb75	match the whole query with phrase.default	10 years ago
Harish Krishna	b57621c0a9	removing admin2 match from the full valid address match	10 years ago
Harish Krishna	d6bcc1b400	test search query for valid address full & partial	10 years ago
Harish Krishna	36cc6415d0	tests search	10 years ago
Harish Krishna	35105015b2	tests suggest sanitiser	10 years ago
Harish Krishna	e00c5aa2ad	Testing search sanitisers all sanitiser tests should test sanitizing input, lat/lon etc.. query parsing is tested seperately so, using query_parser to set expected.parsed_input	10 years ago

1 2 3 4 5 ...

290 Commits (4260442f59c194cef3ff420f6eac44a46c666059)