pelias/api - api - CogtoSrc

529 Commits

67 Branches

133 Tags

4.7 MiB

Tree: 6f92189519

Commit Graph

Author	SHA1	Message	Date
Julian Simioni	7a6ac8541b	Separate concerns of address parser The address parser currently does two things: 1.) make some intelligent guesses as to possible admin regions to explicitly search against to improve the quality of results returned 2.) make some intelligent guesses as to when no part of the query needs to search against anything other than admin regions. This somewhat improves the quality of results returned but mostly improves the speed of the Elasticsearch query since it's searching significantly fewer recoords. These two concerns are now split into two separate methods within the query_parser helper module. They are mostly independent today, but don't have to be in the future.	9 years ago
Julian Simioni	bc8eabe4e6	Remove loops and many global checks from sanitiser tests Modifying these sanitiser tests became extremely hard because almost all of them were looping over lots of individual test cases, which places assumptions about the common behavior of potentialy very different test cases, as well as making assertions about huge swaths of output when only a small amount of that output was really under test. Hopefully these changes will make our tests easier to modify, and not really lose any ability to catch bugs.	9 years ago
Harish Krishna	95c0e7461d	TESTS!	9 years ago

Author

SHA1

Message

Date

Julian Simioni

7a6ac8541b

Separate concerns of address parser

The address parser currently does two things:
1.) make some intelligent guesses as to possible admin regions to
explicitly search against to improve the quality of results returned
2.) make some intelligent guesses as to when no part of the query needs
to search against anything other than admin regions. This somewhat
improves the quality of results returned but mostly improves the speed
of the Elasticsearch query since it's searching significantly fewer
recoords.

These two concerns are now split into two separate methods within the
query_parser helper module. They are mostly independent today, but don't
have to be in the future.

9 years ago

Julian Simioni

bc8eabe4e6

Remove loops and many global checks from sanitiser tests

Modifying these sanitiser tests became extremely hard because almost all
of them were looping over lots of individual test cases, which places
assumptions about the common behavior of potentialy very different test
cases, as well as making assertions about huge swaths of output when
only a small amount of that output was really under test.

Hopefully these changes will make our tests easier to modify, and not
really lose any ability to catch bugs.

9 years ago

Harish Krishna

95c0e7461d

TESTS!

9 years ago

3 Commits (6f92189519eff20b86f9f0938e8ada436597323a)