pelias/api - api - CogtoSrc

Author	SHA1	Message	Date
Julian Simioni	02aac0c13e	Remove use stricts	7 years ago
Julian Simioni	f9281190ac	Corrrectly filter /place queries by layer `/place` queries have been executing in a way where only the ID, but not the layer, has been considered when returning records from Elasticsearch. It turns out this bug was introduced almost a year and a half ago in https://github.com/pelias/api/pull/407. A little, relatively unimportant bit of code was looking for a property called `layers`: ``` const cmd = req.clean.ids.map( function(id) { return { _index: apiConfig.indexName, _type: id.layers, _id: id.id }; }); ``` The correct property was `layer`, so no filtering on layer was done in the resulting [mget](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-multi-get.html) query. There was never an acceptance test for these sorts of queries, but there is now one in https://github.com/pelias/acceptance-tests/pull/446. The unit tests were enforcing the incorrect behavior. Fixes https://github.com/pelias/pelias/issues/643	7 years ago
Lily He	9405a8f370	correct timer timings for controller debug logs	7 years ago
Lily He	12a1dcba08	update controller debug timers to new format	7 years ago
Stephen Hess	6918d866b8	added comments clarifying retry logic	8 years ago
Stephen Hess	73ef71d863	moved helper functions outside of setup scope	8 years ago
Stephen Hess	ac0776e2be	match error handling to controller/search	8 years ago
Stephen Hess	9da4b9d236	standardized on name to match controller/search	8 years ago
Stephen Hess	6425cc6444	added request retries for ES request timeouts	8 years ago
Stephen Hess	40e6b1b3b7	renamed variable for clarity	8 years ago
Stephen Hess	8c249c26f4	initialize esclient in routes/v1, eliminating need for src/backend	8 years ago
Stephen Hess	00234265e6	always inject backend instead of require'ing inside	8 years ago
Stephen Hess	de2ff8cad7	removed debug	8 years ago
Peter Johnson	1451e9038e	change all log labels to 'api'	8 years ago
Julian Simioni	2557c68368	Use index name from config in controllers	8 years ago
Vesa Meskanen	a2e96987fc	Remove expensive JSON.stringify from api debug logging calls	9 years ago
Julian Simioni	ef78b2e0fd	Filter source and layer by new fields This is functionally the same code as before, except that it uses the new source and layer mapping.	9 years ago
Vesa Meskanen	269dff9dd1	Add query/response logging in debug mode to place controller, too	9 years ago
Julian Simioni	0e8f4253c0	Return multiple results in place when osm node and way share an id It turns out the _type parameter to the Elasticsearch [multiget](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-multi-get.html) API does not allow an array of possible values. We were depending on its ability to search multiple types to allow searching for OSM nodes and ways. But, since this doesn't work we essentially have to do it ourselves. There is also the problem that OSM nodes and ways share an ID space. So a gid such as `osm:venue:5` could in theory correspond to 2 records. It seems like the only nice thing to do in that case is return both results. This PR "unrolls" such queries. For example, in the case of `osm:venue:5`, the sanitisers will return the following array of objects to be turned into multiget queries: ``` [{ id: 5, types: ["osmway", "osmnode"] }] ``` Before, this would turn into a multiget query with only one entry, like this: ``` { "docs": [ { "_index": "pelias", "_type": [ " osmnode", "osmway" ], "_id": 5 } ] } ``` now it would look like this: { "docs": [ { "_index": "pelias", "_type": "osmnode", "_id": 5 }, { "_index": "pelias", "_type": "osmnode", "_id": 5 } ] } TLDR you might get back more records from /place than the number of ids you specified, but at least you will definitely get back what you are looking for.	9 years ago
Peter Johnson	c609ae3ccf	http friendly status codes. resolves #321	9 years ago
Stephen Hess	cb7d22df91	switched ES lookup field from "type" -> "_type", fixes issue with /place lookup on Eiffel Tower gid	9 years ago
Julian Simioni	a2cc31f142	Leave a note for future us A small essay on Elasticsearch queries and fields and types.	9 years ago
Julian Simioni	2505e92a62	Expect an array of types from _ids sanitiser This doesn't have any effect by itself but allows for the 3-part gid sanitiser to possibly return multiple types (i.e. in the case of osm:venue:1000)	9 years ago
Peter Johnson	348d2e70e2	more conformance	9 years ago
Peter Johnson	7c46aed4a7	expose error messages in geojson	9 years ago
Peter Johnson	6ab81ffca5	set response data/meta on instead of	9 years ago
Diana Shkolnikov	db0e063d8c	Refactor controllers to be simple midddleware Refactor search and doc controllers to allow for post-processing middleware to handle geojson and response sending. Allows for a much more flexible routing scheme.	9 years ago
Julian Simioni	2fce64f75a	Move files	9 years ago
Julian Simioni	4e74e9b681	Whitespace	9 years ago
Harish Krishna	14c718bf1c	passing in an object (req.clean) instead of a boolean. Plus updated test	10 years ago
Harish Krishna	c99c5f712a	adding a parameter called details (defaults to false for all endpoint except reverse) + fixing tests	10 years ago
Peter Johnson	2ee32f1892	mget service	10 years ago
Harish Krishna	81b3668b30	get to doc	10 years ago
Harish Krishna	b828a05b01	simplifying things, DRY - one endpoint 'GET' handles single/multiple requests. plus test coverage	10 years ago
Harish Krishna	fb6947e3fe	/get endpoint - controller and sanitizer	10 years ago
Harish Krishna	0a58bc9fea	adding type only if clean.layers are not undefined	10 years ago
Harish Krishna	ef95f5b67d	adding type	10 years ago
Peter Johnson	17134105d5	geojsonify /search and /reverse FTW	10 years ago
Peter Johnson	d6ae185cc1	validity check	10 years ago
Harish Krishna	15c63e405c	adding a naive reverse api endpoint (also, shares most of the search controller). updated search query to include a filter and a sort (calculating a bounding box, given a lat/lon)	10 years ago
Harish Krishna	554bbc62d3	adding search api endpoint and test (lat/lon in the query pending)	10 years ago
Peter Johnson	4323b0030b	progress commit	10 years ago
Peter Johnson	f48239a7d4	current dev branch	10 years ago