pelias/api - api - CogtoSrc

Commit Graph

Author	SHA1	Message	Date
Julian Simioni	9a0f182fb2	fix(whitespace): Trim whitespace and quotes before checking text length Previously, our text sanitizer code did not trim whitespace before checking that the string was non-empty. This lead to strings consisting only of whitespace being treated as valid. Not all our downstream services (such as libpostal) accept whitespace-only input, so this causes a rather harsh error. This PR builds upon the code in https://github.com/pelias/api/pull/1170 and moves the trimming code above the nonEmptyString check. Now, a whitespace-only input string produces the normal error for empty input. Fixes https://github.com/pelias/api/issues/1158	6 years ago
Julian Simioni	435cfd2c4a	Fix linter error This snuck in in https://github.com/pelias/api/pull/1165	6 years ago
Tyler Pedelose	52a66e1bc0	Added new predicates to aid placeholderGeodisambiguationShouldExecute	6 years ago
Peter Johnson	d38d4b1fa8	feat(text_sanitizer): trim whitespace and quotation marks from a range of natural languages	6 years ago
Julian Simioni	561f07950b	Remove focus_selected_layers query view This query extends the standard focus query view with hardcoded layers for which the query applies. The intent was to apply the focus scoring only to non-admin areas, but the list of layers was already out of date, as it was missing streets. The query is fundamentally problematic with custom layers as well.	7 years ago
Julian Simioni	10241047a6	fix(interpolation): Ensure proper sorting of streets with interpolated addresses In cases where several conditions are met, it is possible for results to be returned from the API that are not sorted as they were intended. These conditions are: * over 10 results total were returned from Elasticsearch * the interpolation middleware was called * not all street results end up with possible interpolated address matches, and some of those streets come before other interpolated address records, necessitating a re-sorting of the results in the interpolation middleware In these cases, the ordering of streets as defined by Elasticsearch, such as by linguistic match or distance from a focus point, will no longer be respected in the results. This is because Node.js's `Array.prototype.sort` uses an [unstable QuickSort for arrays of size 11 or greater](https://github.com/nodejs/node/blob/master/deps/v8/src/js/array.js#L670). The solution is to switch to a sorting algorithm that is always stable. This ensures that whatever ordering was specified in the Elasticsearch queries is observed, without any of that logic having to be duplicated, and then possibly conflict. Stable sorting is provided by the [stable](http://npmjs.com/stable) NPM package.	7 years ago
Peter Johnson	e15aa52f63	feat(type_mapping): rename function to avoid confusion with elasticsearch API	7 years ago
missinglink	b1cfd091ed	type_mapping: add unit tests	7 years ago
missinglink	63c962503c	test: improved type_mapping tests	7 years ago
semhul	a0aa5ed7f2	Adding support for unit field in structured search. If libpostal finds it in input use it for searching	7 years ago
Julian Simioni	204f5297de	Remove all leading newlines in files	7 years ago
Julian Simioni	02aac0c13e	Remove use stricts	7 years ago
Julian Simioni	8bccfc4fd2	Remove other instances of Mapzen	7 years ago
missinglink	59f0f4d70e	add line comment, fix line comment	7 years ago
missinglink	e01fdb85c9	support aliases for label generation	7 years ago
missinglink	7a01e794cf	support aliases for name fields	7 years ago
Julian Simioni	dccad99d78	Move sizeCalculator middleware tests to the correct place	7 years ago
Julian Simioni	f887d7a249	Rename test setup function It now can be confused for the middleware setup function	7 years ago
Julian Simioni	94946989bb	Test cases with a lower min query size	7 years ago
Julian Simioni	825b506a75	Revise tests to account for sizeCalculator setup params	7 years ago
antoine-de	3489517da3	dedup osm/OA address linked to https://github.com/pelias/pelias/issues/541 and maybe to https://github.com/pelias/pelias/issues/541 but I cannot reproduce it. and to the fact that there are lots of dupplicates in france like: [20 rue hector malot paris](https://mapzen.com/search/explorer/?query=search&text=20%20rue%20hector%20malot%20paris) that returns 1 result from open address and 1 result from OSM now we first check which source has a zipcode and if both have, we prefer OA over OSM	7 years ago
Joxit	551f0227db	Transliterates Saint and Sainte in ES schema see pelias/schema#268	7 years ago
Joxit	d187e7d950	Fix for #1077 , fail to search `Saint..` cities in structured queries	7 years ago
Rhys Kidd	1dfc6988ed	Update to current Pelias contact email address Per https://github.com/pelias/pelias/tree/master/announcements/2018-01-02-pelias-update replace all @mapzen.com email addresses with the current Pelias contact email address. grep used to confirm no '@mapzen.com' remain.	7 years ago
sweco-semhul	51709b58ff	Updating ciao tests to reflect current status in master to make them run	7 years ago
Stephen Hess	e0c25d0f57	convert libpostal calls to a microservice	7 years ago
Stephen Hess	b5e48afb35	remove text-analyzer address operation	7 years ago
Stephen Hess	f56deffb8f	allow libpostal configuration in schema w/other services	7 years ago
Diana Shkolnikov	cb59e305b0	log number of streets to be interpolated	7 years ago
Peter Backx	f16565df9e	Verify min and max longitude and latitude Otherwise this can potentially lead to a fairly weird Elasticsearch error mentioned in https://github.com/pelias/pelias/issues/656	7 years ago
Julian Simioni	bc6401842c	Add friendly, coarse specific error message to reverse This error message is updated to mention the coarse-reverse only nature of Geonames support removal. It also links to the [tracking ticket](https://github.com/pelias/acceptance-tests/pull/447) for Geonames removal which should help provide more context to users.	7 years ago
Stephen Hess	004e3c02b1	completed switch to vs tests over fixtures	7 years ago
Julian Simioni	d577d42d9f	Support geonames non-coarse reverse in deprecation sanitizer	7 years ago
Stephen Hess	110a258130	added initial tests for using vs	7 years ago
Julian Simioni	f9281190ac	Corrrectly filter /place queries by layer `/place` queries have been executing in a way where only the ID, but not the layer, has been considered when returning records from Elasticsearch. It turns out this bug was introduced almost a year and a half ago in https://github.com/pelias/api/pull/407. A little, relatively unimportant bit of code was looking for a property called `layers`: ``` const cmd = req.clean.ids.map( function(id) { return { _index: apiConfig.indexName, _type: id.layers, _id: id.id }; }); ``` The correct property was `layer`, so no filtering on layer was done in the resulting [mget](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-multi-get.html) query. There was never an acceptance test for these sorts of queries, but there is now one in https://github.com/pelias/acceptance-tests/pull/446. The unit tests were enforcing the incorrect behavior. Fixes https://github.com/pelias/pelias/issues/643	7 years ago
Stephen Hess	66d4149f6a	removed references to outdated request parameters	7 years ago
Stephen Hess	02cfa36d24	switched structured query tests away from fixtures	7 years ago
Stephen Hess	da07463999	set req.clean.parser to 'libpostal' when it's called	7 years ago
Stephen Hess	3a862c17ec	move empire include/exclude logic to eojsonify_place_details	7 years ago
Stephen Hess	e4e8d9b0bf	if country_gid exists, remove empire fields	7 years ago
Stephen Hess	05da79923f	wrap interpolation service call to intercept errors	7 years ago
Stephen Hess	18e7673dc1	added empire to coarse translation	7 years ago
Stephen Hess	2df5d6d23b	add empire to coarse reverse controller	7 years ago
Stephen Hess	5b86fbd7d8	add layers parameter support to PointInPolygon service request	7 years ago
Stephen Hess	214c3807eb	added continent, ocean, and marinearea to geojsonify	7 years ago
Stephen Hess	9d54735e41	converted geojsonify_place_details to return instead of modify	7 years ago
Stephen Hess	cd99f87c04	inlined and condensed doc setup	7 years ago
Stephen Hess	5e1360f022	refactored geojsonify, improved test coverage	7 years ago
Stephen Hess	27194a620e	added tests for geocode_place_details	7 years ago
Stephen Hess	e70a668056	added support for continent, ocean, and marinearea placetypes `coarse` now maps to these as well	7 years ago

1 2 3 4 5 ...

966 Commits (9a0f182fb204dae704d10a4067d0041a388989b0)