Julian Simioni
f9281190ac
Corrrectly filter /place queries by layer
...
`/place` queries have been executing in a way where only the ID, but not
the layer, has been considered when returning records from
Elasticsearch.
It turns out this bug was introduced almost a year and a half ago in
https://github.com/pelias/api/pull/407 . A little, relatively unimportant
bit of code was looking for a property called `layers`:
```
const cmd = req.clean.ids.map( function(id) {
return {
_index: apiConfig.indexName,
_type: id.layers,
_id: id.id
};
});
```
The correct property was `layer`, so no filtering on layer was done in
the resulting [mget](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-multi-get.html ) query.
There was never an acceptance test for these sorts of queries, but there
is now one in https://github.com/pelias/acceptance-tests/pull/446 . The
unit tests were enforcing the incorrect behavior.
Fixes https://github.com/pelias/pelias/issues/643
7 years ago
Stephen Hess
da07463999
set req.clean.parser to 'libpostal' when it's called
7 years ago
Stephen Hess
2df5d6d23b
add empire to coarse reverse controller
7 years ago
Stephen Hess
e70a668056
added support for continent, ocean, and marinearea placetypes
...
`coarse` now maps to these as well
7 years ago
missinglink
69a820fae0
feat(coarse_reverse): ignore empty abbr properties from PIP service
7 years ago
missinglink
3913c836e2
feat(coarse_reverse): improve logger assertions
7 years ago
missinglink
b88d2a0abe
feat(coarse_reverse): add try/catch block around synthesizeDoc code
7 years ago
missinglink
45f313d8d9
feat(coarse_reverse): improve logger assertions
7 years ago
missinglink
c72822b805
feat(coarse_reverse): add try/catch block around synthesizeDoc code
7 years ago
Lily He
9405a8f370
correct timer timings for controller debug logs
7 years ago
Lily He
ad1d88ac62
log libpostal and placeholder responses to debug
7 years ago
Lily He
12a1dcba08
update controller debug timers to new format
7 years ago
Lily He
9ee5025312
predicates debugging prints stack trace snippet
7 years ago
Stephen Hess
ab332e43ee
removed unused is_service_enabled predicate
7 years ago
Stephen Hess
951b18e656
switched to has_parsed_text_properties
7 years ago
Stephen Hess
c8c969db74
added predicate for any/all parsed_text fields
7 years ago
Lily He
a2848ff6f0
debug messages for controller/search & predicates
7 years ago
Stephen Hess
b0d2e8c74a
capitalization
7 years ago
Stephen Hess
aac1780db7
reworded comment
7 years ago
Stephen Hess
f9996cd6b0
added word
7 years ago
Stephen Hess
15b07cfbf8
clarified parameter names, added comments
7 years ago
Stephen Hess
5dcdf60a95
added comment
7 years ago
Stephen Hess
9aca556dd3
switch to simpler check since we know what's coming back
7 years ago
Stephen Hess
e82993cb3f
added comments and syntax updates
7 years ago
Stephen Hess
257ee8161f
removed unused predicate
7 years ago
Stephen Hess
5b9275d7fd
added libpostal controller
7 years ago
Stephen Hess
44896d7569
add predicate that checks for sources=['whosonfirst']
7 years ago
Stephen Hess
59fb445e68
add predicate that detects non-admin layers parameter values
7 years ago
Stephen Hess
ce4c23f4a5
add predicate that looks for a parameter in req.clean
7 years ago
Stephen Hess
40ddc93bbf
added conditional fallback to addressit
7 years ago
Stephen Hess
442c2b5c9b
add ability to skip filters in placeholder
7 years ago
Stephen Hess
9ae838903a
converted to 'any' property for brevity
7 years ago
Stephen Hess
eb4a896272
removed debug
7 years ago
Stephen Hess
98b6829e31
exclude venue, address, and street from layers filter
7 years ago
Stephen Hess
d3bd68b95a
removed debug
7 years ago
Stephen Hess
568a258406
code cleanup, shorter function syntax
7 years ago
Stephen Hess
147d76f9d7
added controller for searching with ids
7 years ago
Stephen Hess
e158c21685
added has_parsed_text_property predicate
7 years ago
Stephen Hess
580a9b16c8
set query_type for placeholder to enable confidencescores
7 years ago
Stephen Hess
2ba23cbb62
added warning if boundary.circle.radius is defined
8 years ago
Stephen Hess
788a8c8069
refactored for lodash because its siren song is so sweet
8 years ago
Stephen Hess
d67830ca48
removed unneeded conditional for abbreviation set
8 years ago
Stephen Hess
f721d68e9c
removed alpha3 set
8 years ago
Stephen Hess
39e91d8233
remove address/venue/street from requested layers when creating results
...
refactored for cleanliness and clarity
8 years ago
Stephen Hess
1d4318868b
added helper for removed non-coarse layers
8 years ago
Stephen Hess
6e693db87e
added support for non-coarse req.clean.layers
8 years ago
Stephen Hess
a2589cfeb7
switched to _.isEmpty check
8 years ago
Stephen Hess
e97950c142
adapted coarse reverse controller to generic service
8 years ago
Stephen Hess
c602794ed8
added predicate for finding results at given layers
8 years ago
Stephen Hess
3ae431073d
removed debug line
8 years ago