From a04472832aefc9d15eb0bca97fdd785e4f1c0576 Mon Sep 17 00:00:00 2001 From: "Dr. Kibitz" Date: Sat, 20 Jul 2013 23:57:47 -0700 Subject: [PATCH] Add 'use strict', fix global leak --- resemble.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/resemble.js b/resemble.js index 4dd1609..506fd9c 100644 --- a/resemble.js +++ b/resemble.js @@ -6,6 +6,7 @@ URL: https://github.com/Huddle/Resemble.js */ (function(_this){ + 'use strict'; _this['resemble'] = function( fileData ){ @@ -84,7 +85,7 @@ URL: https://github.com/Huddle/Resemble.js }; hiddenImage.onload = function() { - + var hiddenCanvas = document.createElement('canvas'); var imageData; var width = hiddenImage.width; @@ -94,7 +95,7 @@ URL: https://github.com/Huddle/Resemble.js hiddenCanvas.height = height; hiddenCanvas.getContext('2d').drawImage(hiddenImage, 0, 0, width, height); imageData = hiddenCanvas.getContext('2d').getImageData(0, 0, width, height); - + images.push(imageData); callback(imageData, width, height); @@ -338,7 +339,7 @@ URL: https://github.com/Huddle/Resemble.js } return; } - + if( isRGBSimilar(pixel1, pixel2) ){ copyPixel(targetPix, offset, pixel2); @@ -449,7 +450,8 @@ URL: https://github.com/Huddle/Resemble.js function getCompareApi(param){ - var hasMethod = typeof param === 'function'; + var secondFileData, + hasMethod = typeof param === 'function'; if( !hasMethod ){ // assume it's file data @@ -458,7 +460,7 @@ URL: https://github.com/Huddle/Resemble.js var self = { ignoreNothing: function(){ - + tolerance.red = 16; tolerance.green = 16; tolerance.blue = 16; @@ -486,7 +488,7 @@ URL: https://github.com/Huddle/Resemble.js return self; }, ignoreColors: function(){ - + tolerance.minBrightness = 16; tolerance.maxBrightness = 240;