From ee86bc2bbcc2b3d1c173dda5c942da4d948b869c Mon Sep 17 00:00:00 2001
From: Tim van der Lippe <tvanderlippe@gmail.com>
Date: Tue, 3 May 2016 13:40:18 +0200
Subject: [PATCH 1/3] Fix compilation on ES5 for Polymer

---
 Sortable.html | 102 +++++++++++++++++++++++++-------------------------
 1 file changed, 52 insertions(+), 50 deletions(-)

diff --git a/Sortable.html b/Sortable.html
index 77994ce..4ec31b8 100644
--- a/Sortable.html
+++ b/Sortable.html
@@ -7,11 +7,12 @@
   </template>
 </dom-module>
 <script>
+'use strict';
   Polymer({
     is: "sortable-js",
 
     properties: {
-      group             : { type: String, value: function() { return Math.random() }, observer: "groupChanged" },
+      group             : { type: String, value: function() { return Math.random(); }, observer: "groupChanged" },
       sort              : { type: Boolean, value: true, observer: "sortChanged" },
       disabled          : { type: Boolean, value: false, observer: "disabledChanged" },
       store             : { type: Object, value: null, observer: "storeChanged" },
@@ -34,12 +35,12 @@
       scroll            : {}
     },
 
-    created() {
+    created: function() {
       // override default DOM property behavior
       Object.defineProperties(this, {
-        draggable: { get() { return this._draggable || this.getAttribute("draggable") || ">*"}, set(value) { this._draggable = value; this.draggableChanged(value)} },
-        scroll: { get() { return this._scroll || JSON.parse(this.getAttribute("scroll") || "true") }, set(value) { this._scroll = value; this.scrollChanged(value)} }
-      })
+        draggable: { get: function() { return this._draggable || this.getAttribute("draggable") || ">*";}, set: function(value) { this._draggable = value; this.draggableChanged(value);} },
+        scroll: { get: function() { return this._scroll || JSON.parse(this.getAttribute("scroll") || "true"); }, set: function(value) { this._scroll = value; this.scrollChanged(value);} }
+      });
     },
 
     attached: function() {
@@ -55,99 +56,100 @@
       //       <span>hello</span>
       //       <template is="dom-if">
       //     <tempalte is="dom-repeat">
-      var templates = this.querySelectorAll("template[is='dom-repeat']")
-      var template = templates[templates.length-1]
+      var templates = this.querySelectorAll("template[is='dom-repeat']");
+      var template = templates[templates.length-1];
 
-      var options = {}
+      var options = {};
       Object.keys(this.properties).forEach(function(key) {
-        options[key] = this[key]
-      });
+        options[key] = this[key];
+      }.bind(this));
 
+      var self = this;
       var eventCallbacks = {
         onUpdate: function (e) {
           if (template) {
-            template.splice("items", e.newIndex, 0, template.splice("items", e.oldIndex, 1)[0])
+            template.splice("items", e.newIndex, 0, template.splice("items", e.oldIndex, 1)[0]);
           }
-          this.fire("update", e)
+          self.fire("update", e);
         },
 
         onAdd: function(e) {
           if (template) {
-            var froms = e.from.querySelectorAll("template[is='dom-repeat']")
-            var from = froms[froms.length-1]
-            var item = from.items[e.oldIndex]
-            template.splice("items", e.newIndex, 0, item)
+            var froms = e.from.querySelectorAll("template[is='dom-repeat']");
+            var from = froms[froms.length-1];
+            var item = from.items[e.oldIndex];
+            template.splice("items", e.newIndex, 0, item);
           }
-          this.fire("add", e)
+          self.fire("add", e);
         },
 
         onRemove: function(e) {
           if (template) {
-            template.splice("items", e.oldIndex, 1)[0]
+            template.splice("items", e.oldIndex, 1)[0];
           }
-          this.fire("remove", e)
+          self.fire("remove", e);
         },
 
         onChoose: function(e) {
-          this.fire("choose", e)
+          self.fire("choose", e);
         },
 
         onStart: function(e) {
-          this.fire("start", e)
+          self.fire("start", e);
         },
 
         onEnd: function(e) {
-          this.fire("end", e)
+          self.fire("end", e);
         },
 
         onSort: function(e) {
-          this.fire("sort", e)
+          self.fire("sort", e);
         },
 
         onFilter: function(e) {
-          this.fire("filter", e)
+          self.fire("filter", e);
         },
 
         onMove: function(e) {
-          this.fire("move", e)
+          self.fire("move", e);
         },
 
         onClone: function(e) {
-          this.fire("clone", e)
+          self.fire("clone", e);
         }
       };
 
       Object.keys(eventCallbacks).forEach(function(name){
         options[name] = eventCallbacks[name];
       });
-      
+
       this.sortable = Sortable.create(this, options);
     },
 
     detached: function() {
-      this.sortable.destroy()
+      this.sortable.destroy();
     },
 
-    groupChanged             : function(value) { this.sortable && this.sortable.option("group", value) },
-    sortChanged              : function(value) { this.sortable && this.sortable.option("sort", value) },
-    disabledChanged          : function(value) { this.sortable && this.sortable.option("disabled", value) },
-    storeChanged             : function(value) { this.sortable && this.sortable.option("store", value) },
-    handleChanged            : function(value) { this.sortable && this.sortable.option("handle", value) },
-    scrollChanged           : function(value) { this.sortable && this.sortable.option("scroll", value) },
-    scrollSensitivityChanged : function(value) { this.sortable && this.sortable.option("scrollSensitivity", value) },
-    scrollSpeedChanged       : function(value) { this.sortable && this.sortable.option("scrollSpeed", value) },
-    draggableChanged        : function(value) { this.sortable && this.sortable.option("draggable", value) },
-    ghostClassChanged        : function(value) { this.sortable && this.sortable.option("ghostClass", value) },
-    chosenClassChanged       : function(value) { this.sortable && this.sortable.option("chosenClass", value) },
-    ignoreChanged            : function(value) { this.sortable && this.sortable.option("ignore", value) },
-    filterChanged            : function(value) { this.sortable && this.sortable.option("filter", value) },
-    animationChanged         : function(value) { this.sortable && this.sortable.option("animation", value) },
-    dropBubbleChanged        : function(value) { this.sortable && this.sortable.option("dropBubble", value) },
-    dragoverBubbleChanged    : function(value) { this.sortable && this.sortable.option("dragoverBubble", value) },
-    dataIdAttrChanged        : function(value) { this.sortable && this.sortable.option("dataIdAttr", value) },
-    delayChanged             : function(value) { this.sortable && this.sortable.option("delay", value) },
-    forceFallbackChanged     : function(value) { this.sortable && this.sortable.option("forceFallback", value) },
-    fallbackClassChanged     : function(value) { this.sortable && this.sortable.option("fallbackClass", value) },
-    fallbackOnBodyChanged    : function(value) { this.sortable && this.sortable.option("fallbackOnBody", value) }
-  })
+    groupChanged             : function(value) { this.sortable && this.sortable.option("group", value); },
+    sortChanged              : function(value) { this.sortable && this.sortable.option("sort", value); },
+    disabledChanged          : function(value) { this.sortable && this.sortable.option("disabled", value); },
+    storeChanged             : function(value) { this.sortable && this.sortable.option("store", value); },
+    handleChanged            : function(value) { this.sortable && this.sortable.option("handle", value); },
+    scrollChanged           : function(value) { this.sortable && this.sortable.option("scroll", value); },
+    scrollSensitivityChanged : function(value) { this.sortable && this.sortable.option("scrollSensitivity", value); },
+    scrollSpeedChanged       : function(value) { this.sortable && this.sortable.option("scrollSpeed", value); },
+    draggableChanged        : function(value) { this.sortable && this.sortable.option("draggable", value); },
+    ghostClassChanged        : function(value) { this.sortable && this.sortable.option("ghostClass", value); },
+    chosenClassChanged       : function(value) { this.sortable && this.sortable.option("chosenClass", value); },
+    ignoreChanged            : function(value) { this.sortable && this.sortable.option("ignore", value); },
+    filterChanged            : function(value) { this.sortable && this.sortable.option("filter", value); },
+    animationChanged         : function(value) { this.sortable && this.sortable.option("animation", value); },
+    dropBubbleChanged        : function(value) { this.sortable && this.sortable.option("dropBubble", value); },
+    dragoverBubbleChanged    : function(value) { this.sortable && this.sortable.option("dragoverBubble", value); },
+    dataIdAttrChanged        : function(value) { this.sortable && this.sortable.option("dataIdAttr", value); },
+    delayChanged             : function(value) { this.sortable && this.sortable.option("delay", value); },
+    forceFallbackChanged     : function(value) { this.sortable && this.sortable.option("forceFallback", value); },
+    fallbackClassChanged     : function(value) { this.sortable && this.sortable.option("fallbackClass", value); },
+    fallbackOnBodyChanged    : function(value) { this.sortable && this.sortable.option("fallbackOnBody", value); }
+  });
 </script>

From 643d9afe85d31e3cae4eb6277868a8efacc02876 Mon Sep 17 00:00:00 2001
From: Tim van der Lippe <tvanderlippe@gmail.com>
Date: Tue, 3 May 2016 15:56:37 +0200
Subject: [PATCH 2/3] Fix issue with dragEl undefined when moving with a
 Polymer element

---
 Sortable.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Sortable.js b/Sortable.js
index 52b2d2d..55e8f2f 100644
--- a/Sortable.js
+++ b/Sortable.js
@@ -744,8 +744,9 @@
 								target.parentNode.insertBefore(dragEl, after ? nextSibling : target);
 							}
 						}
-
-						parentEl = dragEl.parentNode; // actualization
+						if (dragEl) {
+							parentEl = dragEl.parentNode; // actualization
+						}
 
 						this._animate(dragRect, dragEl);
 						this._animate(targetRect, target);

From 238216d8c94009947505cef8ffd4d1cf9d7fee10 Mon Sep 17 00:00:00 2001
From: Tim van der Lippe <tvanderlippe@gmail.com>
Date: Wed, 22 Jun 2016 17:27:47 +0200
Subject: [PATCH 3/3] Fix feedback

---
 Sortable.html | 22 +++++++++++-----------
 Sortable.js   |  5 ++---
 2 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/Sortable.html b/Sortable.html
index 4ec31b8..bb7bc22 100644
--- a/Sortable.html
+++ b/Sortable.html
@@ -64,13 +64,13 @@
         options[key] = this[key];
       }.bind(this));
 
-      var self = this;
+      var _this = this;
       var eventCallbacks = {
         onUpdate: function (e) {
           if (template) {
             template.splice("items", e.newIndex, 0, template.splice("items", e.oldIndex, 1)[0]);
           }
-          self.fire("update", e);
+          _this.fire("update", e);
         },
 
         onAdd: function(e) {
@@ -80,42 +80,42 @@
             var item = from.items[e.oldIndex];
             template.splice("items", e.newIndex, 0, item);
           }
-          self.fire("add", e);
+          _this.fire("add", e);
         },
 
         onRemove: function(e) {
           if (template) {
             template.splice("items", e.oldIndex, 1)[0];
           }
-          self.fire("remove", e);
+          _this.fire("remove", e);
         },
 
         onChoose: function(e) {
-          self.fire("choose", e);
+          _this.fire("choose", e);
         },
 
         onStart: function(e) {
-          self.fire("start", e);
+          _this.fire("start", e);
         },
 
         onEnd: function(e) {
-          self.fire("end", e);
+          _this.fire("end", e);
         },
 
         onSort: function(e) {
-          self.fire("sort", e);
+          _this.fire("sort", e);
         },
 
         onFilter: function(e) {
-          self.fire("filter", e);
+          _this.fire("filter", e);
         },
 
         onMove: function(e) {
-          self.fire("move", e);
+          _this.fire("move", e);
         },
 
         onClone: function(e) {
-          self.fire("clone", e);
+          _this.fire("clone", e);
         }
       };
 
diff --git a/Sortable.js b/Sortable.js
index 55e8f2f..52b2d2d 100644
--- a/Sortable.js
+++ b/Sortable.js
@@ -744,9 +744,8 @@
 								target.parentNode.insertBefore(dragEl, after ? nextSibling : target);
 							}
 						}
-						if (dragEl) {
-							parentEl = dragEl.parentNode; // actualization
-						}
+
+						parentEl = dragEl.parentNode; // actualization
 
 						this._animate(dragRect, dragEl);
 						this._animate(targetRect, target);