Currently the next and previous controls will overlap when embedded on an RTL page. This commit makes the controls usable but doesn’t start the larger project of flipping the various left/right classes applied to .nav-next / .nav-previous elements or updating the JavaScript to use “left” or “right” based on whether the timeline is embedded in a dir=rtl or dir=ltr element.
prop() previously had a version check for jQuery’s prop()
function which failed, causing it to never return values for
e.g. scrollHeight.
attribute() previously always hit the setter path because it
didn’t check for value being undefined so it always called
jQuery using the two argument form.
This might be worth either splitting animate() into one for DOM
properties and one for pure-CSS or replacing the scrollTop animation
with something like margin or, better yet, transform.
This ensures that the tag list will be consistent rather
than based on the browser’s internal hash implementation. It
also allows a custom override function to be configured when
simple alphabetic sorting is not sufficient.
Closes#342Closes#505
I've converted the chinese characters for the numeric month back to numbers, as it is more consistent with the way the date is shown, with the numeric year and numeric day.
An update to browser to check for Trident Version, IE8 reports as IE7
when in certain zones. This check determines more accurately actual IE7
or 8 version.
Requests that soundcloud render an iframe with a maxheight of 168.
Without this, you end up with a very tall soundcloud iframe which hides
the timeline dropshadow and caption.
* Currently IE 8,9,10,11 etc users will see an 'IE 7 is not supported' message if they try and view a timeline while IE's compatibility mode is enabled.
* This is confusing as the user knows they are not using IE7.
* This commit alters the error message to include the sentence 'If you are using a recent version of Internet Explorer you may need to disable compatibility mode in your browser.'
* I haven't provided a link to guidance on how to do this as there doesn't seem to be an official Microsoft source on how to *disable* compatibility mode, and I didn't want to link to an unofficial source that might become unavailable in the future.
Maciej Rzepiński
sipp11
Chris Adams
Joe Germuska
1492sen
nimashahbazi90
Darcy W. Christ
DanKeeling
Drew Freyling
Canton Becker
bpalir
fisch42
Phil Wolstenholme