Fix data label on negative bar chart

10 years ago · 97cc3eb349
3 changed files with 9 additions and 5 deletions
--- a/c3.js
+++ b/c3.js
@ -3346,11 +3346,13 @@
    };
    c3_chart_internal_fn.getYForText = function (points, d, textElement) {
        var $$ = this,
-            box = textElement.getBoundingClientRect(), yPos;
+            box = textElement.getBoundingClientRect(),
+            offset = $$.isBarType(d) ? 0 : 3,
+            yPos;
        if ($$.config.axis_rotated) {
            yPos = (points[0][0] + points[2][0] + box.height * 0.6) / 2;
        } else {
-            yPos = points[2][1] + (d.value < 0 ? box.height * 1.3 : $$.isBarType(d) ? -3 : -6);
+            yPos = points[2][1] + (d.value < 0 ? box.height + offset : (-3 - offset));
        }
        // show labels regardless of the domain if value is null
        if (d.value === null && !$$.config.axis_rotated) {
--- a/c3.min.js
+++ b/c3.min.js
--- a/src/text.js
+++ b/src/text.js
@ -92,11 +92,13 @@ c3_chart_internal_fn.getXForText = function (points, d, textElement) {
 };
 c3_chart_internal_fn.getYForText = function (points, d, textElement) {
    var $$ = this,
-        box = textElement.getBoundingClientRect(), yPos;
+        box = textElement.getBoundingClientRect(),
+        offset = $$.isBarType(d) ? 0 : 3,
+        yPos;
    if ($$.config.axis_rotated) {
        yPos = (points[0][0] + points[2][0] + box.height * 0.6) / 2;
    } else {
-        yPos = points[2][1] + (d.value < 0 ? box.height * 1.3 : $$.isBarType(d) ? -3 : -6);
+        yPos = points[2][1] + (d.value < 0 ? box.height + offset : (-3 - offset));
    }
    // show labels regardless of the domain if value is null
    if (d.value === null && !$$.config.axis_rotated) {