Browse Source

adding in try around __import__ to catch invalid files/paths (#1950)

pull/1985/head
Nate Prewitt 8 years ago committed by Markus Unterwaditzer
parent
commit
0f1cf50f97
  1. 8
      flask/cli.py
  2. 2
      tests/test_cli.py

8
flask/cli.py

@ -86,7 +86,13 @@ def locate_app(app_id):
module = app_id module = app_id
app_obj = None app_obj = None
__import__(module) try:
__import__(module)
except ImportError:
raise NoAppException('The file/path provided (%s) does not appear to '
'exist. Please verify the path is correct. If '
'app is not on PYTHONPATH, ensure the extension '
'is .py' % module)
mod = sys.modules[module] mod = sys.modules[module]
if app_obj is None: if app_obj is None:
app = find_best_app(mod) app = find_best_app(mod)

2
tests/test_cli.py

@ -80,6 +80,8 @@ def test_locate_app(test_apps):
assert locate_app("cliapp.app").name == "testapp" assert locate_app("cliapp.app").name == "testapp"
assert locate_app("cliapp.app:testapp").name == "testapp" assert locate_app("cliapp.app:testapp").name == "testapp"
assert locate_app("cliapp.multiapp:app1").name == "app1" assert locate_app("cliapp.multiapp:app1").name == "app1"
pytest.raises(NoAppException, locate_app, "notanpp.py")
pytest.raises(NoAppException, locate_app, "cliapp/app")
pytest.raises(RuntimeError, locate_app, "cliapp.app:notanapp") pytest.raises(RuntimeError, locate_app, "cliapp.app:notanapp")

Loading…
Cancel
Save