Browse Source

Add tests for adding exception to response contents only when DEBUG is True

pull/1360/head
Keyan Pishdadian 10 years ago
parent
commit
39e66ca6d7
  1. 24
      tests/test_helpers.py

24
tests/test_helpers.py

@ -49,6 +49,30 @@ class TestJSON(object):
assert rv.mimetype == 'application/json' assert rv.mimetype == 'application/json'
assert flask.json.loads(rv.data)['x'] == http_date(d.timetuple()) assert flask.json.loads(rv.data)['x'] == http_date(d.timetuple())
def test_post_empty_json_adds_exception_to_reponse_content_in_debug(self):
app = flask.Flask(__name__)
app.config['DEBUG'] = True
@app.route('/json', methods=['POST'])
def post_json():
flask.request.get_json()
return None
c = app.test_client()
rv = c.post('/json', data=None, content_type='application/json')
assert rv.status_code == 400
assert '<p>No JSON object could be decoded</p>' in rv.data
def test_post_empty_json_doesnt_add_exception_to_reponse_if_no_debug(self):
app = flask.Flask(__name__)
app.config['DEBUG'] = False
@app.route('/json', methods=['POST'])
def post_json():
flask.request.get_json()
return None
c = app.test_client()
rv = c.post('/json', data=None, content_type='application/json')
assert rv.status_code == 400
assert '<p>No JSON object could be decoded</p>' not in rv.data
def test_json_bad_requests(self): def test_json_bad_requests(self):
app = flask.Flask(__name__) app = flask.Flask(__name__)
@app.route('/json', methods=['POST']) @app.route('/json', methods=['POST'])

Loading…
Cancel
Save