Test that we're not leaking a request context in the testsuite, fixed a leak

tests/flask_tests.py

@@ -96,7 +96,15 @@ def emits_module_deprecation_warning(f):
 
 
 class FlaskTestCase(unittest.TestCase):
-    pass
+
+    def ensure_clean_request_context(self):
+        # make sure we're not leaking a request context since we are
+        # testing flask internally in debug mode in a few cases
+        self.assertEqual(flask._request_ctx_stack.top, None)
+
+    def tearDown(self):
+        unittest.TestCase.tearDown(self)
+        self.ensure_clean_request_context()
 
 
 class ContextTestCase(FlaskTestCase):
@@ -1881,23 +1889,23 @@ class LoggingTestCase(FlaskTestCase):
         @app.route('/exc')
         def exc():
             1/0
-        c = app.test_client()
 
-        with catch_stderr() as err:
+        with app.test_client() as c:
-            c.get('/')
+            with catch_stderr() as err:
-            out = err.getvalue()
+                c.get('/')
-            assert 'WARNING in flask_tests [' in out
+                out = err.getvalue()
-            assert 'flask_tests.py' in out
+                assert 'WARNING in flask_tests [' in out
-            assert 'the standard library is dead' in out
+                assert 'flask_tests.py' in out
-            assert 'this is a debug statement' in out
+                assert 'the standard library is dead' in out
-
+                assert 'this is a debug statement' in out
-        with catch_stderr() as err:
+
-            try:
+            with catch_stderr() as err:
-                c.get('/exc')
+                try:
-            except ZeroDivisionError:
+                    c.get('/exc')
-                pass
+                except ZeroDivisionError:
-            else:
+                    pass
-                assert False, 'debug log ate the exception'
+                else:
+                    assert False, 'debug log ate the exception'
 
     def test_exception_logging(self):
         out = StringIO()