diff --git a/flask/json/tag.py b/flask/json/tag.py index 1e51d6fc..2ff0cc6e 100644 --- a/flask/json/tag.py +++ b/flask/json/tag.py @@ -243,7 +243,7 @@ class TaggedJSONSerializer(object): for cls in self.default_tags: self.register(cls) - def register(self, tag_class, force=False, index=-1): + def register(self, tag_class, force=False, index=None): """Register a new tag with this serializer. :param tag_class: tag class to register. Will be instantiated with this @@ -251,8 +251,8 @@ class TaggedJSONSerializer(object): :param force: overwrite an existing tag. If false (default), a :exc:`KeyError` is raised. :param index: index to insert the new tag in the tag order. Useful when - the new tag is a special case of an existing tag. If -1 (default), - the tag is appended to the end of the order. + the new tag is a special case of an existing tag. If ``None`` + (default), the tag is appended to the end of the order. :raise KeyError: if the tag key is already registered and ``force`` is not true. @@ -266,7 +266,7 @@ class TaggedJSONSerializer(object): self.tags[key] = tag - if index == -1: + if index is None: self.order.append(tag) else: self.order.insert(index, tag) diff --git a/tests/test_json_tag.py b/tests/test_json_tag.py index 6f42539e..da5e6595 100644 --- a/tests/test_json_tag.py +++ b/tests/test_json_tag.py @@ -72,3 +72,19 @@ def test_tag_interface(): pytest.raises(NotImplementedError, t.check, None) pytest.raises(NotImplementedError, t.to_json, None) pytest.raises(NotImplementedError, t.to_python, None) + + +def test_tag_order(): + class Tag1(JSONTag): + key = ' 1' + + class Tag2(JSONTag): + key = ' 2' + + s = TaggedJSONSerializer() + + s.register(Tag1, index=-1) + assert isinstance(s.order[-2], Tag1) + + s.register(Tag2, index=None) + assert isinstance(s.order[-1], Tag2)