diff --git a/cmd/hook.go b/cmd/hook.go index dd5a4f236..8533e3b1d 100644 --- a/cmd/hook.go +++ b/cmd/hook.go @@ -22,6 +22,7 @@ import ( "github.com/gogits/git-module" "github.com/gogits/gogs/models" + "github.com/gogits/gogs/models/errors" "github.com/gogits/gogs/pkg/httplib" "github.com/gogits/gogs/pkg/mailer" "github.com/gogits/gogs/pkg/setting" @@ -94,7 +95,7 @@ func runHookPreReceive(c *cli.Context) error { repoID := com.StrTo(os.Getenv(http.ENV_REPO_ID)).MustInt64() protectBranch, err := models.GetProtectBranchOfRepoByName(repoID, branchName) if err != nil { - if models.IsErrBranchNotExist(err) { + if errors.IsErrBranchNotExist(err) { continue } fail("Internal error", "GetProtectBranchOfRepoByName [repo_id: %d, branch: %s]: %v", repoID, branchName, err) diff --git a/models/error.go b/models/error.go index 08548c7da..410a5a7e9 100644 --- a/models/error.go +++ b/models/error.go @@ -388,26 +388,6 @@ func (err ErrRepoFileAlreadyExist) Error() string { return fmt.Sprintf("repository file already exists [file_name: %s]", err.FileName) } -// __________ .__ -// \______ \____________ ____ ____ | |__ -// | | _/\_ __ \__ \ / \_/ ___\| | \ -// | | \ | | \// __ \| | \ \___| Y \ -// |______ / |__| (____ /___| /\___ >___| / -// \/ \/ \/ \/ \/ - -type ErrBranchNotExist struct { - Name string -} - -func IsErrBranchNotExist(err error) bool { - _, ok := err.(ErrBranchNotExist) - return ok -} - -func (err ErrBranchNotExist) Error() string { - return fmt.Sprintf("branch does not exist [name: %s]", err.Name) -} - // __________ .__ .__ __________ __ // \______ \__ __| | | |\______ \ ____ ________ __ ____ _______/ |_ // | ___/ | \ | | | | _// __ \/ ____/ | \_/ __ \ / ___/\ __\ diff --git a/models/errors/repo.go b/models/errors/repo.go index 69c29be66..c9894af91 100644 --- a/models/errors/repo.go +++ b/models/errors/repo.go @@ -72,3 +72,16 @@ func IsBranchAlreadyExists(err error) bool { func (err BranchAlreadyExists) Error() string { return fmt.Sprintf("branch already exists [name: %s]", err.Name) } + +type ErrBranchNotExist struct { + Name string +} + +func IsErrBranchNotExist(err error) bool { + _, ok := err.(ErrBranchNotExist) + return ok +} + +func (err ErrBranchNotExist) Error() string { + return fmt.Sprintf("branch does not exist [name: %s]", err.Name) +} diff --git a/models/repo_branch.go b/models/repo_branch.go index 10931b0c3..ce06c9f35 100644 --- a/models/repo_branch.go +++ b/models/repo_branch.go @@ -11,6 +11,7 @@ import ( "github.com/Unknwon/com" "github.com/gogits/git-module" + "github.com/gogits/gogs/models/errors" "github.com/gogits/gogs/pkg/tool" ) @@ -45,7 +46,7 @@ func GetBranchesByPath(path string) ([]*Branch, error) { func (repo *Repository) GetBranch(br string) (*Branch, error) { if !git.IsBranchExist(repo.RepoPath(), br) { - return nil, ErrBranchNotExist{br} + return nil, errors.ErrBranchNotExist{br} } return &Branch{ RepoPath: repo.RepoPath(), @@ -101,7 +102,7 @@ func GetProtectBranchOfRepoByName(repoID int64, name string) (*ProtectBranch, er if err != nil { return nil, err } else if !has { - return nil, ErrBranchNotExist{name} + return nil, errors.ErrBranchNotExist{name} } return protectBranch, nil } diff --git a/routes/api/v1/repo/branch.go b/routes/api/v1/repo/branch.go index d8c2697b2..3e0014785 100644 --- a/routes/api/v1/repo/branch.go +++ b/routes/api/v1/repo/branch.go @@ -7,7 +7,7 @@ package repo import ( api "github.com/gogits/go-gogs-client" - "github.com/gogits/gogs/models" + "github.com/gogits/gogs/models/errors" "github.com/gogits/gogs/pkg/context" "github.com/gogits/gogs/routes/api/v1/convert" ) @@ -16,7 +16,7 @@ import ( func GetBranch(c *context.APIContext) { branch, err := c.Repo.Repository.GetBranch(c.Params("*")) if err != nil { - if models.IsErrBranchNotExist(err) { + if errors.IsErrBranchNotExist(err) { c.Error(404, "GetBranch", err) } else { c.Error(500, "GetBranch", err) diff --git a/routes/repo/setting.go b/routes/repo/setting.go index 61c8f3111..ce96cf24b 100644 --- a/routes/repo/setting.go +++ b/routes/repo/setting.go @@ -433,7 +433,7 @@ func SettingsProtectedBranch(c *context.Context) { protectBranch, err := models.GetProtectBranchOfRepoByName(c.Repo.Repository.ID, branch) if err != nil { - if !models.IsErrBranchNotExist(err) { + if !errors.IsErrBranchNotExist(err) { c.Handle(500, "GetProtectBranchOfRepoByName", err) return } @@ -475,7 +475,7 @@ func SettingsProtectedBranchPost(c *context.Context, f form.ProtectBranch) { protectBranch, err := models.GetProtectBranchOfRepoByName(c.Repo.Repository.ID, branch) if err != nil { - if !models.IsErrBranchNotExist(err) { + if !errors.IsErrBranchNotExist(err) { c.Handle(500, "GetProtectBranchOfRepoByName", err) return }