Browse Source

fix #1119 and data race in timming tasks

pull/1694/head
Unknwon 9 years ago
parent
commit
3d14e73fd8
  1. 63
      models/repo.go
  2. 25
      modules/git/tree.go
  3. 3
      routers/user/home.go

63
models/repo.go

@ -17,6 +17,7 @@ import (
"regexp" "regexp"
"sort" "sort"
"strings" "strings"
"sync"
"time" "time"
"unicode/utf8" "unicode/utf8"
@ -1377,20 +1378,54 @@ func RewriteRepositoryUpdateHook() error {
}) })
} }
var ( // statusPool represents a pool of status with true/false.
// Prevent duplicate running tasks. type statusPool struct {
isMirrorUpdating = false lock sync.RWMutex
isGitFscking = false pool map[string]bool
isCheckingRepos = false }
// Start sets value of given name to true in the pool.
func (p *statusPool) Start(name string) {
p.lock.Lock()
defer p.lock.Unlock()
p.pool[name] = true
}
// Stop sets value of given name to false in the pool.
func (p *statusPool) Stop(name string) {
p.lock.Lock()
defer p.lock.Unlock()
p.pool[name] = false
}
// IsRunning checks if value of given name is set to true in the pool.
func (p *statusPool) IsRunning(name string) bool {
p.lock.RLock()
defer p.lock.RUnlock()
return p.pool[name]
}
// Prevent duplicate running tasks.
var taskStatusPool = &statusPool{
pool: make(map[string]bool),
}
const (
_MIRROR_UPDATE = "mirror_update"
_GIT_FSCK = "git_fsck"
_CHECK_REPOs = "check_repos"
) )
// MirrorUpdate checks and updates mirror repositories. // MirrorUpdate checks and updates mirror repositories.
func MirrorUpdate() { func MirrorUpdate() {
if isMirrorUpdating { if taskStatusPool.IsRunning(_MIRROR_UPDATE) {
return return
} }
isMirrorUpdating = true taskStatusPool.Start(_MIRROR_UPDATE)
defer func() { isMirrorUpdating = false }() defer taskStatusPool.Stop(_MIRROR_UPDATE)
log.Trace("Doing: MirrorUpdate") log.Trace("Doing: MirrorUpdate")
@ -1438,11 +1473,11 @@ func MirrorUpdate() {
// GitFsck calls 'git fsck' to check repository health. // GitFsck calls 'git fsck' to check repository health.
func GitFsck() { func GitFsck() {
if isGitFscking { if taskStatusPool.IsRunning(_GIT_FSCK) {
return return
} }
isGitFscking = true taskStatusPool.Start(_GIT_FSCK)
defer func() { isGitFscking = false }() defer taskStatusPool.Stop(_GIT_FSCK)
log.Trace("Doing: GitFsck") log.Trace("Doing: GitFsck")
@ -1507,11 +1542,11 @@ func repoStatsCheck(checker *repoChecker) {
} }
func CheckRepoStats() { func CheckRepoStats() {
if isCheckingRepos { if taskStatusPool.IsRunning(_CHECK_REPOs) {
return return
} }
isCheckingRepos = true taskStatusPool.Start(_CHECK_REPOs)
defer func() { isCheckingRepos = false }() defer taskStatusPool.Stop(_CHECK_REPOs)
log.Trace("Doing: CheckRepoStats") log.Trace("Doing: CheckRepoStats")

25
modules/git/tree.go

@ -28,6 +28,28 @@ type Tree struct {
entriesParsed bool entriesParsed bool
} }
var escapeChar = []byte("\\")
func unescapeChars(in []byte) []byte {
if bytes.Index(in, escapeChar) == -1 {
return in
}
endIdx := len(in) - 1
isEscape := false
out := make([]byte, 0, endIdx+1)
for i := range in {
if in[i] == '\\' && i != endIdx {
isEscape = !isEscape
if isEscape {
continue
}
}
out = append(out, in[i])
}
return out
}
// Parse tree information from the (uncompressed) raw // Parse tree information from the (uncompressed) raw
// data from the tree object. // data from the tree object.
func parseTreeData(tree *Tree, data []byte) ([]*TreeEntry, error) { func parseTreeData(tree *Tree, data []byte) ([]*TreeEntry, error) {
@ -74,8 +96,7 @@ func parseTreeData(tree *Tree, data []byte) ([]*TreeEntry, error) {
// In case entry name is surrounded by double quotes(it happens only in git-shell). // In case entry name is surrounded by double quotes(it happens only in git-shell).
if entry.name[0] == '"' { if entry.name[0] == '"' {
entry.name = string(data[pos+1 : pos+step-1]) entry.name = string(unescapeChars(data[pos+1 : pos+step-1]))
entry.name = strings.Replace(entry.name, `\"`, `"`, -1)
} }
pos += step + 1 pos += step + 1

3
routers/user/home.go

@ -319,6 +319,9 @@ func Profile(ctx *middleware.Context) {
if uname == "favicon.ico" { if uname == "favicon.ico" {
ctx.Redirect(setting.AppSubUrl + "/img/favicon.png") ctx.Redirect(setting.AppSubUrl + "/img/favicon.png")
return return
} else if strings.HasSuffix(uname, ".png") {
ctx.Error(404)
return
} }
isShowKeys := false isShowKeys := false

Loading…
Cancel
Save