From e43479d948b1e3a71dd4488ee1419e45017ff5c1 Mon Sep 17 00:00:00 2001 From: Unknwon Date: Fri, 27 Jan 2017 18:56:32 -0500 Subject: [PATCH] Fix changed branch is not reflected when creating PR (#3604) --- README.md | 2 +- gogs.go | 2 +- modules/context/repo.go | 62 ++++++++++++++++++++--------------------- templates/.VERSION | 2 +- 4 files changed, 34 insertions(+), 34 deletions(-) diff --git a/README.md b/README.md index dcae1f1a0..0f982a27c 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@ Gogs - Go Git Service [![Build Status](https://travis-ci.org/gogits/gogs.svg?bra ![](https://github.com/gogits/gogs/blob/master/public/img/gogs-large-resize.png?raw=true) -##### Current tip version: 0.9.120 (see [Releases](https://github.com/gogits/gogs/releases) for binary versions ~~or submit a task on [alpha stage automated binary building system](https://build.gogs.io/)~~) +##### Current tip version: [`.VERSION`](templates/.VERSION) (see [Releases](https://github.com/gogits/gogs/releases) for binary versions ~~or submit a task on [alpha stage automated binary building system](https://build.gogs.io/)~~) | Web | UI | Preview | |:-------------:|:-------:|:-------:| diff --git a/gogs.go b/gogs.go index 1bc230d19..53bfa8014 100644 --- a/gogs.go +++ b/gogs.go @@ -16,7 +16,7 @@ import ( "github.com/gogits/gogs/modules/setting" ) -const APP_VER = "0.9.120.0127" +const APP_VER = "0.9.121.0127" func init() { setting.AppVer = APP_VER diff --git a/modules/context/repo.go b/modules/context/repo.go index b3d483df3..59891f868 100644 --- a/modules/context/repo.go +++ b/modules/context/repo.go @@ -300,37 +300,6 @@ func RepoAssignment(args ...bool) macaron.Handler { ctx.Data["BranchName"] = ctx.Repo.BranchName ctx.Data["CommitID"] = ctx.Repo.CommitID - if repo.IsFork { - RetrieveBaseRepo(ctx, repo) - if ctx.Written() { - return - } - } - - // People who have push access or have fored repository can propose a new pull request. - if ctx.Repo.IsWriter() || (ctx.IsSigned && ctx.User.HasForkedRepo(ctx.Repo.Repository.ID)) { - // Pull request is allowed if this is a fork repository - // and base repository accepts pull requests. - if repo.BaseRepo != nil { - if repo.BaseRepo.AllowsPulls() { - ctx.Data["BaseRepo"] = repo.BaseRepo - ctx.Repo.PullRequest.BaseRepo = repo.BaseRepo - ctx.Repo.PullRequest.Allowed = true - ctx.Repo.PullRequest.HeadInfo = ctx.Repo.Owner.Name + ":" + ctx.Repo.BranchName - } - } else { - // Or, this is repository accepts pull requests between branches. - if repo.AllowsPulls() { - ctx.Data["BaseRepo"] = repo - ctx.Repo.PullRequest.BaseRepo = repo - ctx.Repo.PullRequest.Allowed = true - ctx.Repo.PullRequest.SameRepo = true - ctx.Repo.PullRequest.HeadInfo = ctx.Repo.BranchName - } - } - } - ctx.Data["PullRequestCtx"] = ctx.Repo.PullRequest - if ctx.Query("go-get") == "1" { ctx.Data["GoGetImport"] = composeGoGetImport(owner.Name, repo.Name) prefix := setting.AppUrl + path.Join(owner.Name, repo.Name, "src", ctx.Repo.BranchName) @@ -443,6 +412,37 @@ func RepoRef() macaron.Handler { ctx.Data["IsViewTag"] = ctx.Repo.IsViewTag ctx.Data["IsViewCommit"] = ctx.Repo.IsViewCommit + if ctx.Repo.Repository.IsFork { + RetrieveBaseRepo(ctx, ctx.Repo.Repository) + if ctx.Written() { + return + } + } + + // People who have push access or have fored repository can propose a new pull request. + if ctx.Repo.IsWriter() || (ctx.IsSigned && ctx.User.HasForkedRepo(ctx.Repo.Repository.ID)) { + // Pull request is allowed if this is a fork repository + // and base repository accepts pull requests. + if ctx.Repo.Repository.BaseRepo != nil { + if ctx.Repo.Repository.BaseRepo.AllowsPulls() { + ctx.Data["BaseRepo"] = ctx.Repo.Repository.BaseRepo + ctx.Repo.PullRequest.BaseRepo = ctx.Repo.Repository.BaseRepo + ctx.Repo.PullRequest.Allowed = true + ctx.Repo.PullRequest.HeadInfo = ctx.Repo.Owner.Name + ":" + ctx.Repo.BranchName + } + } else { + // Or, this is repository accepts pull requests between branches. + if ctx.Repo.Repository.AllowsPulls() { + ctx.Data["BaseRepo"] = ctx.Repo.Repository + ctx.Repo.PullRequest.BaseRepo = ctx.Repo.Repository + ctx.Repo.PullRequest.Allowed = true + ctx.Repo.PullRequest.SameRepo = true + ctx.Repo.PullRequest.HeadInfo = ctx.Repo.BranchName + } + } + } + ctx.Data["PullRequestCtx"] = ctx.Repo.PullRequest + ctx.Repo.CommitsCount, err = ctx.Repo.Commit.CommitsCount() if err != nil { ctx.Handle(500, "CommitsCount", err) diff --git a/templates/.VERSION b/templates/.VERSION index 67aeeccbd..4e2b2896d 100644 --- a/templates/.VERSION +++ b/templates/.VERSION @@ -1 +1 @@ -0.9.120.0127 \ No newline at end of file +0.9.121.0127 \ No newline at end of file