Some cleanup.

Clocker/Menu Bar/StatusItemHandler.swift

@@ -35,6 +35,9 @@ class StatusItemHandler: NSObject {
     // TODO: Make sure it's set just once.
     private var currentState: MenubarState = .standardText {
         didSet {
+            if oldValue == currentState {
+                assert(oldValue == currentState, "We have the same status bar state")
+            }
             // Do some cleanup
             switch oldValue {
             case .compactText:

Clocker/Preferences/General/SearchDataSource.swift

@@ -34,7 +34,7 @@ class SearchDataSource: NSObject {
         super.init()
         self.searchField = searchField
         setupTimezoneDatasource()
-        _ = calculateChangesets()
+        calculateChangesets()
     }
 
     func cleanupFilterArray() {
@@ -78,7 +78,7 @@ class SearchDataSource: NSObject {
         }
     }
 
-    func calculateChangesets() -> Bool {
+    @discardableResult func calculateChangesets() -> Bool {
         var changesets: [RowType] = []
 
         func addTimezonesIfNeeded(_ data: [TimezoneMetadata]) {