make next_arg() more readable & efficient

src/drv_imap.c

@@ -458,33 +458,37 @@ imap_refcounted_done_box( imap_store_t *ctx ATTR_UNUSED, struct imap_cmd *cmd, i
 }
 
 static char *
-next_arg( char **s )
+next_arg( char **ps )
 {
-	char *ret;
+	char *ret, *s;
 
-	if (!s || !*s)
+	assert( ps );
+	s = *ps;
+	if (!s)
 		return 0;
-	while (isspace( (unsigned char) **s ))
+	while (isspace( (unsigned char)*s ))
-		(*s)++;
+		s++;
-	if (!**s) {
+	if (!*s) {
-		*s = 0;
+		*ps = 0;
 		return 0;
 	}
-	if (**s == '"') {
+	if (*s == '"') {
-		++*s;
+		++s;
-		ret = *s;
+		ret = s;
-		*s = strchr( *s, '"' );
+		s = strchr( s, '"' );
 	} else {
-		ret = *s;
+		ret = s;
-		while (**s && !isspace( (unsigned char) **s ))
+		while (*s && !isspace( (unsigned char)*s ))
-			(*s)++;
+			s++;
 	}
-	if (*s) {
+	if (s) {
-		if (**s)
+		if (*s)
-			*(*s)++ = 0;
+			*s++ = 0;
-		if (!**s)
+		if (!*s)
-			*s = 0;
+			s = 0;
 	}
+
+	*ps = s;
 	return ret;
 }