mbsync

Commit Graph

Author	SHA1	Message	Date
Oswald Buddenhagen	a85013d6ff	make IMAP pipeline depth configurable currently, this affects only "clustered" message listings and flag stores.	12 years ago
Oswald Buddenhagen	a266f28f1c	cancel submitted commands when canceling store we already have some minimal asynchronicity, so there might be commands in flight when a fatal error comes in.	12 years ago
Oswald Buddenhagen	171f7d6cd3	Socket_t + buffer_t => conn_t remove the layering, in favor of a "buffered connection" abstraction.	12 years ago
Oswald Buddenhagen	ef41349035	move socket code to a separate file this makes the layering more obvious	12 years ago
Oswald Buddenhagen	d1ee94f02c	move greeting response handling into get_cmd_result() the primary purpose of this is getting rid of the "free-standing" buffer_gets() call.	12 years ago
Oswald Buddenhagen	584e51ed7d	docs - insert "separator comments" between driver entry points - document driver API - document sync_vars_t parts that are stored in the sync state header	12 years ago
Oswald Buddenhagen	2ab689b3df	make imap_exec() result reporting callback-based this makes the IMAP command submission interface asynchronous. the functions still have synchronous return codes as well - this enables clean error return paths. only when we invoke callbacks we resort to refcounting. as a "side effect", properly sequence commands after CREATE resulting from [TRYCREATE].	12 years ago
Oswald Buddenhagen	05fd0b9970	split out drv->load() from drv->select()	12 years ago
Oswald Buddenhagen	7addc3bea8	minor cleanup: use ctx->gen instead of gctx for consistency	12 years ago
Oswald Buddenhagen	ea951a697f	fix error paths wrt sync drivers, take 2 synchronous error codes which are passed through callbacks aren't a particularly good idea, after all: latest when the callback does stuff which does not concern the caller, the return code becomes ambiguous. instead, protect the sync_vars object with a refcount when invoking driver functions from loops, as the callbacks they call could invalidate the object and we would have no way of knowing that the loop should be aborted prematurely. the upcoming async imap driver will also need a refcount to protect the cancelation marker of the imap socket dispatcher loop.	12 years ago
Oswald Buddenhagen	b0bbd23512	replace DRV_STORE_BAD with a separate bad_callback() that way we don't have to piggy-back (possibly asynchronous) fatal errors to particular commands. internally, the drivers still use synchronous return values as well, so they don't try to access the invalidated store after calling back.	12 years ago
Oswald Buddenhagen	9554026443	make drv->cancel()'s callback have no status code this function is not going to actually execute any commands, so it makes no sense for the callback to have a status code.	12 years ago
Oswald Buddenhagen	06ccac1fdd	always use return value from get_cmd_result() once we have callback-based error reporting, this will ensure that we don't operate on invalidated data structures.	12 years ago
Oswald Buddenhagen	121ce76e46	make response code parse failure of untagged OK/NO/BYE/BAD non-fatal as such, it does not disrupt the data stream	12 years ago
Oswald Buddenhagen	4d4de6e275	remove redundant use_ssl variables just use the presence of an SSL object as an indicator. if something goes wrong during the ssl handshake or certificate validation, the socket must be immediately closed anyway.	13 years ago
Oswald Buddenhagen	17dc64b414	after [TRYCREATE], just resend the same command instead of cloning it	13 years ago
Oswald Buddenhagen	83efbe327d	use return values from correct set in get_cmd_result() DRV_OK == RESP_OK, so this worked by accident	13 years ago
Oswald Buddenhagen	99cc328f17	do away with the dreaded rcaps hack don't pretend that the server has no literal+ for the time of the first relevant command's synchronous execution. instead, enable the lower layer to do the processing by telling it for which commands trashnc ("trash's existence not confirmed") is relevant.	13 years ago
Oswald Buddenhagen	1545ed90a0	purge imap_store_t::currentnc vestiges we always actually open the mailbox before appending to it, so we obviously know that it exists - that's why the code was already commented out. changing this assumption would significantly complicate matters for little gain, so let's just assume it won't happen. consequently, also don't set param.create when appending to regular mailboxes.	13 years ago
Oswald Buddenhagen	c66afdc0a8	move setting of ctx->listed outside the drivers it's essentially an external state flag	13 years ago
Oswald Buddenhagen	61d98c5a1d	fix a bunch of warnings	13 years ago
Oswald Buddenhagen	4afd31a457	avoid preprocessor warnings on missing features: #if => #ifdef	14 years ago
Oswald Buddenhagen	cf6a7b4d18	less bizarre code we know that there is only one command in progress, so there is no need to employ tricks to access the last command.	14 years ago
Oswald Buddenhagen	7e1c16ae02	make cram() sane - don't silently fail in release mode (expression with side effects inside assert()) - save some redundand strlen()s by not throwing away known lengths - reorganize the code for legibility	14 years ago
Oswald Buddenhagen	2c729bf9e6	don't leak SSL objects	14 years ago
Oswald Buddenhagen	d637772339	turns out, free(NULL) is just fine ...	14 years ago
Oswald Buddenhagen	e1fa867423	fix UIDNEXT handling UIDNEXT can be legally zero, so deal with it. -REFMAIL: 4CA62BA1.4020104@lemma.co.uk	14 years ago
Oswald Buddenhagen	5ade279839	don't hang after failed start_tls() we'd send a LOGOUT command in plain text while the server was already expecting an encrypted command, which would typically lead to waiting for more data and thus an indefinite hang. so close the socket immediately instead of letting the normal shutdown path take care of it. inspired by a patch by Steven Flintham. -REFMAIL: 4C9AB98E.3000400@lemma.co.uk	14 years ago
Oswald Buddenhagen	70e87eb99e	remove useless message don't complain about missing greeting response - we already complained about an unexpected EOF anyway.	14 years ago
Oswald Buddenhagen	90a38ea810	assert valid file handles i've seen error logs of the type SSL_write: Bad file descriptor and i simply can't nail it, so go for some more drastic measures.	14 years ago
Oswald Buddenhagen	72fd2aafb7	formatting	14 years ago
Oswald Buddenhagen	122e09fe60	beautify error messages don't print the error number - we print the error string anyway, so it adds no value. add some whitespace to the messages as well.	14 years ago
Oswald Buddenhagen	db2bbbfef8	fix uninitialized variable read this is basically a security fix for nonsensical configurations: if the specified CertificateFile did not contain any certificates, we might have accepted an arbitrary server certificate.	15 years ago
Oswald Buddenhagen	da39690aec	fix compile with SSL on Mac OS X patch by Remko Tronçon <remko@el-tramo.be> BUG: 2126899	15 years ago
Oswald Buddenhagen	e6a356ffc7	add extra verbose mode which dumps the message contents i needed that to debug the line ending issues. maybe it will find other uses as well ...	15 years ago
Oswald Buddenhagen	ce45692ca5	refactoring. main part is killing struct imap_cmd_cb as such. issue_imap_cmd is split into new_imap_cmd and submit_imap_cmd, so the command can be parametrized after it was instanciated.	16 years ago
Oswald Buddenhagen	92914b37cc	deal with UIDVALIDITY of 0 properly. -REF: 20080822094543.GA3528@ugly.local	16 years ago
Oswald Buddenhagen	0d8bce1675	give the implicitly created imap account config the name of the store.	17 years ago
Oswald Buddenhagen	262999d092	make ssl certificate handling much more useful: - system-wide ca certs are auto-loaded - private certs are accepted even if they are self-signed	17 years ago
Oswald Buddenhagen	06521da30d	- accept unset CertificateFile - print the certificate's fingerprint - make the certificate acceptance prompt much less scary	17 years ago
Oswald Buddenhagen	89519e343c	ignore system flag extensions (\X-...)	17 years ago
Oswald Buddenhagen	2b37288e8d	don't use #ifdef inside htons() arguments - it can be a macro. -REF: <lyy7ezyjah.fsf@gfn.org> CCMAIL: Scott Gifford <sgifford@suspectclass.com>	17 years ago
Oswald Buddenhagen	625f592fb7	fix crash due to uninited var when parsing IMAPServer. Thanks to CCMAIL: Antoine Reilles <tonio@NetBSD.org> REF: <20070118182534.GA22288@arcelot.loria.fr>	18 years ago
Oswald Buddenhagen	023d3ee577	fix error paths wrt sync drivers	18 years ago
Oswald Buddenhagen	617d1a6e49	memmove for overlapping mem copies.	19 years ago
Oswald Buddenhagen	4bf58c3e97	don't crash in imap driver when Host is not specified.	19 years ago
Oswald Buddenhagen	dbbab78881	un-document "Host imaps:[...]" syntax and introduce new option UseIMAPS instead. apply ted's patch to support UseIMAPS in conjunction with Tunnel. document that SSLv2 is No Good (TM).	19 years ago
Oswald Buddenhagen	67b714ee0e	move assigning default port to the place of use	19 years ago
Oswald Buddenhagen	168e5f3282	make the driver model, sync_chans() and sync_boxes() fully async. async drivers to follow ...	19 years ago
Oswald Buddenhagen	b7389cb36f	do not repeatedly get namespace from server.	19 years ago

1 2 3

124 Commits (12be7dd1f31d9b48c666a6c3431cc529f331093b)