mbsync

Commit Graph

Author	SHA1	Message	Date
Oswald Buddenhagen	48754ecc74	make sync state header format less obscure the header is not space-critical, so use proper name-value pairs. this has the additional advantage that subsequent format changes can be done much easier.	11 years ago
Oswald Buddenhagen	3dcb393de2	set srec->msg[] when finding messages by tuid otherwise we would propagate phantom deletions. this affected only sync runs after an interruption while storing messages, so it went (mostly?) unnoticed.	11 years ago
Oswald Buddenhagen	3814f19661	remove pointless assignment we already know that tmsg->srec is null at this point.	11 years ago
Oswald Buddenhagen	e63e16ab45	assert no stray TUIDs	11 years ago
Oswald Buddenhagen	32def5dc0a	add/fix comments and improve debug messages	11 years ago
Oswald Buddenhagen	a9a331c98a	simplify condition ... and document the cases.	11 years ago
Oswald Buddenhagen	03f8bfdfb2	micro-optimization/-clarification	11 years ago
Oswald Buddenhagen	00076a6971	move initializations for clarity	11 years ago
Oswald Buddenhagen	61ef099cd5	MaxMessages: make condition exactly symmetrical to condition below	11 years ago
Oswald Buddenhagen	080740f867	rewrite condition for readability and consistency	11 years ago
Oswald Buddenhagen	b10fd0c21c	remove assumption about value of M constant	11 years ago
Oswald Buddenhagen	a893cba483	fix enum abuse amends `9c86ec344`. S_FIND was for the sync record status field. it has no business in the sync vars status fields. its value coincided with ST_SELECTED, which luckily only means that we always tried to match up TUIDs even if there was nothing to do. the need for TUID matching arises in two mostly independent circumstances, so add two separate flags ST_FIND_{OLD,NEW}.	11 years ago
Oswald Buddenhagen	0b59ee0df3	support multi-character path separators this applies to both the IMAP PathDelimiter (which is needed by Lotus Domino), as well as the Flatten-ed separators.	12 years ago
Oswald Buddenhagen	eb1f10762f	added sync support for the arrival date of messages initial patch by Marc Hoersken <info@marc-hoersken.de>	12 years ago
Oswald Buddenhagen	6577bf3e61	warn if we cannot find some messages by TUID	12 years ago
Oswald Buddenhagen	1847a4e12d	make better use of ATTR_UNUSED	12 years ago
Oswald Buddenhagen	5ad83b4e6a	don't unnecessarily use continue	12 years ago
Oswald Buddenhagen	e4243debb6	use INT_MAX instead of zero for "no size limit" this simplifies the actual conditions	12 years ago
Oswald Buddenhagen	ca3a319e60	update copyrights	12 years ago
Oswald Buddenhagen	9261897629	don't record newuid in the sync state this value is only ever used to find just pushed messages by TUID, so we can simply use the UIDNEXT value from before we started pushing - and of course, we need to record that in the journal. it makes no sense to log the new value after completing a search, as there won't be a next search before we push the next messages.	12 years ago
Oswald Buddenhagen	96be183acb	rename sync_vars_t::uidnext => newuid & fix comment the purpose of this variable is to hold the UIDNEXT value from before we started pushing new messages, i.e., the minimal uid we can expect them to have.	12 years ago
Oswald Buddenhagen	d7eae525bd	fix TrashRemoteNew copy direction	12 years ago
Oswald Buddenhagen	35851f133b	add option to control amount of fsync()ing	12 years ago
Oswald Buddenhagen	49223b2df2	avoid that a system crash can cause messages to be propagated twice fdatasync() the journal after creating the pair record and recording the TUID, but before the message propagation actually starts. all other writes to the journal are not flushed, as they will at worst cause some unnecessary network traffic without visible effect.	12 years ago
Oswald Buddenhagen	df6c3b64b7	avoid that a system crash can clobber the sync state file make sure that the new state is committed to disk before overwriting the old version - by default meta data is committed first, so we may end up with no valid state at all otherwise.	12 years ago
Oswald Buddenhagen	f11504aa07	update copyrights make the wrapper's help string also mention copyrights pertaining only to the actual syncer, as this is the only string many people will ever see.	13 years ago
Oswald Buddenhagen	d4c786823d	replace FSF address with something more ... contemporary	13 years ago
Oswald Buddenhagen	6d49c343fc	use a hash table for message => sync record lookup this removes the pathological O(<number of sync records> * <number of new messages>) case at the cost of being a bit more cpu-intensive (but O(<number of all messages>)) for old messages.	13 years ago
Oswald Buddenhagen	dfd7516b9a	introduce ability to flatten the hierarchy of Stores	13 years ago
Oswald Buddenhagen	343f16771a	don't crash when select() on master fails synchronously svars->drv[S] would not be initialized yet, so cancel_sync() would crash.	13 years ago
Oswald Buddenhagen	28cccf4b35	fix error handling of invalid SyncState * when we find that the store is incompatible with in-store sync state, we want to fail the whole channel. however, we must not claim that the store died, otherwise it won't be disposed of properly.	13 years ago
Oswald Buddenhagen	9c86ec3442	employ alternative scheme to finding messages by TUID instead of SEARCHing every single message (which is slow and happens to be unreliabe with M$ Exchange 2010), just FETCH the new messages from the mailbox - the ones we just appended will be amongst them.	13 years ago
Oswald Buddenhagen	b4cef554fc	clearer debug msg	13 years ago
Oswald Buddenhagen	7c815538ab	fix line wrapping before info messages unless an info message is explictly marked as a continuation, it must terminate any pending line (typically the progress information) first. debug output is not affected, as it is mutually exclusive with info output, and no debug lines are left unterminated outside clear scopes.	13 years ago
Oswald Buddenhagen	6b3b6f12bb	centralize flushing of unfinished debug lines	13 years ago
Oswald Buddenhagen	d2bed4990d	unify error reporting - introduce sys_error() and use it instead of perror() and error(strerror()) in all expected error conditions - perror() is used only for "something's really wrong with the system" kind of errors - file names, etc. are quoted if they are not validated yet, so e.g. an empty string becomes immediately obvious - improve and unify language - add missing newlines	13 years ago
Oswald Buddenhagen	584e51ed7d	docs - insert "separator comments" between driver entry points - document driver API - document sync_vars_t parts that are stored in the sync state header	13 years ago
Oswald Buddenhagen	e5d323cc47	rely on the maildir's existence with "SyncState *" now that we open the box first, we know that it will exist at this point.	13 years ago
Oswald Buddenhagen	05fd0b9970	split out drv->load() from drv->select()	13 years ago
Oswald Buddenhagen	424e0e7221	make callbacks return early when canceling even after driver->cancel() the store may complete commands successfully. return early in this case, so we don't attempt to continue syncing.	13 years ago
Oswald Buddenhagen	ea951a697f	fix error paths wrt sync drivers, take 2 synchronous error codes which are passed through callbacks aren't a particularly good idea, after all: latest when the callback does stuff which does not concern the caller, the return code becomes ambiguous. instead, protect the sync_vars object with a refcount when invoking driver functions from loops, as the callbacks they call could invalidate the object and we would have no way of knowing that the loop should be aborted prematurely. the upcoming async imap driver will also need a refcount to protect the cancelation marker of the imap socket dispatcher loop.	13 years ago
Oswald Buddenhagen	ec8f440383	don't call cancel() repeatedly on a store erroring command replies will trickle in even after canceling	13 years ago
Oswald Buddenhagen	b0bbd23512	replace DRV_STORE_BAD with a separate bad_callback() that way we don't have to piggy-back (possibly asynchronous) fatal errors to particular commands. internally, the drivers still use synchronous return values as well, so they don't try to access the invalidated store after calling back.	13 years ago
Oswald Buddenhagen	6d86e5347e	don't access free'd memory in cancel_sync() as it happens, the 1st round may trash svars - if we get the cancelation request after the slave store has already died.	13 years ago
Oswald Buddenhagen	9554026443	make drv->cancel()'s callback have no status code this function is not going to actually execute any commands, so it makes no sense for the callback to have a status code.	13 years ago
Oswald Buddenhagen	57444e9df9	don't decode aux pointer on DRV_CANCELED the aux data was already free()d by the error callback by the time we get this status code.	13 years ago
Oswald Buddenhagen	7bab2d6d94	de-duplicate error paths makes the code more compact. yay for gotos.	13 years ago
Oswald Buddenhagen	61d98c5a1d	fix a bunch of warnings	13 years ago
Oswald Buddenhagen	058d01f179	don't compare find_old_done with find_new_total this didn't have any effect as no async drivers currently exist.	14 years ago
Oswald Buddenhagen	296ac0364c	add CR after TUID during LF => CRLF conversion	14 years ago

1 2 3 4 5

216 Commits (85688d1c1a6053041e49b959350ed585f8209b4a)