mbsync

Commit Graph

Author	SHA1	Message	Date
Oswald Buddenhagen	a3bd10c04d	cleanup maildir error paths don't try to unlock and close databases and files - this will happen a moment later anyway, through cancelation or re-selection. ironically, this plugs a memory leak, because an open main database is used as a signal to close a temporary db in maildir_scan().	12 years ago
Oswald Buddenhagen	04ca97920d	fix potential double free the store may be discarded before we reach maildir_select() again, which will leave us with a dangling pointer.	12 years ago
Oswald Buddenhagen	e71ad53b7f	plug memory leak in maildir_store_msg() upon failure to acquire UID	12 years ago
Oswald Buddenhagen	9c86ec3442	employ alternative scheme to finding messages by TUID instead of SEARCHing every single message (which is slow and happens to be unreliabe with M$ Exchange 2010), just FETCH the new messages from the mailbox - the ones we just appended will be amongst them.	12 years ago
Oswald Buddenhagen	b4cef554fc	clearer debug msg	12 years ago
Oswald Buddenhagen	06b303da88	use ATTR_PRINTFALIKE	12 years ago
Oswald Buddenhagen	7c815538ab	fix line wrapping before info messages unless an info message is explictly marked as a continuation, it must terminate any pending line (typically the progress information) first. debug output is not affected, as it is mutually exclusive with info output, and no debug lines are left unterminated outside clear scopes.	12 years ago
Oswald Buddenhagen	2aae866e80	remove Ontty flag i can't figure out why i added it in the first place. it doesn't seem to make any sense ...	12 years ago
Oswald Buddenhagen	6b3b6f12bb	centralize flushing of unfinished debug lines	12 years ago
Oswald Buddenhagen	d2bed4990d	unify error reporting - introduce sys_error() and use it instead of perror() and error(strerror()) in all expected error conditions - perror() is used only for "something's really wrong with the system" kind of errors - file names, etc. are quoted if they are not validated yet, so e.g. an empty string becomes immediately obvious - improve and unify language - add missing newlines	12 years ago
Oswald Buddenhagen	dee9f51096	don't complain about disappearing temp files some other process might be cleaning up concurrently ...	12 years ago
Oswald Buddenhagen	ae85e455d3	enlarge receive buffer considerably the tiny buffer makes no sense in the face of huge payloads and now additionally masses of replies from pipelined commands.	12 years ago
Oswald Buddenhagen	256a147945	compile with -ansi -pedantic on gcc greatly helps portability ...	12 years ago
Oswald Buddenhagen	96eaeb428d	define _GNU_SOURCE on the command line that way it is already set in configure and can thus be used by tests.	12 years ago
Oswald Buddenhagen	faeb9b5bf7	centralize imap_cmd_refcounted_state refcount decrementing no else branches remain, so the if() can be put into imap_refcounted_done()	12 years ago
Oswald Buddenhagen	f5086f735c	get rid of redundant literal_pending state flag	12 years ago
Oswald Buddenhagen	bd93d689db	fully asynchronous IMAP operation - asynchronous sockets using an event loop - connect & starttls have completion callback parameters - callbacks for notification about filled input buffer and emptied output buffer - unsent imap command queue - used when - socket output buffer is non-empty - number of commands in flight exceeds limit - last sent command requires round-trip - command has a dependency on completion of previous command - trashnc is tri-state so only a single "scout" trash APPEND/COPY is sent at first. a possibly resulting CREATE is injected in front of the remaining trash commands, so they can succeed (or be cancel()d if it fails). - queue's presence necessitates imap_cancel implementation	12 years ago
Oswald Buddenhagen	7867eb9009	add simple mainloop implementation not used so far	12 years ago
Oswald Buddenhagen	a55354516b	move responsibility for closing sockets on error to user the only user being imap and the first thing in imap_cancel_store() being a call to socket_close(), this code was pretty pointless anyway.	12 years ago
Oswald Buddenhagen	802c99edcf	make socket read/write error reporting callback-based the functions still have synchronous return codes as well - this enables early error returns without having to resort to refcounting.	12 years ago
Oswald Buddenhagen	f1df2f40d1	decouple the filling of the read buffer from consuming it this prepares the code for being called from a callback. notably, this makes the imap list parser have a "soft stack", so the recursion can be suspended at any time.	12 years ago
Oswald Buddenhagen	886cd03e37	centralize imap_cmd disposal	12 years ago
Oswald Buddenhagen	f8d73ac346	make socket_write() capable of taking ownership of the buffer that way the user code doesn't have to free it any more.	12 years ago
Oswald Buddenhagen	8a72d204c9	change socket_write() return code semantics instead of returning a write()-like result, return only a binary status code - write errors are handled internally anyway, so user code doesn't have to check the write length.	12 years ago
Oswald Buddenhagen	a85013d6ff	make IMAP pipeline depth configurable currently, this affects only "clustered" message listings and flag stores.	12 years ago
Oswald Buddenhagen	a266f28f1c	cancel submitted commands when canceling store we already have some minimal asynchronicity, so there might be commands in flight when a fatal error comes in.	12 years ago
Oswald Buddenhagen	171f7d6cd3	Socket_t + buffer_t => conn_t remove the layering, in favor of a "buffered connection" abstraction.	12 years ago
Oswald Buddenhagen	3447694c2b	security fix: failure to load the certificate file is not OK ...	12 years ago
Oswald Buddenhagen	ef41349035	move socket code to a separate file this makes the layering more obvious	12 years ago
Oswald Buddenhagen	d1ee94f02c	move greeting response handling into get_cmd_result() the primary purpose of this is getting rid of the "free-standing" buffer_gets() call.	12 years ago
Oswald Buddenhagen	584e51ed7d	docs - insert "separator comments" between driver entry points - document driver API - document sync_vars_t parts that are stored in the sync state header	12 years ago
Oswald Buddenhagen	2ab689b3df	make imap_exec() result reporting callback-based this makes the IMAP command submission interface asynchronous. the functions still have synchronous return codes as well - this enables clean error return paths. only when we invoke callbacks we resort to refcounting. as a "side effect", properly sequence commands after CREATE resulting from [TRYCREATE].	12 years ago
Oswald Buddenhagen	e5d323cc47	rely on the maildir's existence with "SyncState *" now that we open the box first, we know that it will exist at this point.	12 years ago
Oswald Buddenhagen	3169c59e10	validate maildirs more strictly now that "SyncState *" won't create fake mailboxes any more, we can make a full validity check again.	12 years ago
Oswald Buddenhagen	05fd0b9970	split out drv->load() from drv->select()	12 years ago
Oswald Buddenhagen	c741d5ffb5	make creation of trash folder independent from -C option the trash is not a box which is synced, but a "byproduct" of manipulating synced boxes, so it makes no sense to bind it to the same option.	12 years ago
Oswald Buddenhagen	7addc3bea8	minor cleanup: use ctx->gen instead of gctx for consistency	12 years ago
Oswald Buddenhagen	424e0e7221	make callbacks return early when canceling even after driver->cancel() the store may complete commands successfully. return early in this case, so we don't attempt to continue syncing.	12 years ago
Oswald Buddenhagen	ea951a697f	fix error paths wrt sync drivers, take 2 synchronous error codes which are passed through callbacks aren't a particularly good idea, after all: latest when the callback does stuff which does not concern the caller, the return code becomes ambiguous. instead, protect the sync_vars object with a refcount when invoking driver functions from loops, as the callbacks they call could invalidate the object and we would have no way of knowing that the loop should be aborted prematurely. the upcoming async imap driver will also need a refcount to protect the cancelation marker of the imap socket dispatcher loop.	12 years ago
Oswald Buddenhagen	ec8f440383	don't call cancel() repeatedly on a store erroring command replies will trickle in even after canceling	12 years ago
Oswald Buddenhagen	b0bbd23512	replace DRV_STORE_BAD with a separate bad_callback() that way we don't have to piggy-back (possibly asynchronous) fatal errors to particular commands. internally, the drivers still use synchronous return values as well, so they don't try to access the invalidated store after calling back.	12 years ago
Oswald Buddenhagen	6d86e5347e	don't access free'd memory in cancel_sync() as it happens, the 1st round may trash svars - if we get the cancelation request after the slave store has already died.	12 years ago
Oswald Buddenhagen	9554026443	make drv->cancel()'s callback have no status code this function is not going to actually execute any commands, so it makes no sense for the callback to have a status code.	12 years ago
Oswald Buddenhagen	57444e9df9	don't decode aux pointer on DRV_CANCELED the aux data was already free()d by the error callback by the time we get this status code.	12 years ago
Oswald Buddenhagen	06ccac1fdd	always use return value from get_cmd_result() once we have callback-based error reporting, this will ensure that we don't operate on invalidated data structures.	12 years ago
Oswald Buddenhagen	121ce76e46	make response code parse failure of untagged OK/NO/BYE/BAD non-fatal as such, it does not disrupt the data stream	12 years ago
Oswald Buddenhagen	d2e13f147c	de-duplicate code a bit	12 years ago
Oswald Buddenhagen	4d4de6e275	remove redundant use_ssl variables just use the presence of an SSL object as an indicator. if something goes wrong during the ssl handshake or certificate validation, the socket must be immediately closed anyway.	13 years ago
Oswald Buddenhagen	fd229040d8	DRV_SERVER_BAD is and will probably stay unused => trash	13 years ago
Oswald Buddenhagen	17dc64b414	after [TRYCREATE], just resend the same command instead of cloning it	13 years ago

... 2 3 4 5 6 ...

575 Commits (92b892d24757b117c8ee73741f263b46f4472a85) All Branches Search

575 Commits (92b892d24757b117c8ee73741f263b46f4472a85)

All Branches