mbsync

Commit Graph

Author	SHA1	Message	Date
Oswald Buddenhagen	503478533c	de-duplicate FETCH response data item traversal somewhat	4 years ago
Oswald Buddenhagen	8acf56b311	complain about malformed item names in FETCH responses	4 years ago
Oswald Buddenhagen	47b477b3fb	re-nest parse_fetch_rsp() prefer early exits over else branches, which is easier to follow.	4 years ago
Oswald Buddenhagen	81c4bfeefa	extract parse_fetched_flags() from parse_fetch_rsp()	4 years ago
Oswald Buddenhagen	d4ead05a02	extract parse_fetched_header() from parse_fetch_rsp()	4 years ago
Oswald Buddenhagen	67ea5bea7f	handle bogus IMAP FETCH responses more robustly don't use assert()s when the error condition can stem not only from errors in mbsync's logic, but also from the IMAP stream being corrupted. amends `72be55b0e`. REFMAIL: 20191021233411.55ctuvslkfqf2pna@koblih.localdomain	4 years ago
Oswald Buddenhagen	a5a8783ea3	sanitize error handling in IMAP FETCH response processing abort on actual error conditions (protocol errors) and downgrade the rest to warnings. REFMAIL: 20191102164509.dxayakg3hrmozjnm@carbon	4 years ago
Oswald Buddenhagen	b91dd5b3bc	centralize disposal of parsed IMAP lists makes the code less cluttered, and it's harder to introduce leaks. this has the hypothetical disadvantage that due to freeing being delayed, the peak memory usage would rise significantly if we chained to another parse_list() call which produces a big list while already holding a big list, but that isn't the case anywhere.	4 years ago
Oswald Buddenhagen	7af7354dbc	fully decompose NAMESPACE response early on that way the code becomes clearer, and we don't keep useless nodes in memory.	4 years ago
Oswald Buddenhagen	6fd4e8de24	don't store 'shared' and 'other' namespaces they are never used anyway, and aren't going to be (because configuring that would be more annoying than just specifying Path manually).	4 years ago
Oswald Buddenhagen	c391b06b07	drop redundant conn->writing member this information is already encoded in the socket notifier's config.	4 years ago
Oswald Buddenhagen	6010fe104e	rewrite nonsensical struct packing magic this couldn't have possibly worked - the alignment also determines the sizeof, thus defeating the intent of the packing.	4 years ago
Oswald Buddenhagen	64e5f07ad3	consistently use NULL for null pointers makes the code noisier, but also somewhat more expressive.	4 years ago
Oswald Buddenhagen	e2d3b4d55b	fix lots of sign conversion warnings ... by making a lot of objects unsigned, and some signed. casts which lose precision and change the sign in one go (ssize_t and time_t to uint on LP64) are made explicit as well.	4 years ago
Oswald Buddenhagen	cc176df2c3	make some narrowing of integers explicit this does specifically not cover about a bazillion warnings about size_t being shrunk to uint - these make no sense given the expected data set size.	4 years ago
Oswald Buddenhagen	4d7e169e57	shrink some data at the source to avoid subsequent narrowing	4 years ago
Oswald Buddenhagen	def22db096	constness fixes add missing const qualifications, and add "const cast" suppressions where unavoidable.	4 years ago
Oswald Buddenhagen	5c2e8d3e14	make more objects static	4 years ago
Oswald Buddenhagen	71d7d3e6df	add some ATTR_* (mostly) mostly ATTR_PRINTFLIKE(*, 0) for functions with a va_list argument. also, one ATTR_NORETURN and one ATTR_UNUSED, both on functions. also, an explicit suppression for a format string stored in a variable.	4 years ago
Oswald Buddenhagen	df22514ced	turn maildir_again() into a proper varargs function this is mostly to work around the fact that both gcc and clang won't accept the format string declaration (i.e., will complain with -Wformat-nonliteral) if the called function does not actually take a va_list. on the upside, it makes one caller cleaner. yay ...	4 years ago
Oswald Buddenhagen	234becf530	remove support for SSLv3 it's insecure and default builds of openssl don't include it any more.	4 years ago
Oswald Buddenhagen	d09f988c70	add support for (disabling) TLS v1.3 this is actually potentially counterproductive, as people who have set SSLVersions and fail to adjust it will _lose_ tls 1.3 support. however, without the option being there, people (incorrectly) believe that tls 1.3 is not supported.	4 years ago
Oswald Buddenhagen	990cc112f1	Add option to use IMAP LSUB instead of LIST Based on patch by Cedric Ware <cedric.ware__bml@normalesup.org>	4 years ago
Oswald Buddenhagen	e9407cc1f7	IMAP: reject unqualified non-uppercased INBOX spellings otherwise the server would interpret it as INBOX contrary to our expectations, which might lead to moderately surprising effects. if you really want to sync your ~/maildir/inbox to the IMAP INBOX, specify it as the Maildir Store's Inbox.	4 years ago
Jaroslav Suchanek	07cb422cbb	Add support for specifying cipher string used for ssl connection Some distributions (e.g. Fedora) added support for system wide crypto policies. This is supported in most common crypto libraries including OpenSSL. Applications can override this policy using their own cipher string. This commit adds support for specifying the cipher string in the mbsync configuration. For example, to exclude Diffie-Hellman, the user can specify CipherString "DEFAULT:!DH" in the IMAP Account's configuration.	4 years ago
Oswald Buddenhagen	25b1c2b9e7	set sync record's flags only after propagating new message this is semantically cleaner, and fixes storing the flags in the rare case that flags are not being synced and the target is not being expunged, as in this case flags are queried only during the actual propagation.	4 years ago
Oswald Buddenhagen	abdca388f6	atomize & document conditions in load() exception list construction	4 years ago
Oswald Buddenhagen	b677bfe7e5	de-noise msg_copied() and flags_set() somewhat assign temporary srec object instead of always spelling out the indirection.	4 years ago
Oswald Buddenhagen	841f07efd0	de-noise initialization of sync records use calloc() instead of malloc().	4 years ago
Oswald Buddenhagen	e7bc402d09	rename socket_expect_read() => socket_expect_activity() ... to better reflect its (mostly new) function.	4 years ago
Oswald Buddenhagen	8a03651dd8	re-nest conditions in socket_fd_cb() conn->state == SCK_STARTTLS implies conn->ssl != NULL.	4 years ago
Oswald Buddenhagen	2117945838	move state assignment to a more natural place ... so it's right next to the related callback assignment.	4 years ago
Oswald Buddenhagen	c5d3565db5	de-noise -Dd output somewhat drop commas and left-align fields in message lists.	4 years ago
Oswald Buddenhagen	2f3cb5f481	fix signedness issues surrounding UIDs amends `bb632d1c`.	4 years ago
Oswald Buddenhagen	e334eb3580	make find_uint_array() never create negative indices	4 years ago
Oswald Buddenhagen	01348f6f7c	centralize "const cast" in make_key()	4 years ago
Oswald Buddenhagen	27a1935361	fix strftime() format string warning properly the workaround for -Wformat triggered -Wformat-nonliteral in turn. so instead go back to using pragmas and add a proper gcc version check. this also works with clang - mostly for qt-creator's code model, which is clang-based. amends/reverts `55e65147`.	4 years ago
Oswald Buddenhagen	b885e0e03a	don't use reserved identifier pattern in stringify()	4 years ago
Oswald Buddenhagen	85688d1c1a	don't leak the channel list after all unlike the actual configuration data, it's not kept in global variables, so it shows up in memcheck. amends `1de3ecd88`.	4 years ago
Oswald Buddenhagen	09d11245cd	don't leak box list from the command line we also free the box list obtained from IMAP, so there isn't a real reason not to do that for one from the command line. amends `1de3ecd88`.	4 years ago
Oswald Buddenhagen	83adb9a39b	actually implement maildir_get_uidnext() the assumption was that this wouldn't be needed, as maildir_store_msg() reliably delivers a UID. however, if we crash right before the callback can record that UID, we'd still use OPEN_FIND in the next run, which requires the saved next UID.	4 years ago
Oswald Buddenhagen	c84235b068	get rid of maildir_find_new_msgs() stub a failed assertion isn't any better than a clean segfault with an obvious backtrace.	4 years ago
Oswald Buddenhagen	38e7b4db22	Maildir: fix setting flags on messages without ":2," part this is mostly hypothetical, as all messages i've encountered actually have it even if no flags are set on them.	4 years ago
Oswald Buddenhagen	406931bc45	autotest: use symbolic message subjects ... instead of numbers. otherwise there is too much confusion with UIDs.	4 years ago
Oswald Buddenhagen	6734b9ce7d	autotest: re-order mailbox contents according to UIDs ... instead of subjects, because that's way more natural and thus less confusing.	4 years ago
Oswald Buddenhagen	f3629c69e1	autotest: re-organize mailbox storage by UID an effect of `7ce658d` is that we can index messages by UID rather than content (or more specifically, subject). apart from being cleaner, it allows duplicated subjects.	4 years ago
Oswald Buddenhagen	b59ee239a4	autotest: assume that each message has a UID followup to `7ce658d14`.	4 years ago
Oswald Buddenhagen	50eab08509	autotest: show the right state file after idempotence test failure amends `efd72b85`.	4 years ago
Oswald Buddenhagen	d59392e901	autotest: fix prototype of ckbox()	4 years ago
Oswald Buddenhagen	ef2caa074e	autotest: create the temp dir in $TEMP on modern systems, this makes it likely to end up on tmpfs, which is a lot faster and ssd-friendlier. the symlink is not deleted at the end, to minimize fs churn. that means it will be dangling after a reboot, which gets fixed in the next run.	4 years ago

... 5 6 7 8 9 ...

1078 Commits (bf34d9fd29b7e2bd82ddb6b892ea0e671fc19926)