mbsync

Commit Graph

Author	SHA1	Message	Date
Oswald Buddenhagen	df29c592d1	close a bunch of fd leaks in error paths found by coverity.	11 years ago
Oswald Buddenhagen	6d2fd370a6	fix _POSIX_SYNCHRONIZED_IO usage it can be -1 for unsupported, or 0 for runtime detection (which we don't do).	11 years ago
Oswald Buddenhagen	03b3b566f1	reshuffle sources a bit split header and move some code to more logical places.	11 years ago
Oswald Buddenhagen	92b892d247	tag verbose output when channel links two verbose stores otherwise it's pure guesswork to assign the output to particular stores.	11 years ago
Oswald Buddenhagen	0b32734693	remove own_store() function from driver model the drivers which support it can abstract it inside open_store() just fine.	11 years ago
Oswald Buddenhagen	0ad8ef80b2	don't check for INBOX more than necessary	11 years ago
Oswald Buddenhagen	c293acaf24	fix listing of nested maildir mailboxes	11 years ago
Oswald Buddenhagen	b6949c64d2	avoid useless delay after creating maildir box we would see the recent timestamp of the creation and conclude that something is going on, so we'd wait. this is obviously nonsense. as we know that a freshly created mailbox is empty, simply skip the message scan alltogether.	11 years ago
Oswald Buddenhagen	71524cb6b0	reduce FSync option to a boolean there is no use for Thorough mode any more, so simplify the configuration.	11 years ago
Oswald Buddenhagen	eb1f10762f	added sync support for the arrival date of messages initial patch by Marc Hoersken <info@marc-hoersken.de>	12 years ago
Oswald Buddenhagen	1847a4e12d	make better use of ATTR_UNUSED	12 years ago
Oswald Buddenhagen	ca3a319e60	update copyrights	12 years ago
Oswald Buddenhagen	e7c96f8891	always list INBOX when asked for it it's there even if it's not there. says IMAP. no need to contradict.	12 years ago
Oswald Buddenhagen	daaf950878	split maildir_list_part() the boolean argument switched two entirely separate functions.	12 years ago
Oswald Buddenhagen	167de3e438	remove some temporaries in maildir_list_part()	12 years ago
Felipe Contreras	aad7f903ec	maildir: fix trash path double-free It should be freed at the very end. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>	12 years ago
Oswald Buddenhagen	89add4f330	downcast time_t to long for printing time_t may be long long. to keep the sprintf format strings simple, just downcast - this is not going to be a problem for the next 30 years, and until then long will be 64-bit everywhere anyway. suggested 3.5 years ago by Antoine Reilles <tonio@NetBSD.org>.	12 years ago
Oswald Buddenhagen	35851f133b	add option to control amount of fsync()ing	12 years ago
Oswald Buddenhagen	a326bf2f58	avoid that a system crash can lose mails this fixes two possible failure scenarios: - if the journal is committed but the mails are not, the missing files would be erroneously interpreted as deletions which would be propagated - less seriously, if the mail files' meta data was committed but the file contents were not, we would end up with empty files, which would have to be re-fetched "behind mbsync's back" (just deleting the files would not work - see above)	12 years ago
Oswald Buddenhagen	16e5aade3f	store config error status in conffile_t object this makes passing it around more straight-forward	12 years ago
Oswald Buddenhagen	2e07e68630	call fdatasync() after updating .uidvalidity files they must be flushed before the file system meta data, as otherwise we may end up with duplicate UIDs after a system crash.	13 years ago
Oswald Buddenhagen	f11504aa07	update copyrights make the wrapper's help string also mention copyrights pertaining only to the actual syncer, as this is the only string many people will ever see.	13 years ago
Oswald Buddenhagen	d4c786823d	replace FSF address with something more ... contemporary	13 years ago
Oswald Buddenhagen	2585dd3324	add support for hierarchical mailboxes	13 years ago
Oswald Buddenhagen	4f94197e41	calculate trash box path already in maildir_open_store() this gives us some cleaner code paths later on, as we can treat the trash box like a regular mailbox.	13 years ago
Oswald Buddenhagen	8121224744	ensure that mailbox creation in maildir_store() is limited to trashing other mailboxes would have been maildir_select()ed already.	13 years ago
Oswald Buddenhagen	1bc9c6d9cf	reject qualified mailboxes with the magic name INBOX otherwise we couldn't tell them apart from the real INBOX after stripping away the Path.	13 years ago
Oswald Buddenhagen	40f2812a41	suppress bdb complaints about unknown file format pass DB_TRUNCATE when creating databases. otherwise bdb will complain about the empty file we pass it (we have to create it upfront to implement our locking).	13 years ago
Oswald Buddenhagen	233f563569	deal with concurrent maildir modifications during listing files may be renamed (due to new -> cur transition or flag changes), which may lead to two effects if ignored: - we see both the old and the new name, so we report a spurious duplicate UID - we see neither name, so we report a spurious deletion as countermeasure, record and compare directory modification times. upon mismatch, we just start over - as usual.	13 years ago
Oswald Buddenhagen	3386285205	make maildir uidvalidity change fatal it's best to give the user a chance to fix it rather than completely messing up the syncstate by re-enumerating the UIDs.	13 years ago
Oswald Buddenhagen	a3bd10c04d	cleanup maildir error paths don't try to unlock and close databases and files - this will happen a moment later anyway, through cancelation or re-selection. ironically, this plugs a memory leak, because an open main database is used as a signal to close a temporary db in maildir_scan().	13 years ago
Oswald Buddenhagen	04ca97920d	fix potential double free the store may be discarded before we reach maildir_select() again, which will leave us with a dangling pointer.	13 years ago
Oswald Buddenhagen	e71ad53b7f	plug memory leak in maildir_store_msg() upon failure to acquire UID	13 years ago
Oswald Buddenhagen	9c86ec3442	employ alternative scheme to finding messages by TUID instead of SEARCHing every single message (which is slow and happens to be unreliabe with M$ Exchange 2010), just FETCH the new messages from the mailbox - the ones we just appended will be amongst them.	13 years ago
Oswald Buddenhagen	d2bed4990d	unify error reporting - introduce sys_error() and use it instead of perror() and error(strerror()) in all expected error conditions - perror() is used only for "something's really wrong with the system" kind of errors - file names, etc. are quoted if they are not validated yet, so e.g. an empty string becomes immediately obvious - improve and unify language - add missing newlines	13 years ago
Oswald Buddenhagen	dee9f51096	don't complain about disappearing temp files some other process might be cleaning up concurrently ...	13 years ago
Oswald Buddenhagen	3169c59e10	validate maildirs more strictly now that "SyncState *" won't create fake mailboxes any more, we can make a full validity check again.	13 years ago
Oswald Buddenhagen	05fd0b9970	split out drv->load() from drv->select()	13 years ago
Oswald Buddenhagen	c741d5ffb5	make creation of trash folder independent from -C option the trash is not a box which is synced, but a "byproduct" of manipulating synced boxes, so it makes no sense to bind it to the same option.	13 years ago
Oswald Buddenhagen	ea951a697f	fix error paths wrt sync drivers, take 2 synchronous error codes which are passed through callbacks aren't a particularly good idea, after all: latest when the callback does stuff which does not concern the caller, the return code becomes ambiguous. instead, protect the sync_vars object with a refcount when invoking driver functions from loops, as the callbacks they call could invalidate the object and we would have no way of knowing that the loop should be aborted prematurely. the upcoming async imap driver will also need a refcount to protect the cancelation marker of the imap socket dispatcher loop.	13 years ago
Oswald Buddenhagen	b0bbd23512	replace DRV_STORE_BAD with a separate bad_callback() that way we don't have to piggy-back (possibly asynchronous) fatal errors to particular commands. internally, the drivers still use synchronous return values as well, so they don't try to access the invalidated store after calling back.	13 years ago
Oswald Buddenhagen	9554026443	make drv->cancel()'s callback have no status code this function is not going to actually execute any commands, so it makes no sense for the callback to have a status code.	13 years ago
Oswald Buddenhagen	c66afdc0a8	move setting of ctx->listed outside the drivers it's essentially an external state flag	13 years ago
Oswald Buddenhagen	f6a25b331f	check return value from close() after write() otherwise we may lose data when quota is exceeded or nfs is in a bad mood.	13 years ago
Oswald Buddenhagen	61d98c5a1d	fix a bunch of warnings	13 years ago
Oswald Buddenhagen	d637772339	turns out, free(NULL) is just fine ...	14 years ago
Oswald Buddenhagen	d94dadbaeb	fix line ending conversion logic imap may very well store messages with LF line endings. only RFC2822 requires CRLF. consequently, preserve the line endings as much as possible unless the mailbox format does not support it (this would be the case for unix mbox - i actually have no idea about maildir).	15 years ago
Oswald Buddenhagen	a365e20660	put pointers to bdb open() into parentheses, so they won't be macro-expanded as libc open. patch by fedora -REF: <1197916586.13945.120.camel@localhost.localdomain>	17 years ago
Oswald Buddenhagen	023d3ee577	fix error paths wrt sync drivers	18 years ago
Oswald Buddenhagen	e0d72cd5e3	reverse-map <Inbox> to INBOX when encountered during listing. usually this will be a no-op (when putting INBOX in Path, people generally call it INBOX), but better safe than sorry.	18 years ago

1 2 3

123 Commits (c3350753b0e3a256ccbd6eeb5924f7089b7a77f1)