mbsync

Commit Graph

Author	SHA1	Message	Date
Oswald Buddenhagen	9c86ec3442	employ alternative scheme to finding messages by TUID instead of SEARCHing every single message (which is slow and happens to be unreliabe with M$ Exchange 2010), just FETCH the new messages from the mailbox - the ones we just appended will be amongst them.	13 years ago
Oswald Buddenhagen	b4cef554fc	clearer debug msg	13 years ago
Oswald Buddenhagen	7c815538ab	fix line wrapping before info messages unless an info message is explictly marked as a continuation, it must terminate any pending line (typically the progress information) first. debug output is not affected, as it is mutually exclusive with info output, and no debug lines are left unterminated outside clear scopes.	13 years ago
Oswald Buddenhagen	6b3b6f12bb	centralize flushing of unfinished debug lines	13 years ago
Oswald Buddenhagen	d2bed4990d	unify error reporting - introduce sys_error() and use it instead of perror() and error(strerror()) in all expected error conditions - perror() is used only for "something's really wrong with the system" kind of errors - file names, etc. are quoted if they are not validated yet, so e.g. an empty string becomes immediately obvious - improve and unify language - add missing newlines	13 years ago
Oswald Buddenhagen	584e51ed7d	docs - insert "separator comments" between driver entry points - document driver API - document sync_vars_t parts that are stored in the sync state header	13 years ago
Oswald Buddenhagen	e5d323cc47	rely on the maildir's existence with "SyncState *" now that we open the box first, we know that it will exist at this point.	13 years ago
Oswald Buddenhagen	05fd0b9970	split out drv->load() from drv->select()	13 years ago
Oswald Buddenhagen	424e0e7221	make callbacks return early when canceling even after driver->cancel() the store may complete commands successfully. return early in this case, so we don't attempt to continue syncing.	13 years ago
Oswald Buddenhagen	ea951a697f	fix error paths wrt sync drivers, take 2 synchronous error codes which are passed through callbacks aren't a particularly good idea, after all: latest when the callback does stuff which does not concern the caller, the return code becomes ambiguous. instead, protect the sync_vars object with a refcount when invoking driver functions from loops, as the callbacks they call could invalidate the object and we would have no way of knowing that the loop should be aborted prematurely. the upcoming async imap driver will also need a refcount to protect the cancelation marker of the imap socket dispatcher loop.	13 years ago
Oswald Buddenhagen	ec8f440383	don't call cancel() repeatedly on a store erroring command replies will trickle in even after canceling	13 years ago
Oswald Buddenhagen	b0bbd23512	replace DRV_STORE_BAD with a separate bad_callback() that way we don't have to piggy-back (possibly asynchronous) fatal errors to particular commands. internally, the drivers still use synchronous return values as well, so they don't try to access the invalidated store after calling back.	13 years ago
Oswald Buddenhagen	6d86e5347e	don't access free'd memory in cancel_sync() as it happens, the 1st round may trash svars - if we get the cancelation request after the slave store has already died.	13 years ago
Oswald Buddenhagen	9554026443	make drv->cancel()'s callback have no status code this function is not going to actually execute any commands, so it makes no sense for the callback to have a status code.	13 years ago
Oswald Buddenhagen	57444e9df9	don't decode aux pointer on DRV_CANCELED the aux data was already free()d by the error callback by the time we get this status code.	13 years ago
Oswald Buddenhagen	7bab2d6d94	de-duplicate error paths makes the code more compact. yay for gotos.	13 years ago
Oswald Buddenhagen	61d98c5a1d	fix a bunch of warnings	13 years ago
Oswald Buddenhagen	058d01f179	don't compare find_old_done with find_new_total this didn't have any effect as no async drivers currently exist.	14 years ago
Oswald Buddenhagen	296ac0364c	add CR after TUID during LF => CRLF conversion	14 years ago
Oswald Buddenhagen	8df1ebaf40	fix (another) out-of-bounds access in CRLF conversion if the header contained no CRs but the body (or the post-TUID part of the header) did, the TUID insertion would add an excess CR, thus overflowing the buffer by one byte.	14 years ago
Oswald Buddenhagen	d94dadbaeb	fix line ending conversion logic imap may very well store messages with LF line endings. only RFC2822 requires CRLF. consequently, preserve the line endings as much as possible unless the mailbox format does not support it (this would be the case for unix mbox - i actually have no idea about maildir).	15 years ago
Oswald Buddenhagen	09dfddb36b	some more error reporting relating malformed messages	15 years ago
Oswald Buddenhagen	92914b37cc	deal with UIDVALIDITY of 0 properly. -REF: 20080822094543.GA3528@ugly.local	17 years ago
Oswald Buddenhagen	023d3ee577	fix error paths wrt sync drivers	18 years ago
Oswald Buddenhagen	9b657a46a0	fix bug in newline conversion causing buffer overflows. this leads to segfaults and has some security impact.	19 years ago
Oswald Buddenhagen	21abb22c98	seen messages are eligible for expiration even if they are recent in the mailbox.	19 years ago
Oswald Buddenhagen	168e5f3282	make the driver model, sync_chans() and sync_boxes() fully async. async drivers to follow ...	19 years ago
Oswald Buddenhagen	bdcc285403	unscrew lf=>crlf conversion and tuid insertion	19 years ago
Oswald Buddenhagen	16eaf903db	ok, mismerging and not running the reg-tests is lame. unscrew expunging again.	19 years ago
Oswald Buddenhagen	c7903f8003	don't enter trash loop if not trashing at all. also, move expunge message where it belongs. not adding info("trashing"), as it will be replaced in a moment anyway.	19 years ago
Oswald Buddenhagen	b5d70aa596	async merge: aggregate most variables of main() & sync_boxes() in main_vars_t resp. sync_vars_t. also some minor var renames, whitespace, comments.	19 years ago
Oswald Buddenhagen	72a2d4b690	info() about opening of stores	19 years ago
Oswald Buddenhagen	3e3cf3ac9a	update copyrights	19 years ago
Oswald Buddenhagen	d7126dca5e	"fprintf( stderr," => "error(". new functions debugn() and infon() for messages with missing newline; warn() and error() act upon this.	19 years ago
Oswald Buddenhagen	fbbb86738b	factor out box selection from sync_boxes to avoid code dupe	19 years ago
Oswald Buddenhagen	bc39f10a1e	lock the sync state open the journal before opening the master. this is a bit ugly for the "SyncState *" case, as we have to create a directory without making it a maildir right away. however, this makes the code quite a bit simpler to understand and simpler to parallelize.	19 years ago
Oswald Buddenhagen	5224b5bc9f	don't commit state file when a fatal error occurs	19 years ago
Oswald Buddenhagen	630a04ad3e	unbelieveable, but close() can actually fail	19 years ago
Oswald Buddenhagen	1453e61840	update fsf's postal address. i think it's sort of useless nowadays anyway, but heck ...	19 years ago
Oswald Buddenhagen	e567cc6919	and now don't clobber the mails ...	19 years ago
Oswald Buddenhagen	850addecd5	wrap message storing into transactions. nice side effect: drivers don't need to deal with line end conversion any move.	19 years ago
Oswald Buddenhagen	19128f1587	major overhaul of flag change propagation and MaxMessages handling: - wrap message (un)expirations into transactions - no redundand flag propagations in conjunction with expirations - better prepared for the upcoming async operation	19 years ago
Oswald Buddenhagen	bbc0a877c8	less cluttered debug output	19 years ago
Oswald Buddenhagen	58db1d05ac	cosmetics: move around variable declarations and remove obsolete comment	19 years ago
Oswald Buddenhagen	905ded175f	versioned journal. the commands and their meanings change all the time, so better handle that case. ps: yes, i think not upgrading mbsync between interrupting and resuming a run is a reasonable requirement.	19 years ago
Oswald Buddenhagen	8728dfdf21	make the sync entry search in the journal replay wrap around at the end of the list. the "always forward" assumption is violated in some cases.	19 years ago
Oswald Buddenhagen	d1c4f8a069	orphan/kill all affected entries after expunge	19 years ago
Oswald Buddenhagen	1a536a3415	M_EXPIRED -> M_EXPIRE	19 years ago
Oswald Buddenhagen	40fc6a6ac8	sanitize S_DEL	19 years ago
Oswald Buddenhagen	e205eb62f5	remove superfluous temporary rflags from sync_boxes	19 years ago

1 2 3 4

184 Commits (c3350753b0e3a256ccbd6eeb5924f7089b7a77f1)