mbsync

Commit Graph

Author	SHA1	Message	Date
Oswald Buddenhagen	d54809e268	prepend "get_" to getters in driver_t this makes it callbacks consistently start with a verb.	8 years ago
Oswald Buddenhagen	36666f7e52	rewrite tracking of highest expired UID so far, we tracked the slave side, and calculated the master side on the fly. that complicated things unnecessarily.	8 years ago
Oswald Buddenhagen	677accfd84	streamline syncing of old entries the order of the conditionals was purely historical (pre `4ec56f8cf`, anno 2005) and hard to follow, as were the comments.	8 years ago
Oswald Buddenhagen	990c8a1404	sort uid exception list in a smarter place do it closer to where it is populated. that way the debug output is sorted, and we don't sort the list if it's known to be empty.	8 years ago
Oswald Buddenhagen	72be55b0e3	add fallbacks for determining UIDNEXT if the server sends no UIDNEXT, do an initial FETCH to query the UID of the last message. same if the server sends no APPENDUID. this allows us to remove the arbitrary limitation of the UID range to INT_MAX, at the cost of additional round-trips.	8 years ago
Oswald Buddenhagen	416ced25dd	fix repeated listing of same Store with different flags multiple Channels can call driver_t::list_store() with different LIST_* flags. assuming the flags are actually taken into consideration, using a single boolean 'listed' flag to track whether the Store still needs to be listed obviously wouldn't cut it - if INBOX does not live right under Path and the Channels used entirely disjoint Patterns (say, * and INBOX), the second Channel in a single run (probably a Group) would fail to match anything. to fix this, make store_t::listed more granular. this also requires moving its handling back into the drivers (thus reverting `c66afdc0`), because the actually performed queries and their possible implicit results are driver-specific. note that this slightly pessimizes some cases - e.g., an IMAP Store with Path "" will now list the entire namespace even if there is only one Channel with Pattern "INBOX" (because a hypothetical Pattern "" would also include INBOX, and the queries are kept disjoint to avoid the need for de-duplication). this isn't expected to be a problem, as listing mailboxes is generally cheap.	8 years ago
Oswald Buddenhagen	b9505301cc	factor out listing Maildir++ Stores Maildir++ is sufficiently different from the other SubFolder styles to justify a separate function; the resulting code duplication is minimal, but the separated functions are a lot clearer.	8 years ago
Oswald Buddenhagen	9eaa97923a	fix exclusion of bogus "INBOX.*" folders in Maildir++ this also adds code which avoids that the message about excluding the mailbox is printed multiple times - this could happen with Maildir++, as the hierarchy is flattened. amends `0f24ca31b`.	8 years ago
Oswald Buddenhagen	2d1cfc2c7f	make "Patterns " match INBOX in Maildir++ Stores this also has the side effect that we won't fail to include INBOX itself when Inbox is nested under Path when using other SubFolder styles (regression introduced with Maildir++ support in `0f24ca31b`). REFMAIL: 1489492069.2148187.910409864.7727F9FC@webmail.messagingengine.com	8 years ago
Oswald Buddenhagen	763cb8341f	make help screen print some more compile time options	8 years ago
Oswald Buddenhagen	28d52b2b18	de-obfuscate cmd_sendable() split the monster conditional and add comments.	8 years ago
Oswald Buddenhagen	0aa4c628df	add comments	8 years ago
Oswald Buddenhagen	34993fbca6	fix sync resumption with aborted entries we need a separate log entry type which does proper mmaxxuid tracking. while moving code around, this also removes a redundant debug statement. amends `b1842617`.	8 years ago
Oswald Buddenhagen	887b2205ff	remove nonsensical statement from journal replay of aborted entries at this stage, entries cannot possibly have messages assigned to them, so trying to unlink them makes no sense. amends `b1842617`.	8 years ago
Oswald Buddenhagen	5c2ce59217	fix sync resumption with re-newed messages the UID of the entries needs to be bumped from -1 to -2, as otherwise the resumed run would see a TUID in a sync entry which may not have one.	8 years ago
Oswald Buddenhagen	7c466fc3e7	don't emit redundant flag updates for re-newed messages	8 years ago
Oswald Buddenhagen	1ea2e69aa7	fix maxuid tracking newmaxuid represents the highest UID for which a sync entry was created, while maxuid represents the end of the range which is guaranteed to have been propagated. that means that the former needs to be instantly incremented (and logged), while the latter must not be touched until the entire new message sync completes. this matters particularly in the case of resuming an interrupted run, where sync entry creation must resume exactly where it left off, while loading the box must use the old limit to ensure that all messages are available for actual propagation.	8 years ago
Oswald Buddenhagen	6705604c4a	de-duplicate journal replay somewhat we've been using indices to separate master/slave state for a long time, so there is no point in using pairs of matching brackets to signify the side in the journal. instead, use somewhat descriptive letters (S[een], F[ind], T[rashed]) and the index itself.	8 years ago
Oswald Buddenhagen	af4b8896f0	use typedefs for structs more makes the code more compact (and consistent, as typedefs were already used in some places).	8 years ago
Oswald Buddenhagen	c3350753b0	factor out jFprintf()	8 years ago
Oswald Buddenhagen	1fdf793a3f	fix signedness of 'nex' variables they are derived from srec->status, which is unsigned. for not understood reasons, the compiler complains only after extending status to a full unsigned int. on the way, localize the declarations.	8 years ago
Oswald Buddenhagen	1e939bafd8	don't use strncpy() to copy TUIDs latest since `77acc268`, the code prior to these statements ensures that the full length is available, so just use memcpy(). the code for comparing TUIDs uses memcmp() anyway.	8 years ago
Oswald Buddenhagen	d754608f55	autotest: improve valgrind integration introduce recognition of $USE_VALGRIND to run all mbsync invocations through valgrind. this also removes the seemingly purposeless --log-fd=3 indirection.	8 years ago
Oswald Buddenhagen	f29bed526b	autotest: write logs to files they can get long, and having actual files also helps with diffing.	8 years ago
Oswald Buddenhagen	991e809c38	autotest: factor out readfile() function	8 years ago
Oswald Buddenhagen	2da7951fe0	autotest: de-duplicate error reporting paths	8 years ago
Oswald Buddenhagen	373abcef02	autotest: print consistent information for journal replay failures	8 years ago
Oswald Buddenhagen	ca43c57e85	autotest: don't print expected result if the mbsync run itself fails there isn't an actual result to compare with anyway.	8 years ago
Oswald Buddenhagen	b4d1a05365	autotest: de-duplicate: use print() in show() this actually adds some (minimal) transformation overhead, but it makes the relationship clearer.	8 years ago
Oswald Buddenhagen	8aed94420f	autotest: determine path of mbsync prior to chdir() that allows tmp/ to be a symlink to a ramdisk.	8 years ago
Oswald Buddenhagen	71ced65fcc	Merge remote-tracking branch 'origin/1.2' Conflicts: src/sync.c	8 years ago
Oswald Buddenhagen	62808c9003	autotest: use warnings	8 years ago
Oswald Buddenhagen	b45e711da5	autotest: remove stray close() call from printstate()	8 years ago
Oswald Buddenhagen	f934e995d6	don't populate sync record map with invalid UIDs this would obviously just bloat the hash with nonsense, slowing down the actual lookup later.	8 years ago
Oswald Buddenhagen	f62b3c7be9	fix mislabeling of test	8 years ago
Oswald Buddenhagen	3ebb066aba	make -DN print also the sent data	8 years ago
Oswald Buddenhagen	2457b2baa3	don't arbitrarily limit UIDs to a billion, part 2 imap_find_new_msgs() had the same fixed limit as imap_load_box(). amends `815822d8`.	8 years ago
Oswald Buddenhagen	77acc26812	implement Message-Id based UIDVALIDITY recovery	8 years ago
Oswald Buddenhagen	f9fe75602e	don't fetch message size unless necessary when syncing flags but not re-newing non-fetched messages, there is no need to query the message size for all messages, as the old ones are queried only for their flags.	8 years ago
Oswald Buddenhagen	ec4b21535f	some reshuffling in maildir_scan() for clarity	8 years ago
Oswald Buddenhagen	3d64f16702	make fetching of partial UID ranges more flexible instead of a single hard-coded branch, use a generic method to split ranges as needed. this is of course entirely over-engineered as of now, but subsequent commits will make good use of it.	8 years ago
Oswald Buddenhagen	1d3b36f89e	factor out app_cr	8 years ago
Oswald Buddenhagen	3dffd68825	factor out copy_msg_convert()	8 years ago
Oswald Buddenhagen	951b7e77f8	factor out copy_msg_bytes()	8 years ago
Oswald Buddenhagen	509a191474	make more use of strnlen() includes adding the so far superfluous prototype for the replacemnt to common.h.	8 years ago
Oswald Buddenhagen	3eea668052	make use of memchr() in strnlen() replacement after all turns out the comment advising against it was bogus - unlike for memcmp(), the standard does indeed prescribe that the memchr() implementation may not read past the first occurrence of the searched char.	8 years ago
Oswald Buddenhagen	357dd51405	adjust return type of strnlen() replacement it doesn't really matter, but it's nicer to stay consistent with the official prototype.	8 years ago
Oswald Buddenhagen	67f4aeff1f	standardize on 'int' for message sizes that's what the sources already assumed anyway. size_t is total overkill, as No Email Ever (TM) will exceed 2GiB. this also fixes a harmless format string warning in 32 bit builds.	8 years ago
Oswald Buddenhagen	0c36655201	print actually read TUID in debug message	8 years ago
Oswald Buddenhagen	1330f43034	null-terminate lines read from state file & journal makes the subsequent code less convoluted.	8 years ago

1 2 3 4 5 ...

946 Commits (cab14608caa7b99478c86b526179b3990359ea1e) All Branches Search

946 Commits (cab14608caa7b99478c86b526179b3990359ea1e)

All Branches