Peter Johnson
eabbd17f1c
testing: add test case: incorrect parsing of diagonal directionals - no subsequent element
6 years ago
Julian Simioni
ee43ec041c
fix(libpostal): check for next element before using it
6 years ago
Julian Simioni
42cfcd843a
Merge pull request #1216 from pelias/libpostal_aus_unit_numbers
...
libpostal aus unit numbers
6 years ago
Peter Johnson
4e8a5385f4
feat(libpostal_patch): additional tests
6 years ago
Peter Johnson
27a9e1d900
feat(libpostal_patch): enable field mapping for "unit"
6 years ago
Peter Johnson
69ddbaf3be
feat(libpostal_patch): correctly parse australian-style unit numbers
6 years ago
Peter Johnson
6e2e4fc53a
feat(libpostal_patch): refactor diagonals patch to use an index and lodash functions
6 years ago
Peter Johnson
c8d7776587
feat(libpostal_patch): refactor code to use lodash methods for key checking
6 years ago
Peter Johnson
19eb0b57d1
feat(libpostal_patch): add a libpostal patch which allows recasting labels
6 years ago
Julian Simioni
a982eab215
Merge pull request #1214 from pelias/fix-autocomplete-tokenization
...
fix(autocomplete): detect the case where input text is unsubstantial
6 years ago
Julian Simioni
b1107a0c8f
fix(autocomplete): detect the case where input text is unsubstantial
...
It's possible for the `text` input to /v1/autocomplete to be of non-zero
length after trimming whitespace and quotes, but still be insufficient
to use for geocoding.
One common case is that it contains only commas, slashes, or other
delimiters.
Our query logic currently does not handle this case, and will generate
Elasticsearch queries that do not have a primary `must` clause and end
up searching every document in the index. These queries are slow, take
up cluster resources, and are not useful.
By detecting unsubstantial inputs, we can prevent this.
6 years ago
Julian Simioni
97b5e9d2ef
Merge pull request #1212 from pelias/boundary-country-to-filter
...
fix(boundary.country): use boundary.country query as filter
6 years ago
Julian Simioni
c20737f458
fix(boundary.country): use boundary.country as filter
...
By definition, all boundary.country query matches will either be
identical, or not a match. Thus, it does not make sense to put the query
clause for boundary.country in the `must` section of the query.
In theory, because our queries would generally combine this `must`
clause with others, there shouldn't be any performance improvement (or
regression) from this change.
However, semantically, this clause fits better as a `filter`, and in the
case of a bug causing a degenerate query with the `boundary.country`
query clause as the only one under the `must` section, this would have a
big impact.
6 years ago
Julian Simioni
06ba3a79e6
Merge pull request #1211 from pelias/trim-text
...
fix(sanitizer): Trim whitespace in addressit queries
6 years ago
Julian Simioni
7e4559fdc2
fix(sanitizer): Trim whitespace in addressit queries
...
This is a followup PR to https://github.com/pelias/api/pull/1171 and
https://github.com/pelias/api/pull/1170 .
Apparently we have two different `text` sanitizers, and autocomplete
queries were treating a single space as valid input. This had a
particularly bad outcome as it would end up generating queries (see an
[example](https://gist.github.com/orangejulius/2cc26c7eed39311b6eaf1fb0175c13e6 )) that had no main query clause.
This caused them to match basically every document in the index. Looking
at the geocode.earth slowlog, these queries took **__8 seconds per
shard__**.
6 years ago
Julian Simioni
a6fc61b454
Merge pull request #1208 from pelias/greenkeeper/joi-14.0.0
...
Update joi to the latest version 🚀
6 years ago
greenkeeper[bot]
12bc11ad30
fix(package): update joi to version 14.0.0
6 years ago
Julian Simioni
479a05f01f
Merge pull request #1207 from pelias/handle-out-of-bounds-bbox
...
Improve invalid bounding box value handling
6 years ago
Julian Simioni
40e6054523
chore(geo_common): assert that a specific exception was thrown
...
Without checking the message when asserting an exception is thrown, it's
possible for the test to pass when undesired behavior is occuring.
6 years ago
Julian Simioni
16667199cd
feat(geo_common): improve boundary.rect error message
...
In the case where a min lat/lon is larger than a max lat/lon, the error
message was a bit confusing as it did not show the actual property name
or the values that are causing errors.
6 years ago
Julian Simioni
1553dfb103
fix(geo_common): check for invalid bbox where min=max
...
This condition will cause Elasticsearch to throw an error, we should
catch it outselves first.
The error is more friendly than the case where min>max, but still an
error.
Connects https://github.com/pelias/api/pull/1050
6 years ago
Julian Simioni
f1afda469d
Move bbox min/max check to its own function
6 years ago
Julian Simioni
76bc5c654d
fix(geo_common): check bbox parameters are within range
...
If bounding box lat/lon values are outside the correct range,
Elasticsearch throws very alarming errors.
With a little validation code we can provide more friendly and
actionable error messages.
Fixes https://github.com/pelias/pelias/issues/750
6 years ago
Julian Simioni
8a9c31e46e
Remove usage of util.format
6 years ago
Julian Simioni
1054a634de
chore(geo_common): refactor bbox min/max validation
6 years ago
Julian Simioni
3c33b98f8a
chore(geo_common): only set bbox coords if it validates
6 years ago
Julian Simioni
75b32123d4
Merge pull request #1204 from pelias/proxyquire-config
...
Use default pelias-config values for type mapping tests
6 years ago
Julian Simioni
ff5c66a269
fix(test): Use default pelias-config for type tests
...
Without this change, a user's own `pelias.json` customizations can cause
the unit tests to fail.
6 years ago
Julian Simioni
d5a0b9fc86
Remove unused library
6 years ago
Julian Simioni
c9f89fee3d
Whitespace
6 years ago
Julian Simioni
76d88b62b4
fix(tests): Sanitizer tests should use faked config
...
Otherwise a user's own pelias.json settings can cause tests to fail
6 years ago
Julian Simioni
58e44da18f
feat(labels): Merge pull request #1199 from npatroni/patch-1
...
Fix label format in Portugal
6 years ago
Nuno Patronilo
6d7726ae42
Parse order on the label field for Portugal
...
Added PRT to the array on var flipNumberAndStreetCountries
6 years ago
Julian Simioni
47f3f87e72
Fix README formatting
6 years ago
Julian Simioni
2dd2f88ea7
Merge pull request #1198 from pelias/service-configuration-docs
...
feat(docs): Add examples of using service `timeout` and `retry` settings
6 years ago
Julian Simioni
192ffc13dd
feat(docs): Add examples of using service `timeout` and `retry` settings
...
These examples have been possible from the beginning, but not explicitly
called out in documentation.
Fixes https://github.com/pelias/wof-admin-lookup/issues/192
6 years ago
Julian Simioni
8751f1ae65
Merge pull request #1197 from pelias/libpostal_bugfixes
...
apply parser bugfix for incorrect parsing of diagonal directionals
6 years ago
Peter Johnson
4d9ee0053b
feat(libpostal): patch parser output when confused by directionals
6 years ago
Julian Simioni
bee6fb7f94
Merge pull request #1196 from pelias/test-running-script
...
chore(tests): Update test running script with latest info
6 years ago
Julian Simioni
8f159ceda7
chore(tests): Update test running script with latest info
...
Use npx instead of calling binaries in node_modules, and link to
relevant issue.
Connects https://github.com/pelias/pelias/issues/744
6 years ago
Julian Simioni
1f56ba1edb
Merge pull request #1195 from pelias/remove-old-packages
...
Remove old packages
6 years ago
Julian Simioni
3ad9c342c5
feat(deps): remove nsp dev dependency
...
The NSP service is shutting down, and as far as I know we have not used
this tool frequently at all. NPM has better tools built in now, like
`npm audit`.
6 years ago
Julian Simioni
e588b92c5e
feat(deps): Remove uglify devDependency
...
As I recall, this was only added to mitigate issues with running `npm
ls` and correctly showing all dependencies installed (see
https://github.com/pelias/api/issues/1179 ).
6 years ago
Julian Simioni
1808390e83
Merge pull request #1191 from pelias/use-pelias-user
...
feat(docker): Run API processes using pelias user
6 years ago
Julian Simioni
1753eb5a9c
feat(docker): Run API processes using pelias user
...
This is enabled by the work in https://github.com/pelias/baseimage/pull/2 and lets us ensure the API is run as
a non-root user.
Additionally the maintainer label is now set in the baseimage as of
(https://github.com/pelias/baseimage/pull/8 ), so it can be removed here.
6 years ago
Julian Simioni
66fb60c4d8
Merge pull request #1187 from pelias/semantic-release-build-stage
...
Replace semantic-release dependency with TravisCI build stages
6 years ago
Julian Simioni
fe69061c0c
Update Docker version
...
This fixes an issue with the version of Alpine we're using:
6 years ago
Julian Simioni
3360640c43
Only run semantic-release on production branch
6 years ago
Julian Simioni
b5ed140111
Use docker image build script from ci-tools repo
6 years ago
Julian Simioni
2de274954f
Use ci-tools script for semantic-release
6 years ago