Browse Source

* master

drag-over-refactoring
Lebedev Konstantin 8 years ago
parent
commit
3e3bb12f28
  1. 88
      Sortable.js
  2. 2
      Sortable.min.js
  3. 3
      package.json

88
Sortable.js

@ -56,7 +56,8 @@
moved, moved,
/** @const */ /** @const */
RSPACE = /\s+/g, R_SPACE = /\s+/g,
R_FLOAT = /left|right|inline/,
expando = 'Sortable' + (new Date).getTime(), expando = 'Sortable' + (new Date).getTime(),
@ -67,7 +68,7 @@
$ = win.jQuery || win.Zepto, $ = win.jQuery || win.Zepto,
Polymer = win.Polymer, Polymer = win.Polymer,
captureMode = {capture: false, passive: false}, captureMode = false,
supportDraggable = !!('draggable' in document.createElement('div')), supportDraggable = !!('draggable' in document.createElement('div')),
supportCssPointerEvents = (function (el) { supportCssPointerEvents = (function (el) {
@ -85,6 +86,7 @@
abs = Math.abs, abs = Math.abs,
min = Math.min, min = Math.min,
savedInputChecked = [],
touchDragOverListeners = [], touchDragOverListeners = [],
_autoScroll = _throttle(function (/**Event*/evt, /**Object*/options, /**HTMLElement*/rootEl) { _autoScroll = _throttle(function (/**Event*/evt, /**Object*/options, /**HTMLElement*/rootEl) {
@ -213,7 +215,6 @@
; ;
/** /**
* @class Sortable * @class Sortable
* @param {HTMLElement} el * @param {HTMLElement} el
@ -231,7 +232,6 @@
// Export instance // Export instance
el[expando] = this; el[expando] = this;
// Default options // Default options
var defaults = { var defaults = {
group: Math.random(), group: Math.random(),
@ -314,6 +314,9 @@
filter = options.filter, filter = options.filter,
startIndex; startIndex;
_saveInputCheckedState(el);
// Don't trigger start event when an element is been dragged, otherwise the evt.oldindex always wrong when set option.group. // Don't trigger start event when an element is been dragged, otherwise the evt.oldindex always wrong when set option.group.
if (dragEl) { if (dragEl) {
return; return;
@ -420,6 +423,7 @@
_on(ownerDocument, 'touchend', _this._onDrop); _on(ownerDocument, 'touchend', _this._onDrop);
_on(ownerDocument, 'touchcancel', _this._onDrop); _on(ownerDocument, 'touchcancel', _this._onDrop);
_on(ownerDocument, 'pointercancel', _this._onDrop); _on(ownerDocument, 'pointercancel', _this._onDrop);
_on(ownerDocument, 'selectstart', _this);
if (options.delay) { if (options.delay) {
// If the user moves the pointer or let go the click or touch // If the user moves the pointer or let go the click or touch
@ -437,9 +441,7 @@
dragStartFn(); dragStartFn();
} }
if (options.forceFallback) {
evt.preventDefault();
}
} }
}, },
@ -457,6 +459,7 @@
_triggerDragStart: function (/** Event */evt, /** Touch */touch) { _triggerDragStart: function (/** Event */evt, /** Touch */touch) {
touch = touch || (evt.pointerType == 'touch' ? evt : null); touch = touch || (evt.pointerType == 'touch' ? evt : null);
if (touch) { if (touch) {
// Touch device support // Touch device support
tapEvt = { tapEvt = {
@ -675,6 +678,7 @@
group = options.group, group = options.group,
activeSortable = Sortable.active, activeSortable = Sortable.active,
isOwner = (activeGroup === group), isOwner = (activeGroup === group),
isMovingBetweenSortable = false,
canSort = options.sort; canSort = options.sort;
if (evt.preventDefault !== void 0) { if (evt.preventDefault !== void 0) {
@ -682,6 +686,10 @@
!options.dragoverBubble && evt.stopPropagation(); !options.dragoverBubble && evt.stopPropagation();
} }
if (dragEl.animated) {
return;
}
moved = true; moved = true;
// Check base state // Check base state
@ -696,21 +704,29 @@
// Check access // Check access
if (isOwner) { if (isOwner) {
if (!canSort) { if (!canSort) {
// Reverting item into the original list
if (rootEl.contains(dragEl)) { if (rootEl.contains(dragEl)) {
return; // exit return; // exit
} }
// Reverting item into the original list
revert = true; revert = true;
} }
} else if (putSortable !== this) { } else if (putSortable !== this) {
activeSortable.lastPullMode = activeGroup.checkPull(this, activeSortable, dragEl, evt); activeSortable.lastPullMode = activeGroup.checkPull(this, activeSortable, dragEl, evt);
if (!(activeSortable.lastPullMode || group.checkPut(this, activeSortable, dragEl, evt))) { if (!(activeSortable.lastPullMode && group.checkPut(this, activeSortable, dragEl, evt))) {
return; // exit; return; // exit;
} }
} }
target = _closest(evt.target, options.draggable, el);
dragRect = dragEl.getBoundingClientRect();
if (putSortable !== this) {
putSortable = this;
isMovingBetweenSortable = true;
}
// Smart auto-scrolling // Smart auto-scrolling
_autoScroll(evt, options, this.el); _autoScroll(evt, options, this.el);
@ -770,14 +786,14 @@
var width = targetRect.right - targetRect.left, var width = targetRect.right - targetRect.left,
height = targetRect.bottom - targetRect.top, height = targetRect.bottom - targetRect.top,
floating = /left|right|inline/.test(lastCSS.cssFloat + lastCSS.display) floating = R_FLOAT.test(lastCSS.cssFloat + lastCSS.display)
|| (lastParentCSS.display == 'flex' && lastParentCSS['flex-direction'].indexOf('row') === 0), || (lastParentCSS.display == 'flex' && lastParentCSS['flex-direction'].indexOf('row') === 0),
isWide = (target.offsetWidth > dragEl.offsetWidth), isWide = (target.offsetWidth > dragEl.offsetWidth),
isLong = (target.offsetHeight > dragEl.offsetHeight), isLong = (target.offsetHeight > dragEl.offsetHeight),
halfway = (floating ? (evt.clientX - targetRect.left) / width : (evt.clientY - targetRect.top) / height) > 0.5, halfway = (floating ? (evt.clientX - targetRect.left) / width : (evt.clientY - targetRect.top) / height) > 0.5,
nextSibling = target.nextElementSibling, nextSibling = target.nextElementSibling,
moveVector = _onMove(rootEl, el, dragEl, dragRect, target, targetRect, evt), moveVector = _onMove(rootEl, el, dragEl, dragRect, target, targetRect, evt),
after after = false
; ;
if (moveVector !== false) { if (moveVector !== false) {
@ -801,7 +817,7 @@
} else { } else {
after = tgTop > elTop; after = tgTop > elTop;
} }
} else { } else if (!isMovingBetweenSortable) {
after = (nextSibling !== dragEl) && !isLong || halfway && isLong; after = (nextSibling !== dragEl) && !isLong || halfway && isLong;
} }
@ -860,6 +876,7 @@
_off(ownerDocument, 'touchend', this._onDrop); _off(ownerDocument, 'touchend', this._onDrop);
_off(ownerDocument, 'pointerup', this._onDrop); _off(ownerDocument, 'pointerup', this._onDrop);
_off(ownerDocument, 'touchcancel', this._onDrop); _off(ownerDocument, 'touchcancel', this._onDrop);
_off(ownerDocument, 'selectstart', this);
}, },
_onDrop: function (/**Event*/evt) { _onDrop: function (/**Event*/evt) {
@ -974,19 +991,31 @@
putSortable = putSortable =
activeGroup = activeGroup =
Sortable.active = null; Sortable.active = null;
savedInputChecked.forEach(function (el) {
el.checked = true;
});
savedInputChecked.length = 0;
}, },
handleEvent: function (/**Event*/evt) { handleEvent: function (/**Event*/evt) {
var type = evt.type; switch (evt.type) {
case 'drop':
case 'dragend':
this._onDrop(evt);
break;
if (type === 'dragover' || type === 'dragenter') { case 'dragover':
case 'dragenter':
if (dragEl) { if (dragEl) {
this._onDragOver(evt); this._onDragOver(evt);
_globalDragOver(evt); _globalDragOver(evt);
} }
} break;
else if (type === 'drop' || type === 'dragend') {
this._onDrop(evt); case 'selectstart':
evt.preventDefault();
break;
} }
}, },
@ -1181,8 +1210,8 @@
el.classList[state ? 'add' : 'remove'](name); el.classList[state ? 'add' : 'remove'](name);
} }
else { else {
var className = (' ' + el.className + ' ').replace(RSPACE, ' ').replace(' ' + name + ' ', ' '); var className = (' ' + el.className + ' ').replace(R_SPACE, ' ').replace(' ' + name + ' ', ' ');
el.className = (className + (state ? ' ' + name : '')).replace(RSPACE, ' '); el.className = (className + (state ? ' ' + name : '')).replace(R_SPACE, ' ');
} }
} }
} }
@ -1405,6 +1434,27 @@
); );
} }
function _saveInputCheckedState(root) {
var inputs = root.getElementsByTagName('input');
var idx = inputs.length;
while (idx--) {
var el = inputs[idx];
el.checked && savedInputChecked.push(el);
}
}
try {
window.addEventListener('test', null, Object.defineProperty({}, 'passive', {
get: function () {
captureMode = {
capture: false,
passive: false
};
}
}));
} catch (err) {}
// Export utils // Export utils
Sortable.utils = { Sortable.utils = {
on: _on, on: _on,

2
Sortable.min.js vendored

File diff suppressed because one or more lines are too long

3
package.json

@ -11,7 +11,8 @@
"description": "Minimalist JavaScript library for reorderable drag-and-drop lists on modern browsers and touch devices. No jQuery. Supports AngularJS and any CSS library, e.g. Bootstrap.", "description": "Minimalist JavaScript library for reorderable drag-and-drop lists on modern browsers and touch devices. No jQuery. Supports AngularJS and any CSS library, e.g. Bootstrap.",
"main": "Sortable.js", "main": "Sortable.js",
"scripts": { "scripts": {
"test": "grunt" "test": "grunt",
"prepublish": "grunt"
}, },
"repository": { "repository": {
"type": "git", "type": "git",

Loading…
Cancel
Save