Browse Source

Fix #1052

Added check as function might return null
pull/1053/head
GermainBergeron 10 years ago
parent
commit
29178c1f63
  1. 52
      c3.js
  2. 2
      c3.min.js
  3. 52
      src/arc.js

52
c3.js

@ -4836,18 +4836,22 @@
return; return;
} }
updated = $$.updateAngle(d); updated = $$.updateAngle(d);
arcData = $$.convertToArcData(updated); if (updated) {
// transitions arcData = $$.convertToArcData(updated);
$$.expandArc(updated.data.id); // transitions
$$.api.focus(updated.data.id); $$.expandArc(updated.data.id);
$$.toggleFocusLegend(updated.data.id, true); $$.api.focus(updated.data.id);
$$.config.data_onmouseover(arcData, this); $$.toggleFocusLegend(updated.data.id, true);
$$.config.data_onmouseover(arcData, this);
}
} : null) } : null)
.on('mousemove', config.interaction_enabled ? function (d) { .on('mousemove', config.interaction_enabled ? function (d) {
var updated = $$.updateAngle(d), var updated = $$.updateAngle(d);
arcData = $$.convertToArcData(updated), if (updated) {
selectedData = [arcData]; var arcData = $$.convertToArcData(updated),
$$.showTooltip(selectedData, this); selectedData = [arcData];
$$.showTooltip(selectedData, this);
}
} : null) } : null)
.on('mouseout', config.interaction_enabled ? function (d) { .on('mouseout', config.interaction_enabled ? function (d) {
var updated, arcData; var updated, arcData;
@ -4855,19 +4859,25 @@
return; return;
} }
updated = $$.updateAngle(d); updated = $$.updateAngle(d);
arcData = $$.convertToArcData(updated); if (updated) {
// transitions arcData = $$.convertToArcData(updated);
$$.unexpandArc(updated.data.id); // transitions
$$.api.revert(); $$.unexpandArc(updated.data.id);
$$.revertLegend(); $$.api.revert();
$$.hideTooltip(); $$.revertLegend();
$$.config.data_onmouseout(arcData, this); $$.hideTooltip();
$$.config.data_onmouseout(arcData, this);
}
} : null) } : null)
.on('click', config.interaction_enabled ? function (d, i) { .on('click', config.interaction_enabled ? function (d, i) {
var updated = $$.updateAngle(d), var updated = $$.updateAngle(d);
arcData = $$.convertToArcData(updated); if (updated) {
if ($$.toggleShape) { $$.toggleShape(this, arcData, i); } var arcData = $$.convertToArcData(updated);
$$.config.data_onclick.call($$.api, arcData, this); if ($$.toggleShape) {
$$.toggleShape(this, arcData, i);
}
$$.config.data_onclick.call($$.api, arcData, this);
}
} : null) } : null)
.each(function () { $$.transiting = true; }) .each(function () { $$.transiting = true; })
.transition().duration(duration) .transition().duration(duration)

2
c3.min.js vendored

File diff suppressed because one or more lines are too long

52
src/arc.js

@ -265,18 +265,22 @@ c3_chart_internal_fn.redrawArc = function (duration, durationForExit, withTransf
return; return;
} }
updated = $$.updateAngle(d); updated = $$.updateAngle(d);
arcData = $$.convertToArcData(updated); if (updated) {
// transitions arcData = $$.convertToArcData(updated);
$$.expandArc(updated.data.id); // transitions
$$.api.focus(updated.data.id); $$.expandArc(updated.data.id);
$$.toggleFocusLegend(updated.data.id, true); $$.api.focus(updated.data.id);
$$.config.data_onmouseover(arcData, this); $$.toggleFocusLegend(updated.data.id, true);
$$.config.data_onmouseover(arcData, this);
}
} : null) } : null)
.on('mousemove', config.interaction_enabled ? function (d) { .on('mousemove', config.interaction_enabled ? function (d) {
var updated = $$.updateAngle(d), var updated = $$.updateAngle(d);
arcData = $$.convertToArcData(updated), if (updated) {
selectedData = [arcData]; var arcData = $$.convertToArcData(updated),
$$.showTooltip(selectedData, this); selectedData = [arcData];
$$.showTooltip(selectedData, this);
}
} : null) } : null)
.on('mouseout', config.interaction_enabled ? function (d) { .on('mouseout', config.interaction_enabled ? function (d) {
var updated, arcData; var updated, arcData;
@ -284,19 +288,25 @@ c3_chart_internal_fn.redrawArc = function (duration, durationForExit, withTransf
return; return;
} }
updated = $$.updateAngle(d); updated = $$.updateAngle(d);
arcData = $$.convertToArcData(updated); if (updated) {
// transitions arcData = $$.convertToArcData(updated);
$$.unexpandArc(updated.data.id); // transitions
$$.api.revert(); $$.unexpandArc(updated.data.id);
$$.revertLegend(); $$.api.revert();
$$.hideTooltip(); $$.revertLegend();
$$.config.data_onmouseout(arcData, this); $$.hideTooltip();
$$.config.data_onmouseout(arcData, this);
}
} : null) } : null)
.on('click', config.interaction_enabled ? function (d, i) { .on('click', config.interaction_enabled ? function (d, i) {
var updated = $$.updateAngle(d), var updated = $$.updateAngle(d);
arcData = $$.convertToArcData(updated); if (updated) {
if ($$.toggleShape) { $$.toggleShape(this, arcData, i); } var arcData = $$.convertToArcData(updated);
$$.config.data_onclick.call($$.api, arcData, this); if ($$.toggleShape) {
$$.toggleShape(this, arcData, i);
}
$$.config.data_onclick.call($$.api, arcData, this);
}
} : null) } : null)
.each(function () { $$.transiting = true; }) .each(function () { $$.transiting = true; })
.transition().duration(duration) .transition().duration(duration)

Loading…
Cancel
Save