Fix bug about y domain - #317

11 years ago · 2a11888dbd
3 changed files with 70 additions and 5 deletions
--- a/c3.js
+++ b/c3.js
@ -1234,9 +1234,6 @@
            isAllPositive = yDomainMin >= 0 && yDomainMax >= 0;
            isAllNegative = yDomainMin <= 0 && yDomainMax <= 0;
            if (isAllPositive) { yDomainMin = 0; }
            if (isAllNegative) { yDomainMax = 0; }
            domainLength = Math.abs(yDomainMax - yDomainMin);
            padding = padding_top = padding_bottom = domainLength * 0.1;
--- a/c3.min.js
+++ b/c3.min.js
--- a/htdocs/samples/domain_y.html
+++ b/htdocs/samples/domain_y.html
@ -0,0 +1,68 @@
 <html>
  <head>
    <link rel="stylesheet" type="text/css" href="/css/c3.css">
  </head>
  <body>
    <button id="btn1">Bar</button>
    <button id="btn2">Line</button>
    <button id="btn3">Area</button>
    <div id="chart1"></div>
    <div id="chart2"></div>
    <div id="chart3"></div>
    <script src="http://d3js.org/d3.v3.min.js" charset="utf-8"></script>
    <script src="/js/c3.js"></script>
    <script>
      var normalData = {
          columns: [
            ['data1', -1030, -1200, 1000],
            ['data2', -1150, -220, -1110]
          ],
      },
      allPositiveData = {
          columns: [
            ['data1', 1030, 1200, 1100],
            ['data2', 2050, 2020, 2010]
          ],
      },
      allNegativeData = {
          columns: [
            ['data1', -1030, -2200, -2100],
            ['data2', -1150, -2010, -1200]
          ]
      }
      var chart1 = c3.generate({
        bindto: '#chart1',
        data: normalData
      });
      var chart2 = c3.generate({
        bindto: '#chart2',
        data: allPositiveData
      });
      var chart3 = c3.generate({
        bindto: '#chart3',
        data: allNegativeData
      });
      d3.select('#btn1').on('click', function () {
        chart1.transform('bar');
        chart2.transform('bar');
        chart3.transform('bar');
      });
      d3.select('#btn2').on('click', function () {
        chart1.transform('line');
        chart2.transform('line');
        chart3.transform('line');
      });
      d3.select('#btn3').on('click', function () {
        chart1.transform('area');
        chart2.transform('area');
        chart3.transform('area');
      });
    </script>
  </body>
 </html>