Browse Source

Remove useless code in mouseover - #948

pull/1003/head
Masayuki Tanaka 10 years ago
parent
commit
35e5a63de5
  1. 19
      c3.js
  2. 8
      c3.min.js
  3. 19
      src/interaction.js

19
c3.js

@ -2308,28 +2308,11 @@
.attr("class", $$.classEvent.bind($$)) .attr("class", $$.classEvent.bind($$))
.style("cursor", config.data_selection_enabled && config.data_selection_grouped ? "pointer" : null) .style("cursor", config.data_selection_enabled && config.data_selection_grouped ? "pointer" : null)
.on('mouseover', function (d) { .on('mouseover', function (d) {
var index = d.index, selectedData, newData; var index = d.index;
if ($$.dragging || $$.flowing) { return; } // do nothing while dragging/flowing if ($$.dragging || $$.flowing) { return; } // do nothing while dragging/flowing
if ($$.hasArcType()) { return; } if ($$.hasArcType()) { return; }
selectedData = $$.data.targets.map(function (t) {
return $$.addName($$.getValueOnIndex(t.values, index));
});
// Sort selectedData as names order
newData = [];
Object.keys(config.data_names).forEach(function (id) {
for (var j = 0; j < selectedData.length; j++) {
if (selectedData[j] && selectedData[j].id === id) {
newData.push(selectedData[j]);
selectedData.shift(j);
break;
}
}
});
selectedData = newData.concat(selectedData); // Add remained
// Expand shapes for selection // Expand shapes for selection
if (config.point_focus_expand_enabled) { $$.expandCircles(index, null, true); } if (config.point_focus_expand_enabled) { $$.expandCircles(index, null, true); }
$$.expandBars(index, null, true); $$.expandBars(index, null, true);

8
c3.min.js vendored

File diff suppressed because one or more lines are too long

19
src/interaction.js

@ -114,28 +114,11 @@ c3_chart_internal_fn.generateEventRectsForSingleX = function (eventRectEnter) {
.attr("class", $$.classEvent.bind($$)) .attr("class", $$.classEvent.bind($$))
.style("cursor", config.data_selection_enabled && config.data_selection_grouped ? "pointer" : null) .style("cursor", config.data_selection_enabled && config.data_selection_grouped ? "pointer" : null)
.on('mouseover', function (d) { .on('mouseover', function (d) {
var index = d.index, selectedData, newData; var index = d.index;
if ($$.dragging || $$.flowing) { return; } // do nothing while dragging/flowing if ($$.dragging || $$.flowing) { return; } // do nothing while dragging/flowing
if ($$.hasArcType()) { return; } if ($$.hasArcType()) { return; }
selectedData = $$.data.targets.map(function (t) {
return $$.addName($$.getValueOnIndex(t.values, index));
});
// Sort selectedData as names order
newData = [];
Object.keys(config.data_names).forEach(function (id) {
for (var j = 0; j < selectedData.length; j++) {
if (selectedData[j] && selectedData[j].id === id) {
newData.push(selectedData[j]);
selectedData.shift(j);
break;
}
}
});
selectedData = newData.concat(selectedData); // Add remained
// Expand shapes for selection // Expand shapes for selection
if (config.point_focus_expand_enabled) { $$.expandCircles(index, null, true); } if (config.point_focus_expand_enabled) { $$.expandCircles(index, null, true); }
$$.expandBars(index, null, true); $$.expandBars(index, null, true);

Loading…
Cancel
Save