Accept unixtime string as timeseries date input - #805

c3.js

@@ -918,8 +918,8 @@
         var $$ = this, parsedDate;
         if (date instanceof Date) {
             parsedDate = date;
-        } else if (typeof date === 'number') {
-            parsedDate = new Date(date);
+        } else if (typeof date === 'number' || !isNaN(date)) {
+            parsedDate = new Date(+date);
         } else {
             parsedDate = $$.dataTimeFormat($$.config.data_xFormat).parse(date);
         }

spec/data-spec.js

@@ -91,7 +91,10 @@ describe('c3 chart data', function () {
         });
 
         describe('milliseconds timeseries x', function () {
-            it('should load timeseries data successfully', function () {
+
+            describe('as date string', function () {
+
+                it('should update args', function () {
                     args = {
                         data: {
                             x : 'date',
@@ -138,6 +141,88 @@ describe('c3 chart data', function () {
 
             });
 
+            describe('as unixtime number', function () {
+
+                it('should update args', function () {
+                    args = {
+                        data: {
+                            x : 'date',
+                            columns: [
+                                ['date', 1417622461123, 1417622522345],
+                                ['data1', 30, 200],
+                                ['data2', 130, 300]
+                            ]
+                        },
+                        axis: {
+                            x: {
+                                type: 'timeseries',
+                                tick: {
+                                    format: '%Y-%m-%d %H:%M:%S.%L'
+                                }
+                            }
+                        }
+                    };
+                    expect(true).toBeTruthy();
+                });
+
+                it('should have correct number of xs', function () {
+                    expect(Object.keys(chart.internal.data.xs).length).toBe(2);
+                    expect(chart.internal.data.xs.data1.length).toBe(2);
+                    expect(chart.internal.data.xs.data2.length).toBe(2);
+                });
+
+                it('should have Date object as x', function () {
+                    var xs = chart.internal.data.xs;
+                    expect(+xs.data1[0]).toBe(+new Date(2014, 11, 3, 16, 1, 1, 123));
+                    expect(+xs.data1[1]).toBe(+new Date(2014, 11, 3, 16, 2, 2, 345));
+                    expect(+xs.data2[0]).toBe(+new Date(2014, 11, 3, 16, 1, 1, 123));
+                    expect(+xs.data2[1]).toBe(+new Date(2014, 11, 3, 16, 2, 2, 345));
+                });
+            });
+
+            describe('as unixtime string', function () {
+
+                it('should upate args', function () {
+                    args = {
+                        data: {
+                            x : 'date',
+                            columns: [
+                                ['date', "1417622461123", "1417622522345"],
+                                ['data1', 30, 200],
+                                ['data2', 130, 300]
+                            ]
+                        },
+                        axis: {
+                            x: {
+                                type: 'timeseries',
+                                tick: {
+                                    format: '%Y-%m-%d %H:%M:%S.%L',
+                                    multiline: false
+                                }
+                            }
+                        }
+                    };
+                    expect(true).toBeTruthy();
+                });
+
+                it('should have correct number of xs', function () {
+                    expect(Object.keys(chart.internal.data.xs).length).toBe(2);
+                    expect(chart.internal.data.xs.data1.length).toBe(2);
+                    expect(chart.internal.data.xs.data2.length).toBe(2);
+                });
+
+                it('should have Date object as x', function () {
+                    var xs = chart.internal.data.xs;
+                    expect(+xs.data1[0]).toBe(+new Date(2014, 11, 3, 16, 1, 1, 123));
+                    expect(+xs.data1[1]).toBe(+new Date(2014, 11, 3, 16, 2, 2, 345));
+                    expect(+xs.data2[0]).toBe(+new Date(2014, 11, 3, 16, 1, 1, 123));
+                    expect(+xs.data2[1]).toBe(+new Date(2014, 11, 3, 16, 2, 2, 345));
+                });
+
+            });
+
+        });
+
     });
 
     describe('data.label', function () {

src/core.js

@@ -913,8 +913,8 @@ c3_chart_internal_fn.parseDate = function (date) {
     var $$ = this, parsedDate;
     if (date instanceof Date) {
         parsedDate = date;
-    } else if (typeof date === 'number') {
-        parsedDate = new Date(date);
+    } else if (typeof date === 'number' || !isNaN(date)) {
+        parsedDate = new Date(+date);
     } else {
         parsedDate = $$.dataTimeFormat($$.config.data_xFormat).parse(date);
     }