Browse Source

Fix specs

pull/1003/head
Masayuki Tanaka 10 years ago
parent
commit
e1a39c873e
  1. 2
      .jshintrc
  2. 4
      spec/api.data-spec.js
  3. 4
      spec/api.focus-spec.js
  4. 19
      spec/api.grid-spec.js
  5. 23
      spec/api.load-spec.js
  6. 27
      spec/api.zoom-spec.js
  7. 33
      spec/axis-spec.js
  8. 2
      spec/c3-spec.js
  9. 4
      spec/class-spec.js
  10. 4
      spec/core-spec.js
  11. 4
      spec/data-spec.js
  12. 4
      spec/domain-spec.js
  13. 19
      spec/grid-spec.js
  14. 14
      spec/interaction-spec.js
  15. 39
      spec/legend-spec.js
  16. 23
      spec/shape.bar-spec.js
  17. 19
      spec/shape.line-spec.js
  18. 6
      spec/tooltip-spec.js
  19. 23
      spec/type-spec.js
  20. 4
      spec/zoom-spec.js

2
.jshintrc

@ -19,8 +19,10 @@
"browser": true, "browser": true,
"globals": { "globals": {
"jasmine": false,
"describe": false, "describe": false,
"beforeEach": false, "beforeEach": false,
"beforeAll": false,
"it": false, "it": false,
"expect": false, "expect": false,
"d3": false "d3": false

4
spec/api.data-spec.js

@ -1,8 +1,7 @@
describe('c3 api data', function () { describe('c3 api data', function () {
'use strict'; 'use strict';
var chart, d3; var chart;
var args = { var args = {
data: { data: {
@ -32,7 +31,6 @@ describe('c3 api data', function () {
beforeEach(function (done) { beforeEach(function (done) {
chart = window.initChart(chart, args, done); chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('data()', function () { describe('data()', function () {

4
spec/api.focus-spec.js

@ -1,8 +1,7 @@
describe('c3 api focus', function () { describe('c3 api focus', function () {
'use strict'; 'use strict';
var chart, d3; var chart;
var args = { var args = {
data: { data: {
@ -16,7 +15,6 @@ describe('c3 api focus', function () {
beforeEach(function (done) { beforeEach(function (done) {
chart = window.initChart(chart, args, done); chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('focus', function () { describe('focus', function () {

19
spec/api.grid-spec.js

@ -1,24 +1,25 @@
describe('c3 api grid', function () { describe('c3 api grid', function () {
'use strict'; 'use strict';
var chart, d3; var chart, args;
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
});
describe('ygrid.add and ygrid.remove', function () {
var args = { it('should update args', function () {
args = {
data: { data: {
columns: [ columns: [
['data1', 30, 200, 100, 400, 150, 250] ['data1', 30, 200, 100, 400, 150, 250]
] ]
} }
}; };
expect(true).toBeTruthy();
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('ygrid.add and ygrid.remove', function () {
it('should update y grids', function (done) { it('should update y grids', function (done) {
var main = chart.internal.main, var main = chart.internal.main,
expectedGrids = [ expectedGrids = [

23
spec/api.load-spec.js

@ -1,10 +1,18 @@
describe('c3 api load', function () { describe('c3 api load', function () {
'use strict'; 'use strict';
var chart, d3; var chart, args;
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
});
describe('indexed data', function () {
describe('as column', function () {
var args = { it('should update args', function () {
args = {
data: { data: {
columns: [ columns: [
['data1', 30, 200, 100, 400, 150, 250], ['data1', 30, 200, 100, 400, 150, 250],
@ -12,16 +20,9 @@ describe('c3 api load', function () {
] ]
} }
}; };
expect(true).toBeTruthy();
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('indexed data', function () {
describe('as column', function () {
it('should load additional data', function (done) { it('should load additional data', function (done) {
var main = chart.internal.main, var main = chart.internal.main,
legend = chart.internal.legend; legend = chart.internal.legend;

27
spec/api.zoom-spec.js

@ -1,10 +1,16 @@
describe('c3 api zoom', function () { describe('c3 api zoom', function () {
'use strict'; 'use strict';
var chart, d3; var chart, args;
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
});
var args = { describe('zoom', function () {
it('should update args', function () {
args = {
data: { data: {
columns: [ columns: [
['data1', 30, 200, 100, 400, 150, 250], ['data1', 30, 200, 100, 400, 150, 250],
@ -16,22 +22,9 @@ describe('c3 api zoom', function () {
enabled: true enabled: true
} }
}; };
expect(true).toBeTruthy();
beforeEach(function (done) {
if (typeof chart === 'undefined') {
window.initDom();
}
chart = window.c3.generate(args);
d3 = chart.internal.d3;
// chart.internal.d3.select('.jasmine_html-reporter').style('display', 'none');
window.setTimeout(function () {
done();
}, 10);
}); });
describe('zoom', function () {
it('should be zoomed properly', function () { it('should be zoomed properly', function () {
var target = [3, 5], domain; var target = [3, 5], domain;
chart.zoom(target); chart.zoom(target);

33
spec/axis-spec.js

@ -1,8 +1,7 @@
describe('c3 chart axis', function () { describe('c3 chart axis', function () {
'use strict'; 'use strict';
var chart, d3; var chart;
var args = { var args = {
data: { data: {
@ -30,16 +29,13 @@ describe('c3 chart axis', function () {
beforeEach(function (done) { beforeEach(function (done) {
chart = window.initChart(chart, args, done); chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('axis.y.tick.count', function () { describe('axis.y.tick.count', function () {
var i = 1; it('should update args to have only 1 tick on y axis', function () {
args.axis.y.tick.count = 1;
beforeEach(function () { expect(true).toBeTruthy();
args.axis.y.tick.count = i++;
chart = window.c3.generate(args);
}); });
it('should have only 1 tick on y axis', function () { it('should have only 1 tick on y axis', function () {
@ -47,11 +43,21 @@ describe('c3 chart axis', function () {
expect(ticksSize).toBe(1); expect(ticksSize).toBe(1);
}); });
it('should update args to have 2 ticks on y axis', function () {
args.axis.y.tick.count = 2;
expect(true).toBeTruthy();
});
it('should have 2 ticks on y axis', function () { it('should have 2 ticks on y axis', function () {
var ticksSize = d3.select('.c3-axis-y').selectAll('g.tick').size(); var ticksSize = d3.select('.c3-axis-y').selectAll('g.tick').size();
expect(ticksSize).toBe(2); expect(ticksSize).toBe(2);
}); });
it('should update args to have 3 ticks on y axis', function () {
args.axis.y.tick.count = 3;
expect(true).toBeTruthy();
});
it('should have 3 ticks on y axis', function () { it('should have 3 ticks on y axis', function () {
var ticksSize = d3.select('.c3-axis-y').selectAll('g.tick').size(); var ticksSize = d3.select('.c3-axis-y').selectAll('g.tick').size();
expect(ticksSize).toBe(3); expect(ticksSize).toBe(3);
@ -63,9 +69,9 @@ describe('c3 chart axis', function () {
var values = [100, 500]; var values = [100, 500];
beforeEach(function () { it('should update args to have only 2 ticks on y axis', function () {
args.axis.y.tick.values = values; args.axis.y.tick.values = values;
chart = window.c3.generate(args); expect(true).toBeTruthy();
}); });
it('should have only 2 tick on y axis', function () { it('should have only 2 tick on y axis', function () {
@ -84,7 +90,8 @@ describe('c3 chart axis', function () {
describe('axis y timeseries', function () { describe('axis y timeseries', function () {
var args = { it('should update args', function () {
args = {
data: { data: {
columns: [ columns: [
["times", 60000, 120000, 180000, 240000] ["times", 60000, 120000, 180000, 240000]
@ -100,9 +107,7 @@ describe('c3 chart axis', function () {
} }
} }
}; };
expect(true).toBeTruthy();
beforeEach(function () {
chart = window.c3.generate(args);
}); });
it('should have 7 ticks on y axis', function () { it('should have 7 ticks on y axis', function () {

2
spec/c3-spec.js

@ -1,4 +1,3 @@
describe('c3', function () { describe('c3', function () {
'use strict'; 'use strict';
@ -9,4 +8,3 @@ describe('c3', function () {
expect(typeof c3).toBe('object'); expect(typeof c3).toBe('object');
}); });
}); });

4
spec/class-spec.js

@ -1,8 +1,7 @@
describe('c3 chart class', function () { describe('c3 chart class', function () {
'use strict'; 'use strict';
var chart, d3; var chart;
var args = { var args = {
data: { data: {
@ -16,7 +15,6 @@ describe('c3 chart class', function () {
beforeEach(function (done) { beforeEach(function (done) {
chart = window.initChart(chart, args, done); chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('internal.getTargetSelectorSuffix', function () { describe('internal.getTargetSelectorSuffix', function () {

4
spec/core-spec.js

@ -1,8 +1,7 @@
describe('c3 chart', function () { describe('c3 chart', function () {
'use strict'; 'use strict';
var chart, d3; var chart;
var args = { var args = {
data: { data: {
@ -16,7 +15,6 @@ describe('c3 chart', function () {
beforeEach(function (done) { beforeEach(function (done) {
chart = window.initChart(chart, args, done); chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('init', function () { describe('init', function () {

4
spec/data-spec.js

@ -1,8 +1,7 @@
describe('c3 chart data', function () { describe('c3 chart data', function () {
'use strict'; 'use strict';
var chart, d3; var chart;
var args = { var args = {
data: { data: {
@ -19,7 +18,6 @@ describe('c3 chart data', function () {
beforeEach(function (done) { beforeEach(function (done) {
chart = window.initChart(chart, args, done); chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('function in data.order', function () { describe('function in data.order', function () {

4
spec/domain-spec.js

@ -1,8 +1,7 @@
describe('c3 chart domain', function () { describe('c3 chart domain', function () {
'use strict'; 'use strict';
var chart, d3; var chart;
var args = { var args = {
data: { data: {
@ -19,7 +18,6 @@ describe('c3 chart domain', function () {
beforeEach(function (done) { beforeEach(function (done) {
chart = window.initChart(chart, args, done); chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('axis.y.min', function () { describe('axis.y.min', function () {

19
spec/grid-spec.js

@ -1,10 +1,16 @@
describe('c3 chart grid', function () { describe('c3 chart grid', function () {
'use strict'; 'use strict';
var chart, d3; var chart, args;
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
});
describe('y grid', function () {
var args = { it('should update args', function () {
args = {
data: { data: {
columns: [ columns: [
['data1', 30, 200, 100, 400, 150, 250] ['data1', 30, 200, 100, 400, 150, 250]
@ -22,14 +28,9 @@ describe('c3 chart grid', function () {
} }
} }
}; };
expect(true).toBeTruthy();
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('y grid', function () {
it('should not show y grids', function () { it('should not show y grids', function () {
expect(chart.internal.main.select('.c3-ygrids').size()).toBe(0); expect(chart.internal.main.select('.c3-ygrids').size()).toBe(0);
}); });

14
spec/interaction-spec.js

@ -1,22 +1,10 @@
describe('c3 chart interaction', function () { describe('c3 chart interaction', function () {
'use strict'; 'use strict';
var chart, d3; var chart, args;
var args = {
data: {
columns: [
['data1', 30, 200, 100, 400, 150, 250],
['data2', 50, 20, 10, 40, 15, 25],
['data3', 150, 120, 110, 140, 115, 125]
]
}
};
beforeEach(function (done) { beforeEach(function (done) {
chart = window.initChart(chart, args, done); chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('generate event rects', function () { describe('generate event rects', function () {

39
spec/legend-spec.js

@ -1,10 +1,16 @@
describe('c3 chart legend', function () { describe('c3 chart legend', function () {
'use strict'; 'use strict';
var chart, d3; var chart, args;
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
});
describe('legend position', function () {
var args = { it('should update args', function () {
args = {
data: { data: {
columns: [ columns: [
['data1', 30, 200, 100, 400, 150, 250], ['data1', 30, 200, 100, 400, 150, 250],
@ -12,24 +18,9 @@ describe('c3 chart legend', function () {
] ]
} }
}; };
expect(true).toBeTruthy();
beforeEach(function (done) {
if (typeof chart === 'undefined') {
window.initDom();
}
chart = window.c3.generate(args);
d3 = chart.internal.d3;
chart.internal.d3.select('.jasmine_html-reporter')
.style('position', 'absolute')
.style('right', 0);
window.setTimeout(function () {
done();
}, 10);
}); });
describe('legend position', function () {
it('should be located on the center of chart', function () { it('should be located on the center of chart', function () {
var box = chart.internal.legend.node().getBoundingClientRect(); var box = chart.internal.legend.node().getBoundingClientRect();
expect(box.left + box.right).toBe(640); expect(box.left + box.right).toBe(640);
@ -40,11 +31,19 @@ describe('c3 chart legend', function () {
describe('legend as inset', function () { describe('legend as inset', function () {
it('should change the legend to "inset" successfully', function () { it('should change the legend to "inset" successfully', function () {
args.legend = { args = {
data: {
columns: [
['data1', 30, 200, 100, 400, 150, 250],
['data2', 50, 20, 10, 40, 15, 25]
]
},
legend: {
position: 'inset', position: 'inset',
inset: { inset: {
step: null step: null
} }
}
}; };
expect(true).toBeTruthy(); expect(true).toBeTruthy();
}); });

23
spec/shape.bar-spec.js

@ -1,12 +1,20 @@
var setMouseEvent = window.setMouseEvent; var setMouseEvent = window.setMouseEvent;
describe('c3 chart shape bar', function () { describe('c3 chart shape bar', function () {
'use strict'; 'use strict';
var chart, d3; var chart, args;
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
});
describe('internal.isWithinBar', function () {
describe('with normal axis', function () {
var args = { it('should update args', function () {
args = {
data: { data: {
columns: [ columns: [
['data1', 30, 200, 100, 400, -150, 250], ['data1', 30, 200, 100, 400, -150, 250],
@ -19,16 +27,9 @@ describe('c3 chart shape bar', function () {
rotated: false rotated: false
} }
}; };
expect(true).toBeTruthy();
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('internal.isWithinBar', function () {
describe('with normal axis', function () {
it('should not be within bar', function () { it('should not be within bar', function () {
var bar = d3.select('.c3-target-data1 .c3-bar-0').node(); var bar = d3.select('.c3-target-data1 .c3-bar-0').node();
setMouseEvent(chart, 'click', 0, 0); setMouseEvent(chart, 'click', 0, 0);

19
spec/shape.line-spec.js

@ -1,10 +1,16 @@
describe('c3 chart shape line', function () { describe('c3 chart shape line', function () {
'use strict'; 'use strict';
var chart, d3; var chart, args;
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
});
describe('shape-rendering for line chart', function () {
var args = { it('should update args', function () {
args = {
data: { data: {
columns: [ columns: [
['data1', 30, 200, 100, 400, -150, 250], ['data1', 30, 200, 100, 400, -150, 250],
@ -14,14 +20,9 @@ describe('c3 chart shape line', function () {
type: 'line' type: 'line'
} }
}; };
expect(true).toBeTruthy();
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('shape-rendering for line chart', function () {
it("should not have shape-rendering when it's line chart", function () { it("should not have shape-rendering when it's line chart", function () {
d3.selectAll('.c3-line').each(function () { d3.selectAll('.c3-line').each(function () {
var style = d3.select(this).style('shape-rendering'); var style = d3.select(this).style('shape-rendering');

6
spec/tooltip-spec.js

@ -1,10 +1,7 @@
var jasmine = window.jasmine,
beforeAll = window.beforeAll;
describe('c3 chart tooltip', function () { describe('c3 chart tooltip', function () {
'use strict'; 'use strict';
var chart, d3; var chart;
var tooltipConfiguration; var tooltipConfiguration;
var args = function () { var args = function () {
@ -22,7 +19,6 @@ describe('c3 chart tooltip', function () {
beforeEach(function (done) { beforeEach(function (done) {
chart = window.initChart(chart, args(), done); chart = window.initChart(chart, args(), done);
d3 = chart.internal.d3;
}); });
describe('tooltip position', function () { describe('tooltip position', function () {

23
spec/type-spec.js

@ -1,10 +1,18 @@
describe('c3 chart types', function () { describe('c3 chart types', function () {
'use strict'; 'use strict';
var chart, d3; var chart, args;
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
});
describe('internal.hasArcType', function () {
var args = { describe('with data', function () {
it('should update args', function () {
args = {
data: { data: {
columns: [ columns: [
['data1', 30, 200, 100, 400, 150, 250], ['data1', 30, 200, 100, 400, 150, 250],
@ -14,16 +22,9 @@ describe('c3 chart types', function () {
type: 'pie' type: 'pie'
} }
}; };
expect(true).toBeTruthy();
beforeEach(function (done) {
chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('internal.hasArcType', function () {
describe('with data', function () {
it('should return true', function () { it('should return true', function () {
expect(chart.internal.hasArcType()).toBeTruthy(); expect(chart.internal.hasArcType()).toBeTruthy();
}); });

4
spec/zoom-spec.js

@ -1,8 +1,7 @@
describe('c3 chart zoom', function () { describe('c3 chart zoom', function () {
'use strict'; 'use strict';
var chart, d3; var chart;
var args = { var args = {
data: { data: {
@ -26,7 +25,6 @@ describe('c3 chart zoom', function () {
beforeEach(function (done) { beforeEach(function (done) {
chart = window.initChart(chart, args, done); chart = window.initChart(chart, args, done);
d3 = chart.internal.d3;
}); });
describe('default extent', function () { describe('default extent', function () {

Loading…
Cancel
Save