Tree: 791d61168e

master

v1.0.0

v1.1.0

v1.2.0

v1.3.0

v1.4.0

v1.5.0

v1.6.0

v1.7.0

v1.7.1

v1.7.2

v1.7.3

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from '791d61168e'

${ noResults }

Commit Graph

10 Commits (791d61168ec2772e566a46ec89e081ae895a5af8)

 

All Branches   

Search

Author	SHA1	Message	Date
Michael Cordingley	791d61168e	Fix Image Removal ... `[].slice.call(foo)` returns an array that is a copy of the array-like `foo`, so when you splice it in this code, you're splicing (and then throwing away) a copy of store. I have edited the code to go ahead and slice the nodeList straight off (which saves cycles _and_ code) and then do the splicing on that directly, so your elements actually do get removed. Also, every time you splice an element out, all of the elements in the array after it get renumbered, so the next iteration ends up skipping an element. An easy remedy to this is to run the loop in reverse, so only previously-iterated elements get renumbered. This also removes the need to check indexOf, as the element in question will never be out of bounds.	11 years ago
Todd Motto	8743bff34f	IE8 Support	11 years ago
Todd Motto	189f3cebb0	IE8 support, v1.3.0	11 years ago
Todd Motto	dd712f9364	Added IE8 support, hooray!	11 years ago
Todd Motto	3b323bc66e	Save 2 bytes	11 years ago
Todd Motto	9d07ee076c	Echo.js v1.2.0	11 years ago
Todd Motto	4c2ef2fc4f	Pass in global undefined	12 years ago
Todd Motto	4f173e6fda	Echo v1.1.0, minor event bind enhancement	12 years ago
Todd Motto	5cb984e290	Add intro	12 years ago
Todd Motto	9847e92699	Initial commit	12 years ago