Eliminate some resource warnings

tests/conftest.py

@@ -7,6 +7,7 @@
     :license: BSD, see LICENSE for more details.
 """
 import flask
+import gc
 import os
 import sys
 import pkgutil
@@ -129,4 +130,5 @@ def purge_module(request):
 @pytest.yield_fixture(autouse=True)
 def catch_deprecation_warnings(recwarn):
     yield
+    gc.collect()
     assert not recwarn.list

tests/test_basic.py

@@ -1123,6 +1123,8 @@ def test_static_path_deprecated(recwarn):
     app.testing = True
     rv = app.test_client().get('/foo/index.html')
     assert rv.status_code == 200
+    rv.close()
+
     with app.test_request_context():
         assert flask.url_for('static', filename='index.html') == '/foo/index.html'
 
@@ -1132,6 +1134,8 @@ def test_static_url_path():
     app.testing = True
     rv = app.test_client().get('/foo/index.html')
     assert rv.status_code == 200
+    rv.close()
+
     with app.test_request_context():
         assert flask.url_for('static', filename='index.html') == '/foo/index.html'
 

tests/test_helpers.py

@@ -353,7 +353,7 @@ class TestSendfile(object):
         app = flask.Flask(__name__)
 
         with app.test_request_context():
-            f = open(os.path.join(app.root_path, 'static/index.html'), mode='rb')
+            with open(os.path.join(app.root_path, 'static/index.html'), mode='rb') as f:
                 rv = flask.send_file(f)
                 rv.direct_passthrough = False
                 with app.open_resource('static/index.html') as f:
@@ -368,7 +368,7 @@ class TestSendfile(object):
         app.use_x_sendfile = True
 
         with app.test_request_context():
-            f = open(os.path.join(app.root_path, 'static/index.html'))
+            with open(os.path.join(app.root_path, 'static/index.html')) as f:
                 rv = flask.send_file(f)
                 assert rv.mimetype == 'text/html'
                 assert 'x-sendfile' in rv.headers
@@ -434,9 +434,10 @@ class TestSendfile(object):
     def test_attachment(self, recwarn):
         app = flask.Flask(__name__)
         with app.test_request_context():
-            f = open(os.path.join(app.root_path, 'static/index.html'))
+            with open(os.path.join(app.root_path, 'static/index.html')) as f:
                 rv = flask.send_file(f, as_attachment=True)
-            value, options = parse_options_header(rv.headers['Content-Disposition'])
+                value, options = \
+                    parse_options_header(rv.headers['Content-Disposition'])
                 assert value == 'attachment'
                 rv.close()