Browse Source

Re-raise BuildError with traceback.

pull/498/head
Ron DuPlain 13 years ago
parent
commit
8c8c524ddb
  1. 4
      flask/app.py
  2. 15
      flask/testsuite/basic.py

4
flask/app.py

@ -1490,6 +1490,10 @@ class Flask(_PackageBoundObject):
Calls :attr:`build_error_handler` if it is not `None`.
"""
if self.build_error_handler is None:
exc_type, exc_value, tb = sys.exc_info()
if exc_value is error:
raise exc_type, exc_value, tb
else:
raise error
return self.build_error_handler(error, endpoint, **values)

15
flask/testsuite/basic.py

@ -698,8 +698,23 @@ class BasicFunctionalityTestCase(FlaskTestCase):
def test_build_error_handler(self):
app = flask.Flask(__name__)
# Test base case, a URL which results in a BuildError.
with app.test_request_context():
self.assertRaises(BuildError, flask.url_for, 'spam')
# Verify the error is re-raised if not the current exception.
try:
with app.test_request_context():
flask.url_for('spam')
except BuildError, error:
pass
try:
raise RuntimeError('Test case where BuildError is not current.')
except RuntimeError:
self.assertRaises(BuildError, app.handle_build_error, error, 'spam')
# Test a custom handler.
def handler(error, endpoint, **values):
# Just a test.
return '/test_handler/'

Loading…
Cancel
Save