Browse Source

Merge pull request #2599 from mhartkorn/fix-release-error-deleted-user

Fix for server error on release page when a user deleted their account
pull/2603/head
Unknwon 9 years ago
parent
commit
0ad5f51059
  1. 8
      routers/repo/release.go

8
routers/repo/release.go

@ -45,9 +45,13 @@ func Releases(ctx *middleware.Context) {
if rel.TagName == rawTag { if rel.TagName == rawTag {
rel.Publisher, err = models.GetUserByID(rel.PublisherID) rel.Publisher, err = models.GetUserByID(rel.PublisherID)
if err != nil { if err != nil {
if models.IsErrUserNotExist(err) {
rel.Publisher = models.NewFakeUser()
} else {
ctx.Handle(500, "GetUserByID", err) ctx.Handle(500, "GetUserByID", err)
return return
} }
}
// FIXME: duplicated code. // FIXME: duplicated code.
// Get corresponding target if it's not the current branch. // Get corresponding target if it's not the current branch.
if ctx.Repo.BranchName != rel.Target { if ctx.Repo.BranchName != rel.Target {
@ -105,9 +109,13 @@ func Releases(ctx *middleware.Context) {
rel.Publisher, err = models.GetUserByID(rel.PublisherID) rel.Publisher, err = models.GetUserByID(rel.PublisherID)
if err != nil { if err != nil {
if models.IsErrUserNotExist(err) {
rel.Publisher = models.NewFakeUser()
} else {
ctx.Handle(500, "GetUserByID", err) ctx.Handle(500, "GetUserByID", err)
return return
} }
}
// FIXME: duplicated code. // FIXME: duplicated code.
// Get corresponding target if it's not the current branch. // Get corresponding target if it's not the current branch.
if ctx.Repo.BranchName != rel.Target { if ctx.Repo.BranchName != rel.Target {

Loading…
Cancel
Save