Browse Source

repo: remove legacy sanitizer for repository description

Related to #4329.
pull/4343/head
Unknwon 8 years ago
parent
commit
3144be5c81
No known key found for this signature in database
GPG Key ID: 25B575AE3213B2B3
  1. 14
      models/repo.go
  2. 2
      templates/explore/repo_list.tmpl
  3. 2
      templates/repo/home.tmpl

14
models/repo.go

@ -7,13 +7,11 @@ package models
import ( import (
"bytes" "bytes"
"fmt" "fmt"
"html/template"
"io/ioutil" "io/ioutil"
"os" "os"
"os/exec" "os/exec"
"path" "path"
"path/filepath" "path/filepath"
"regexp"
"sort" "sort"
"strings" "strings"
"time" "time"
@ -493,18 +491,6 @@ func (repo *Repository) NextIssueIndex() int64 {
return int64(repo.NumIssues+repo.NumPulls) + 1 return int64(repo.NumIssues+repo.NumPulls) + 1
} }
var (
DescPattern = regexp.MustCompile(`https?://\S+`)
)
// DescriptionHtml does special handles to description and return HTML string.
func (repo *Repository) DescriptionHtml() template.HTML {
sanitize := func(s string) string {
return fmt.Sprintf(`<a href="%[1]s" target="_blank">%[1]s</a>`, s)
}
return template.HTML(DescPattern.ReplaceAllStringFunc(markdown.Sanitizer.Sanitize(repo.Description), sanitize))
}
func (repo *Repository) LocalCopyPath() string { func (repo *Repository) LocalCopyPath() string {
return path.Join(setting.AppDataPath, "tmp/local-repo", com.ToStr(repo.ID)) return path.Join(setting.AppDataPath, "tmp/local-repo", com.ToStr(repo.ID))
} }

2
templates/explore/repo_list.tmpl

@ -16,7 +16,7 @@
<span class="text grey"><i class="octicon octicon-git-branch"></i> {{.NumForks}}</span> <span class="text grey"><i class="octicon octicon-git-branch"></i> {{.NumForks}}</span>
</div> </div>
</div> </div>
{{if .DescriptionHtml}}<p class="has-emoji">{{.DescriptionHtml}}</p>{{end}} {{if .Description}}<p class="has-emoji">{{.Description | Str2html}}</p>{{end}}
<p class="time">{{$.i18n.Tr "org.repo_updated"}} {{TimeSince .Updated $.i18n.Lang}}</p> <p class="time">{{$.i18n.Tr "org.repo_updated"}} {{TimeSince .Updated $.i18n.Lang}}</p>
</div> </div>
{{end}} {{end}}

2
templates/repo/home.tmpl

@ -5,7 +5,7 @@
{{template "base/alert" .}} {{template "base/alert" .}}
{{if .PageIsRepoHome}} {{if .PageIsRepoHome}}
<p id="repo-desc"> <p id="repo-desc">
{{if .Repository.DescriptionHtml}}<span class="description has-emoji">{{.Repository.DescriptionHtml}}</span>{{else}}<span class="no-description text-italic">{{.i18n.Tr "repo.no_desc"}}</span>{{end}} {{if .Repository.Description}}<span class="description has-emoji">{{.Repository.Description | Str2html}}</span>{{else}}<span class="no-description text-italic">{{.i18n.Tr "repo.no_desc"}}</span>{{end}}
<a class="link" href="{{.Repository.Website}}">{{.Repository.Website}}</a> <a class="link" href="{{.Repository.Website}}">{{.Repository.Website}}</a>
</p> </p>
<div class="ui segment" id="git-stats"> <div class="ui segment" id="git-stats">

Loading…
Cancel
Save