repo/commit: improve error detection

Response 404 not 500 for raw diff if object does not exist.

routers/repo/commit.go

@@ -179,14 +179,14 @@ func Diff(ctx *context.Context) {
 	ctx.HTML(200, DIFF)
 }
 
-func RawDiff(ctx *context.Context) {
+func RawDiff(c *context.Context) {
 	if err := git.GetRawDiff(
-		models.RepoPath(ctx.Repo.Owner.Name, ctx.Repo.Repository.Name),
+		models.RepoPath(c.Repo.Owner.Name, c.Repo.Repository.Name),
-		ctx.Params(":sha"),
+		c.Params(":sha"),
-		git.RawDiffType(ctx.Params(":ext")),
+		git.RawDiffType(c.Params(":ext")),
-		ctx.Resp,
+		c.Resp,
 	); err != nil {
-		ctx.Handle(500, "GetRawDiff", err)
+		c.NotFoundOrServerError("GetRawDiff", git.IsErrNotExist, err)
 		return
 	}
 }

vendor/github.com/gogits/git-module/repo_commit.go

@@ -106,7 +106,7 @@ func (repo *Repository) getCommit(id sha1) (*Commit, error) {
 
 	data, err := NewCommand("cat-file", "-p", id.String()).RunInDirBytes(repo.Path)
 	if err != nil {
-		if strings.Contains(err.Error(), "fatal: Not a valid object name") {
+		if strings.Contains(err.Error(), "exit status 128") {
 			return nil, ErrNotExist{id.String(), ""}
 		}
 		return nil, err
@@ -129,6 +129,9 @@ func (repo *Repository) GetCommit(commitID string) (*Commit, error) {
 		var err error
 		commitID, err = NewCommand("rev-parse", commitID).RunInDir(repo.Path)
 		if err != nil {
+			if strings.Contains(err.Error(), "exit status 128") {
+				return nil, ErrNotExist{commitID, ""}
+			}
 			return nil, err
 		}
 	}

vendor/vendor.json

@@ -159,10 +159,10 @@
 			"revisionTime": "2016-08-10T03:50:02Z"
 		},
 		{
-			"checksumSHA1": "iZ3qMzzA24U3eqGifUZa6kFuCqk=",
+			"checksumSHA1": "XT0fyELKMKgb4XeMAtIrmi4SetM=",
 			"path": "github.com/gogits/git-module",
-			"revision": "5dba4f883034198eabac620b73aabf5488fcd821",
+			"revision": "2a496cad1f36aed60b14844b33b68eb3edfc2718",
-			"revisionTime": "2017-04-04T05:34:13Z"
+			"revisionTime": "2017-04-04T05:59:12Z"
 		},
 		{
 			"checksumSHA1": "D2kVXl0QpIw6t3891Sl7IM9wL+w=",