revert simple LDAP userDN and update example

gogs.go

@@ -17,7 +17,7 @@ import (
 	"github.com/gogits/gogs/modules/setting"
 )
 
-const APP_VER = "0.6.12.0914 Beta"
+const APP_VER = "0.6.12.0916 Beta"
 
 func init() {
 	runtime.GOMAXPROCS(runtime.NumCPU())

modules/auth/ldap/ldap.go

@@ -84,8 +84,8 @@ func (ls *Source) FindUserDN(name string) (string, bool) {
 func (ls *Source) SearchEntry(name, passwd string, directBind bool) (string, string, string, bool, bool) {
 	var userDN string
 	if directBind {
-		log.Trace("LDAP will bind directly via UserDN: %s", ls.UserDN)
-		userDN = ls.UserDN
+		log.Trace("LDAP will bind directly via UserDN template: %s", ls.UserDN)
+		userDN = fmt.Sprintf(ls.UserDN, name)
 	} else {
 		log.Trace("LDAP will use BindDN.")
 

templates/.VERSION

@@ -1 +1 @@
-0.6.12.0914 Beta
+0.6.12.0916 Beta

templates/admin/auth/edit.tmpl

@@ -52,7 +52,7 @@
             {{if .Source.IsDLDAP}}
             <div class="required field">
               <label for="user_dn">{{.i18n.Tr "admin.auths.user_dn"}}</label>
-              <input id="user_dn" name="user_dn" value="{{$cfg.UserDN}}" placeholder="e.g. ou=Users,dc=mydomain,dc=com" required>
+              <input id="user_dn" name="user_dn" value="{{$cfg.UserDN}}" placeholder="e.g. uid=%s,ou=Users,dc=mydomain,dc=com" required>
             </div>
             {{end}}
             <div class="required field">

templates/admin/auth/new.tmpl

@@ -56,7 +56,7 @@
                 </div>
                 <div class="dldap required field {{if not (eq .type 5)}}hide{{end}}">
                   <label for="user_dn">{{.i18n.Tr "admin.auths.user_dn"}}</label>
-                  <input id="user_dn" name="user_dn" value="{{.user_dn}}" placeholder="e.g. ou=Users,dc=mydomain,dc=com">
+                  <input id="user_dn" name="user_dn" value="{{.user_dn}}" placeholder="e.g. uid=%s,ou=Users,dc=mydomain,dc=com">
                 </div>
                 <div class="required field">
                   <label for="filter">{{.i18n.Tr "admin.auths.filter"}}</label>