Browse Source

Fix issue link in issues page

The link assumes that the issue belongs to the signed in
user, which is not necessarily the case
I changed it to use repository owner name instead
pull/184/head
Michael Litvak 11 years ago
parent
commit
cca2a53d6f
  1. 6
      routers/user/home.go
  2. 2
      templates/issue/user.tmpl

6
routers/user/home.go

@ -235,6 +235,12 @@ func Issues(ctx *middleware.Context) {
return return
} }
err = issues[i].Repo.GetOwner()
if err != nil {
ctx.Handle(500, "user.Issues(GetOwner)", err)
return
}
issues[i].Poster, err = models.GetUserById(issues[i].PosterId) issues[i].Poster, err = models.GetUserById(issues[i].PosterId)
if err != nil { if err != nil {
ctx.Handle(500, "user.Issues(GetUserById)", err) ctx.Handle(500, "user.Issues(GetUserById)", err)

2
templates/issue/user.tmpl

@ -36,7 +36,7 @@
{{range .Issues}}{{if .}} {{range .Issues}}{{if .}}
<div class="list-group-item issue-item" id="issue-{{.Id}}"> <div class="list-group-item issue-item" id="issue-{{.Id}}">
<span class="number pull-right">#{{.Index}}</span> <span class="number pull-right">#{{.Index}}</span>
<h5 class="title"><a href="/{{$.SignedUser.Name}}/{{.Repo.Name}}/issues/{{.Index}}">{{.Name}}</a></h5> <h5 class="title"><a href="/{{.Repo.Owner.Name}}/{{.Repo.Name}}/issues/{{.Index}}">{{.Name}}</a></h5>
<p class="info"> <p class="info">
<span class="author"><img class="avatar" src="{{.Poster.AvatarLink}}" alt="" width="20"/> <span class="author"><img class="avatar" src="{{.Poster.AvatarLink}}" alt="" width="20"/>
<a href="/user/{{.Poster.Name}}">{{.Poster.Name}}</a></span> <a href="/user/{{.Poster.Name}}">{{.Poster.Name}}</a></span>

Loading…
Cancel
Save