mbsync

Commit Graph

Author	SHA1	Message	Date
Oswald Buddenhagen	2ab689b3df	make imap_exec() result reporting callback-based this makes the IMAP command submission interface asynchronous. the functions still have synchronous return codes as well - this enables clean error return paths. only when we invoke callbacks we resort to refcounting. as a "side effect", properly sequence commands after CREATE resulting from [TRYCREATE].	12 years ago
Oswald Buddenhagen	e5d323cc47	rely on the maildir's existence with "SyncState *" now that we open the box first, we know that it will exist at this point.	12 years ago
Oswald Buddenhagen	3169c59e10	validate maildirs more strictly now that "SyncState *" won't create fake mailboxes any more, we can make a full validity check again.	12 years ago
Oswald Buddenhagen	05fd0b9970	split out drv->load() from drv->select()	12 years ago
Oswald Buddenhagen	c741d5ffb5	make creation of trash folder independent from -C option the trash is not a box which is synced, but a "byproduct" of manipulating synced boxes, so it makes no sense to bind it to the same option.	12 years ago
Oswald Buddenhagen	7addc3bea8	minor cleanup: use ctx->gen instead of gctx for consistency	12 years ago
Oswald Buddenhagen	424e0e7221	make callbacks return early when canceling even after driver->cancel() the store may complete commands successfully. return early in this case, so we don't attempt to continue syncing.	12 years ago
Oswald Buddenhagen	ea951a697f	fix error paths wrt sync drivers, take 2 synchronous error codes which are passed through callbacks aren't a particularly good idea, after all: latest when the callback does stuff which does not concern the caller, the return code becomes ambiguous. instead, protect the sync_vars object with a refcount when invoking driver functions from loops, as the callbacks they call could invalidate the object and we would have no way of knowing that the loop should be aborted prematurely. the upcoming async imap driver will also need a refcount to protect the cancelation marker of the imap socket dispatcher loop.	12 years ago
Oswald Buddenhagen	ec8f440383	don't call cancel() repeatedly on a store erroring command replies will trickle in even after canceling	12 years ago
Oswald Buddenhagen	b0bbd23512	replace DRV_STORE_BAD with a separate bad_callback() that way we don't have to piggy-back (possibly asynchronous) fatal errors to particular commands. internally, the drivers still use synchronous return values as well, so they don't try to access the invalidated store after calling back.	12 years ago
Oswald Buddenhagen	6d86e5347e	don't access free'd memory in cancel_sync() as it happens, the 1st round may trash svars - if we get the cancelation request after the slave store has already died.	12 years ago
Oswald Buddenhagen	9554026443	make drv->cancel()'s callback have no status code this function is not going to actually execute any commands, so it makes no sense for the callback to have a status code.	12 years ago
Oswald Buddenhagen	57444e9df9	don't decode aux pointer on DRV_CANCELED the aux data was already free()d by the error callback by the time we get this status code.	12 years ago
Oswald Buddenhagen	06ccac1fdd	always use return value from get_cmd_result() once we have callback-based error reporting, this will ensure that we don't operate on invalidated data structures.	12 years ago
Oswald Buddenhagen	121ce76e46	make response code parse failure of untagged OK/NO/BYE/BAD non-fatal as such, it does not disrupt the data stream	12 years ago
Oswald Buddenhagen	d2e13f147c	de-duplicate code a bit	12 years ago
Oswald Buddenhagen	4d4de6e275	remove redundant use_ssl variables just use the presence of an SSL object as an indicator. if something goes wrong during the ssl handshake or certificate validation, the socket must be immediately closed anyway.	13 years ago
Oswald Buddenhagen	fd229040d8	DRV_SERVER_BAD is and will probably stay unused => trash	13 years ago
Oswald Buddenhagen	17dc64b414	after [TRYCREATE], just resend the same command instead of cloning it	13 years ago
Oswald Buddenhagen	83efbe327d	use return values from correct set in get_cmd_result() DRV_OK == RESP_OK, so this worked by accident	13 years ago
Oswald Buddenhagen	99cc328f17	do away with the dreaded rcaps hack don't pretend that the server has no literal+ for the time of the first relevant command's synchronous execution. instead, enable the lower layer to do the processing by telling it for which commands trashnc ("trash's existence not confirmed") is relevant.	13 years ago
Oswald Buddenhagen	1545ed90a0	purge imap_store_t::currentnc vestiges we always actually open the mailbox before appending to it, so we obviously know that it exists - that's why the code was already commented out. changing this assumption would significantly complicate matters for little gain, so let's just assume it won't happen. consequently, also don't set param.create when appending to regular mailboxes.	13 years ago
Oswald Buddenhagen	c66afdc0a8	move setting of ctx->listed outside the drivers it's essentially an external state flag	13 years ago
Oswald Buddenhagen	7bab2d6d94	de-duplicate error paths makes the code more compact. yay for gotos.	13 years ago
Oswald Buddenhagen	f6a25b331f	check return value from close() after write() otherwise we may lose data when quota is exceeded or nfs is in a bad mood.	13 years ago
Oswald Buddenhagen	61d98c5a1d	fix a bunch of warnings	13 years ago
Oswald Buddenhagen	4afd31a457	avoid preprocessor warnings on missing features: #if => #ifdef	14 years ago
Oswald Buddenhagen	cf6a7b4d18	less bizarre code we know that there is only one command in progress, so there is no need to employ tricks to access the last command.	14 years ago
Oswald Buddenhagen	7e1c16ae02	make cram() sane - don't silently fail in release mode (expression with side effects inside assert()) - save some redundand strlen()s by not throwing away known lengths - reorganize the code for legibility	14 years ago
Oswald Buddenhagen	058d01f179	don't compare find_old_done with find_new_total this didn't have any effect as no async drivers currently exist.	14 years ago
Oswald Buddenhagen	9e10e871fd	don't hang if store cannot be opened asynchronously	14 years ago
Oswald Buddenhagen	2c729bf9e6	don't leak SSL objects	14 years ago
Oswald Buddenhagen	296ac0364c	add CR after TUID during LF => CRLF conversion	14 years ago
Oswald Buddenhagen	8df1ebaf40	fix (another) out-of-bounds access in CRLF conversion if the header contained no CRs but the body (or the post-TUID part of the header) did, the TUID insertion would add an excess CR, thus overflowing the buffer by one byte.	14 years ago
Oswald Buddenhagen	39006d7f24	document some breakage	14 years ago
Oswald Buddenhagen	d637772339	turns out, free(NULL) is just fine ...	14 years ago
Oswald Buddenhagen	e1fa867423	fix UIDNEXT handling UIDNEXT can be legally zero, so deal with it. -REFMAIL: 4CA62BA1.4020104@lemma.co.uk	14 years ago
Oswald Buddenhagen	5ade279839	don't hang after failed start_tls() we'd send a LOGOUT command in plain text while the server was already expecting an encrypted command, which would typically lead to waiting for more data and thus an indefinite hang. so close the socket immediately instead of letting the normal shutdown path take care of it. inspired by a patch by Steven Flintham. -REFMAIL: 4C9AB98E.3000400@lemma.co.uk	14 years ago
Oswald Buddenhagen	70e87eb99e	remove useless message don't complain about missing greeting response - we already complained about an unexpected EOF anyway.	14 years ago
Oswald Buddenhagen	90a38ea810	assert valid file handles i've seen error logs of the type SSL_write: Bad file descriptor and i simply can't nail it, so go for some more drastic measures.	14 years ago
Oswald Buddenhagen	72fd2aafb7	formatting	14 years ago
Oswald Buddenhagen	122e09fe60	beautify error messages don't print the error number - we print the error string anyway, so it adds no value. add some whitespace to the messages as well.	14 years ago
Oswald Buddenhagen	db2bbbfef8	fix uninitialized variable read this is basically a security fix for nonsensical configurations: if the specified CertificateFile did not contain any certificates, we might have accepted an arbitrary server certificate.	15 years ago
Oswald Buddenhagen	516c3bfa99	remove mail addresses from man pages apparently, some people don't see the "maintained by" bits, so make them look harder for explicit contact information (to be found in AUTHORS).	15 years ago
Oswald Buddenhagen	da39690aec	fix compile with SSL on Mac OS X patch by Remko Tronçon <remko@el-tramo.be> BUG: 2126899	15 years ago
Oswald Buddenhagen	a8b4de463e	add -P option to isync wrapper not really a backwards compat option, but whatever ... based on a patch submitted long ago by "nobody". BUG: 1433532	15 years ago
Oswald Buddenhagen	5bc3bf5fbd	fix rpm spec file -REFMAIL: 20090122213325.GA11572@crow.ths.tcoek12.org	15 years ago
Oswald Buddenhagen	7728278b9c	(new?) automake already sets docdir correctly for us	15 years ago
Oswald Buddenhagen	4729b1ee23	cvsignore => gitignore	15 years ago
Oswald Buddenhagen	474ce08b3a	adjust ChangeLog generation to git now that log generation is cheap, don't store it in the SCM any more.	15 years ago

1 2 3 4 5 ...

394 Commits (2ab689b3df07367b975a316e961fc953b1fa0903) All Branches Search

394 Commits (2ab689b3df07367b975a316e961fc953b1fa0903)

All Branches