mbsync

Commit Graph

Author	SHA1	Message	Date
Oswald Buddenhagen	2bbd07ec87	adjust comments to new reality	11 years ago
Oswald Buddenhagen	5a21042e98	ensure sequencing of message propagation and store closing by putting the message propagation last, `d3f634702` uncovered a long-standing problem: we might have closed the source store before all messages were propagated from it.	11 years ago
Oswald Buddenhagen	c47ee1c8c4	fix error paths wrt sync drivers, take 3 msgs_copied() was not checked at all, and msgs_flags_set() was doing it wrong (sync_close() was not checked). instead of trying to fix/extend the msgs_flags_set() model (ref-counting and cancelation checking in lower-level functions, and return values to propagate the status), place the refs/derefs around higher-level scopes and do the checking only there. this is effectively simpler, and does away with some obscure macros.	11 years ago
Oswald Buddenhagen	2f0fbcd306	don't use UID EXPUNGE unless trashing a simple CLOSE is way more efficient, so use it if no adverse effects can come from it.	11 years ago
Oswald Buddenhagen	03b3b566f1	reshuffle sources a bit split header and move some code to more logical places.	11 years ago
Oswald Buddenhagen	92b892d247	tag verbose output when channel links two verbose stores otherwise it's pure guesswork to assign the output to particular stores.	11 years ago
Oswald Buddenhagen	27fa63a577	move verbose socket logging out of socket driver the way it's used, it's more of a high-level function.	11 years ago
Oswald Buddenhagen	0b32734693	remove own_store() function from driver model the drivers which support it can abstract it inside open_store() just fine.	11 years ago
Oswald Buddenhagen	2cb483fb2e	make use of IMAP MOVE extension the Maildir driver is always exposing behavior equivalent to this - it's more efficient.	11 years ago
Oswald Buddenhagen	0ad8ef80b2	don't check for INBOX more than necessary	11 years ago
Oswald Buddenhagen	c293acaf24	fix listing of nested maildir mailboxes	11 years ago
Oswald Buddenhagen	cf0f32f800	allow prefixes to Patterns this makes it possible to "rename" a "namespace" while syncing.	11 years ago
Oswald Buddenhagen	6c6ad9710c	less spaghetti	11 years ago
Oswald Buddenhagen	decc33c2cf	factor out sync_listed_boxes()	11 years ago
Oswald Buddenhagen	f485d69332	refuse box list overrides if Channel has no Patterns as the named boxes are the same on both sides, they logically make sense only when the channel is in that mode anyway, which is the case when using patterns.	11 years ago
Oswald Buddenhagen	c6f08b8f17	treat manually specified box list the same as one coming from Patterns	11 years ago
Oswald Buddenhagen	540adbb8fd	make host resolution error messages more useful in non-ipv6 builds	11 years ago
Oswald Buddenhagen	b6949c64d2	avoid useless delay after creating maildir box we would see the recent timestamp of the creation and conclude that something is going on, so we'd wait. this is obviously nonsense. as we know that a freshly created mailbox is empty, simply skip the message scan alltogether.	11 years ago
Oswald Buddenhagen	71524cb6b0	reduce FSync option to a boolean there is no use for Thorough mode any more, so simplify the configuration.	11 years ago
Oswald Buddenhagen	29a56e2dc4	don't fsync after logging every TUID as we now don't actually start propagating new messages until all TUIDs have been generated, it's sufficient to sync just once. this makes it a cheap operation, so we can do it at SYNC_NORMAL level already.	11 years ago
Oswald Buddenhagen	8d5bd62537	add ExpireUnread option	11 years ago
Oswald Buddenhagen	f586c0bee5	make it possible to specify CopyArrivalDate and MaxMessages globally sneaky change on the side: the wording of the man page is changed from "outside any section" to "before any section" to get global options. this is not entirely true ... the previously existing options behave as before, while the two newcomers actually affect subsequent channels.	11 years ago
Oswald Buddenhagen	c0ba0c7ecf	replace global_* with a channel_conf_t instance this makes the (growing) list of getopt_helper()'s parameters manageable. the few wasted bytes are worth it.	11 years ago
Oswald Buddenhagen	1e427f5cd5	do not unnecessarily use bitfields they don't save much (if any) space in our usage, while they make the machine code more bloated and slow.	11 years ago
Oswald Buddenhagen	49a32910a7	move handling of new messages after that of old ones i.e., move it back. whatever the original reason was, it's now gone. this order is way more natural, which allows us to remove the osrecadd and S_DONE hacks.	11 years ago
Oswald Buddenhagen	fe3d19b7eb	verify idempotence of all sync operations	11 years ago
Oswald Buddenhagen	b1842617f7	make MaxMessages work for new mails as well this helps enormously on the first sync of a 100k message box with a limit of 1k messages. it also happens to make the syncing idempotent. in a few conditionals we now explicitly test for max_messages being enabled, not smaxxuid != 0, as after the initial fetch with no important messages smaxxuid is zero, but we still have to skip over 99k messages in the above case.	11 years ago
Oswald Buddenhagen	d3f6347021	delay propagation of new messages previous sequence: examine & propagate new => examine old => propagate old new sequence: examine new => examine old => propagate new => propagate old this alone does not buy us much ...	11 years ago
Oswald Buddenhagen	391ec01f28	make message propagation recording less magic assign the sync record to the source message asap, and later on rely on a more explicit condition than not doing so.	11 years ago
Oswald Buddenhagen	7f784fd235	log maxuid bumping less aggressively we can bump the internal variable whereever convenient, but we cannot log it until we know that all messages were copied, as otherwise we could miss some new messages after an interruption. with the new approach, interruption would merely cause some additonal traffic.	11 years ago
Oswald Buddenhagen	8b76412b0d	document message expiration transactions	11 years ago
Oswald Buddenhagen	ecb4c7ab07	propagate deletions with other flag changes less code duplication, more logical order of issued driver commands (especially after the next commit), and the "side effect" of letting the message expiration code see those deletions if they are asynchronous.	11 years ago
Oswald Buddenhagen	273ac899f3	don't delay loading master even if messages were expired the delay optimized the corner case of previously important but now expired messages on the slave disappearing, either through an external expunge or after a journal replay. no point in pessimizing the common case.	11 years ago
Oswald Buddenhagen	12676f28da	remove cleanup of expired entries during setup of master load the removed code would only ever trigger if a) we were after a journal replay or b) something external expunged the expired messages - both are corner cases not worth the extra code. however, this means that the syncing code further down now needs to take care of these zombies. in the end, the normal cleanup will take care of all expired entries, new and old.	11 years ago
Oswald Buddenhagen	9a62521cff	micro-optimization/-clarification: swap condition order	11 years ago
Oswald Buddenhagen	014d9b9081	make message counting in expiration code less confusing	11 years ago
Oswald Buddenhagen	83b834cdfd	count unread messages like flagged messages when expiring that is, don't count them towards the total only below the cut-off point. making them extend the working set even though they are inside it is counterintuitive.	11 years ago
Oswald Buddenhagen	9e186ae88b	use post-sync "seen" flag to determine expirability otherwise it wouldn't be idempotent.	11 years ago
Oswald Buddenhagen	15216947fb	don't protect recent messages from MaxMessages while maildir has a clearly defined meaning of "recent" and for example mutt handles it graciously, IMAP's definition is fubared to the point that some servers (for example gmail) simply refuse to support it. for symmetry reasons it is best to pretend that it doesn't exist at all. it doesn't seem too useful anyway (the user can simply mark the messages as read to allow pruning). and last but not least, the man page of mbsync says nothing about "recent", only "unread". unlike the isync man page, though.	11 years ago
Oswald Buddenhagen	6b7b2b1106	always get slave flags when we are expiring even if we are not propagating new messages, the appearance of new messages on the slave can lead to expiring older messages. for that, we need to know their importance, and thus flags. the alternative would be not doing an expiration run when not fetching new messages, but that would mean more conditionals all over the place. as the decision is somewhat arbitrary, just do the simpler thing.	11 years ago
Oswald Buddenhagen	f1eea7d9a5	do not trash expired messages we are not actually deleting them, so there is no point in saving them in the trash.	11 years ago
Oswald Buddenhagen	48754ecc74	make sync state header format less obscure the header is not space-critical, so use proper name-value pairs. this has the additional advantage that subsequent format changes can be done much easier.	11 years ago
Oswald Buddenhagen	83bb1cf716	make state loading in showstate() similar to ckstate()	11 years ago
Oswald Buddenhagen	f044adbfa4	take configs out of target state defs cleaner and less duplication	11 years ago
Oswald Buddenhagen	5297425918	more precise failure reporting	11 years ago
Oswald Buddenhagen	3d81ccbf21	make it possible to run only selected tests	11 years ago
Oswald Buddenhagen	3dcb393de2	set srec->msg[] when finding messages by tuid otherwise we would propagate phantom deletions. this affected only sync runs after an interruption while storing messages, so it went (mostly?) unnoticed.	11 years ago
Oswald Buddenhagen	3814f19661	remove pointless assignment we already know that tmsg->srec is null at this point.	11 years ago
Oswald Buddenhagen	e63e16ab45	assert no stray TUIDs	11 years ago
Oswald Buddenhagen	8e49300cf7	initialize struct tm strptime() does not initialize at least tm_isdst, which leads to an uninited value reference in mktime().	11 years ago

1 2 3 4 5 ...

580 Commits (2bbd07ec87d81cb7a20aa49344b66d6cfdc4fc78) All Branches Search

580 Commits (2bbd07ec87d81cb7a20aa49344b66d6cfdc4fc78)

All Branches