mbsync

Commit Graph

Author	SHA1	Message	Date
Oswald Buddenhagen	2f3cb5f481	fix signedness issues surrounding UIDs amends `bb632d1c`.	4 years ago
Oswald Buddenhagen	e334eb3580	make find_uint_array() never create negative indices	4 years ago
Oswald Buddenhagen	01348f6f7c	centralize "const cast" in make_key()	4 years ago
Oswald Buddenhagen	27a1935361	fix strftime() format string warning properly the workaround for -Wformat triggered -Wformat-nonliteral in turn. so instead go back to using pragmas and add a proper gcc version check. this also works with clang - mostly for qt-creator's code model, which is clang-based. amends/reverts `55e65147`.	4 years ago
Oswald Buddenhagen	b885e0e03a	don't use reserved identifier pattern in stringify()	4 years ago
Oswald Buddenhagen	85688d1c1a	don't leak the channel list after all unlike the actual configuration data, it's not kept in global variables, so it shows up in memcheck. amends `1de3ecd88`.	4 years ago
Oswald Buddenhagen	09d11245cd	don't leak box list from the command line we also free the box list obtained from IMAP, so there isn't a real reason not to do that for one from the command line. amends `1de3ecd88`.	4 years ago
Oswald Buddenhagen	83adb9a39b	actually implement maildir_get_uidnext() the assumption was that this wouldn't be needed, as maildir_store_msg() reliably delivers a UID. however, if we crash right before the callback can record that UID, we'd still use OPEN_FIND in the next run, which requires the saved next UID.	4 years ago
Oswald Buddenhagen	c84235b068	get rid of maildir_find_new_msgs() stub a failed assertion isn't any better than a clean segfault with an obvious backtrace.	4 years ago
Oswald Buddenhagen	38e7b4db22	Maildir: fix setting flags on messages without ":2," part this is mostly hypothetical, as all messages i've encountered actually have it even if no flags are set on them.	4 years ago
Oswald Buddenhagen	1004756659	kill TODO item about killing INBOX while it's correct that mbsync doesn't strictly need to support both Inbox and Path in a single Channel due to being able to Group Channels, this "simplification" would have some undesirable effects: - the concept is part of IMAP and provides a certain level of "zero-conf" (in particular via NAMESPACE). having to set up two Stores and associated Channels for one Account to reproduce this functionality would add quite some redundancy to common configurations. - implementing MapInbox and move detection across Channels would add significant complexity. one reason why one would want this change in the first place is to get rid of the ambiguity of INBOX appearing right under Path. this could be avoided by either using a different magic prefix that cannot appear in actual mailbox names, or requiring a prefix for boxes inside path as well. neither approach seems worth the effort, given that nesting "INBOX" under Path causes problems for some other IMAP clients anyway.	4 years ago
Oswald Buddenhagen	30e166aa18	give the coverity build result archive a more descriptive name	4 years ago
Oswald Buddenhagen	406931bc45	autotest: use symbolic message subjects ... instead of numbers. otherwise there is too much confusion with UIDs.	4 years ago
Oswald Buddenhagen	6734b9ce7d	autotest: re-order mailbox contents according to UIDs ... instead of subjects, because that's way more natural and thus less confusing.	4 years ago
Oswald Buddenhagen	f3629c69e1	autotest: re-organize mailbox storage by UID an effect of `7ce658d` is that we can index messages by UID rather than content (or more specifically, subject). apart from being cleaner, it allows duplicated subjects.	4 years ago
Oswald Buddenhagen	b59ee239a4	autotest: assume that each message has a UID followup to `7ce658d14`.	4 years ago
Oswald Buddenhagen	50eab08509	autotest: show the right state file after idempotence test failure amends `efd72b85`.	4 years ago
Oswald Buddenhagen	d59392e901	autotest: fix prototype of ckbox()	4 years ago
Oswald Buddenhagen	ef2caa074e	autotest: create the temp dir in $TEMP on modern systems, this makes it likely to end up on tmpfs, which is a lot faster and ssd-friendlier. the symlink is not deleted at the end, to minimize fs churn. that means it will be dangling after a reboot, which gets fixed in the next run.	4 years ago
Oswald Buddenhagen	5fee222f84	Merge branch '1.3'	4 years ago
Oswald Buddenhagen	c97e650c24	bump version	4 years ago
Oswald Buddenhagen	30261fe6f1	fix version comparison in LibreSSL conditional the operator was exactly inverted. that means that it actually wouldn't compile with both older versions (that needed the aliases) and potentially new versions (that will hide the data members - still not the case as of 3.2). amends `8a40554f0`.	4 years ago
Oswald Buddenhagen	542e38dd49	fix re-using server connections for new stores we failed to reset the box list pointer after freeing it, which would lead to a crash. we also failed to reset the listing status, which would lead to malfunction if we hadn't already crashed. this inlines imap_cleanup_store(), as there isn't much value in keeping it. the message list is already freed when disowning the store anyway.	4 years ago
Oswald Buddenhagen	c82397cf6e	don't crash in proxy_invoke_bad_callback() we need to hold a ref to the proxy store, as after the bad_callback() it's otherwise likely gone.	4 years ago
Oswald Buddenhagen	813ad67c56	fix simultaneously connecting to multiple hosts in non-IPv6 builds we need to deep-copy the struct hostent data, as otherwise the concurrent connects will overwrite each other's lookup results. this is a rather hypothetical fix, as the bug currently affects only channels connecting two IMAP accounts, and only if the first host's first address asynchronously fails to connect.	4 years ago
Oswald Buddenhagen	3651c30296	increase PassCmd output buffer even more apparently, some XOAUTH2 tokens are at 2.4K already, so make it 8K to be really safe for a while. REFMAIL: <20200716000515.GA2111668@lysator.liu.se>	4 years ago
Oswald Buddenhagen	09540b5648	unbreak CertificateFile documentation the file may in fact contain CA certs. amends `7d9d3e15`.	4 years ago
Oswald Buddenhagen	cab14608ca	Merge branch '1.3'	5 years ago
Oswald Buddenhagen	80deabf520	bump version	5 years ago
Oswald Buddenhagen	96afe8d0c2	fix propagation of flagged oversized messages ... when not syncing flags and the target is not being expunged, as in that case flags were not queried in time.	5 years ago
Oswald Buddenhagen	aff0c88a38	fix printf length arguments on lp64 found by coverity.	5 years ago
Oswald Buddenhagen	04fc586e75	handle case-insensitivity of IMAP's INBOX this is relevant only when listing an IMAP Store's contents, as that's the only place where we aren't imposing the spelling ourselves. we need to be careful not to treat our own canonical (prefix-stripped and always slash-delimited) box names like that; codify that in comments. this reveals that commit `6f2160f1` may be deemed to have been incorrect - the TODO item was ambiguous, and could quite possibly have meant this fix. unsurprisingly, `380ccdd4` re-introduced it with more explicit wording.	5 years ago
Oswald Buddenhagen	94022a6752	catch server's failure to FETCH * the query is untypical enough to have caused problems with davmail (when we still used :) and mailo.com (until it got fixed), so better check that the result (not) returned by the server makes sense.	5 years ago
Oswald Buddenhagen	dfa8c16f27	don't timeout while uploading big messages we did already set up the timeout when starting to send commands, but so far we did not reset it when succeeding to send out data. rectify that. REFFAIL: 87sgy92we3.fsf@jnanam.net	5 years ago
Oswald Buddenhagen	121448ceb9	make -DC work with yama ptrace protection	5 years ago
Oswald Buddenhagen	bee4fc54e7	fix overflows in uint comparisons	5 years ago
Oswald Buddenhagen	a33e44758b	fix roff abuse in man pages ".." is not valid. use "." instead, as recommended by groff_man(7). this also necessitated adjusting the markup of the license blurbs.	5 years ago
Oswald Buddenhagen	7d9d3e15f5	improve documentation of the server certificate related options	5 years ago
Oswald Buddenhagen	a2fe8c155a	re-generate ChangeLog only if it's newer than the git index otherwise, we'd re-generate it during 'install' as well. note that this does not work with new-style git worktrees, where .git is only a file - but there the log generation itself already doesn't work anyway.	5 years ago
Oswald Buddenhagen	281a87ed89	update build requirements in particular, mention perl-related things, which might not be immediately obvious.	5 years ago
Oswald Buddenhagen	48038fede1	mention --remove in --help output amends `d9a983a`.	5 years ago
Oswald Buddenhagen	93fb3c29c6	fix UIDNEXT error message	5 years ago
Oswald Buddenhagen	e565d08246	don't try to propagate flags the target store does not support $Forwarded is not standard, so it will most likely fail with mailboxes that do not support keywords. amends `c4d7f018`.	5 years ago
Oswald Buddenhagen	e8caaaaf65	rename F_PASSED => F_FORWARDED the flag names are supposed to reflect the IMAP names (that's why their #defines are followed by comments with the Maildir names). amends `c4d7f018`.	5 years ago
Oswald Buddenhagen	462fed556a	Merge branch '1.3'	5 years ago
Oswald Buddenhagen	d0a8551703	fix error handling of SSL_set_tlsext_host_name() it is not one of the functions to be checked with SSL_get_error(). amends `17babc169`.	5 years ago
Oswald Buddenhagen	6a874b5877	error-check more openssl function calls	5 years ago
Oswald Buddenhagen	5f908b7672	attempt to improve ssl error handling (again) the error queue may contain multiple errors, so make sure to drain it completely. also, don't try to fall back to errno in case of SSL_ERROR_SSL.	5 years ago
Oswald Buddenhagen	91abf2b830	modernize ssl context init with openssl 1.1+, use TLS_client_method() instead of the deprecated SSLv23_client_method().	5 years ago
Oswald Buddenhagen	f63e4338e8	fix leak of openssl X509 objects SSL_get_peer_certificate() increments the refcount of the object.	5 years ago

1 2 3 4 5 ...

1023 Commits (68a412115a75223fb9561f0a467970d2a4af65bf) All Branches Search

1023 Commits (68a412115a75223fb9561f0a467970d2a4af65bf)

All Branches