mbsync

Commit Graph

Author	SHA1	Message	Date
Oswald Buddenhagen	526231bc22	initialize store_t::name the field is marked foreign (for the drivers), so a recycled store may contain an old pointer in it. that would make our error path crash. REFMAIL: CAF_KswU7aBS7unnK+rdZy1PG_8SZUAW=tcg75HixDLLE0w3Lhw@mail.gmail.com	11 years ago
Oswald Buddenhagen	29b07ca7a6	actually print the faulty mailbox name, not some garbage REFMAIL: CAF_KswU7aBS7unnK+rdZy1PG_8SZUAW=tcg75HixDLLE0w3Lhw@mail.gmail.com	11 years ago
Oswald Buddenhagen	060430b233	bump version	11 years ago
Oswald Buddenhagen	3d5539bb63	detect inconsistent state of highest assigned UID the highest assigned UID must always be at least as high as the highest actually found UID, as otherwise we'd hand out duplicate UIDs at some point. also, getting into such a state in the first place indicates some potentially serious trouble, or at least external interference (e.g., moving/copying a message from another folder without giving it a pristine filename). REFMAIL: 20140626211831.GA11590@sie.protva.ru	11 years ago
Oswald Buddenhagen	8513358e0a	zero-terminate imap literals now that we properly support literals for strings, we must expect that the consumer code will use them as strings. amends `fc77feacc`. discovered by Armands Liepins <armandsl@gmail.com> REFMAIL: CAF_KswXoxdm7KXnWW4b_1odf=XsE4qRqRN4AsecwcPF1d+dSTA@mail.gmail.com	11 years ago
Oswald Buddenhagen	4ab12ae76e	don't lie about the default of User unlike the isync wrapper, mbsync does not have a default for the IMAP user. the remote user seldomly matches the local one, so "forwarding" it is more confusing than helpful. CCMAIL: 744389@bugs.debian.org	11 years ago
Oswald Buddenhagen	4d8575100d	don't forget to reset message counts when skipping scan amends `b6949c64d2`. CCMAIL: 744259@bugs.debian.org	11 years ago
Oswald Buddenhagen	8844ff3063	remove apparently pointless resetting of recent message count past this point, it's not used for anything anyway.	11 years ago
Oswald Buddenhagen	532d964aea	error-check renaming of uid mapping database for pedantry. found by coverity.	11 years ago
Oswald Buddenhagen	09db83809a	error-check reading of old uidvalidity and maxuid files found by coverity.	11 years ago
Oswald Buddenhagen	2d4bc1e613	error-check committing of sync state a failure here is rather unlikely, but let's be pedantic. a failure is not fatal (we'll just enter the journal replay path next time), so only print warnings. found by coverity.	11 years ago
Oswald Buddenhagen	aa0118d047	better error messages for sync state and journal related errors we can make perfectly good use of errno here.	11 years ago
Oswald Buddenhagen	c6ddad6ac4	remove pointless/counterproductive "Disk full?" error message suffixes the affected functions will set errno to ENOSPC when necessary.	11 years ago
Oswald Buddenhagen	d7d5fd20bc	fix "inverse copy&pasto" in account labeling code the code was copied and the original adjusted ... but not quite completely. this means that clashing server names never really worked since - not that i would have expected this to be a particularly common configuration to start with. :D also added comments explaining why there are two implementations of the same thing. amends `aea4be19e3` (anno 2006). found by coverity.	11 years ago
Oswald Buddenhagen	9932352df0	assert !where implying !pseudo to help poor coverity.	11 years ago
Oswald Buddenhagen	c5f2943ff6	don't crash in message expiration debug print we would try to print the uids from the non-existing srec of unpaired messages while preparing expiration. this would happen only if a) MaxMessages was configured and b) new messages appeared on the slave but we were not pushing, so it's a bit of a corner case. found by coverity.	11 years ago
Oswald Buddenhagen	31ba8375b0	fix segfault on passing --{create,expunge}-{master,slave} stupid copy&pasto. found by coverity.	11 years ago
Oswald Buddenhagen	ae49a37a3e	don't crash on malformed response code this would happen in the absurd corner case that the response code is properly terminated with a closing bracket, but the atom itself is an unterminated double-quoted string. NOT found by coverity.	11 years ago
Oswald Buddenhagen	fd872a7ff7	don't crash on truncated LIST response found by coverity.	11 years ago
Oswald Buddenhagen	0dfbf6f6fb	remove pointless pointer assignment	11 years ago
Oswald Buddenhagen	d34baeb886	fix hypothetical buffer overflows if something managed to make the maildir .uidvalidity files big enough (possible only by appending garbage or scrambling them alltogether), we would overflow the read buffer by one when appending the terminating null. this is not expected to have any real-world impact. found by coverity.	11 years ago
Oswald Buddenhagen	df29c592d1	close a bunch of fd leaks in error paths found by coverity.	11 years ago
Oswald Buddenhagen	dec5f73f57	actually use prime numbers for all hash bucket sizes for some reason lost in history, the prime_deltas were actually wrong, leading to using composite numbers. the right sequence is available at http://oeis.org/A092131.	11 years ago
Oswald Buddenhagen	bee7ceb0fb	fix zero MaxSize override in Channels REFMAIL: CA+Tk8fzb9i9LrC_k4G978c5XR5urNz_s0fpOn_-6EsdrBnEzSQ@mail.gmail.com	11 years ago
Oswald Buddenhagen	19d86d2aa9	rework maildir store mapping the trivial approach of having "home" and "root" stores produced ugly results, and totally failed with the introduction of nested folder handling. instead, create a store per local directory, just as one would manually. CCMAIL: 737708@bugs.debian.org	11 years ago
Oswald Buddenhagen	0edb606e0f	don't needlessly quote strings	11 years ago
Oswald Buddenhagen	183f256557	don't needlessly spell out INBOX	11 years ago
Oswald Buddenhagen	bf9d7c7695	write Sync and Expunge to global section if applicable makes for leaner Channel sections. note: the global delete and expunge variables exist so the command line can override the config file despite the otherwise backwards behavior.	11 years ago
Oswald Buddenhagen	f55f42bdfc	don't bother checking impossible condition the config readear already verified that at least host or tunnel are set.	11 years ago
Oswald Buddenhagen	3161540ab9	fix crash on store without prior fetch with non-UIDPLUS servers we'd never initialize the message list append pointer, so imap_find_new_msgs()'s FETCH would go awry. REFMAIL: <20140207101719.GB17125@mac.home>	11 years ago
Oswald Buddenhagen	12be7dd1f3	remove pointless use of AI_V4MAPPED flag this flag is ineffective if ai_family is not explicitly AF_INET6. on top of that, attempting to use it breaks on FreeBSD.	11 years ago
Oswald Buddenhagen	1c758be695	fix typos	11 years ago
Oswald Buddenhagen	f4a192f375	don't error out if we don't get an X-TUID header the BODY[] item in the FETCH response corresponds to what we requested, and its presence doesn't imply that it actually contains anything useful - new messages may appear in the mailbox in addition to those we stored ourselves, and these will obviously have no TUID.	11 years ago
Oswald Buddenhagen	aee0fa3b68	make date parsing portable, take 2 the global timezone variable is glibc-specific. so use timegm() instead of mktime() for the conversion. as that is specific to the BSDs and glibc, provide a fallback. amends `62a6099`.	11 years ago
Oswald Buddenhagen	6d2fd370a6	fix _POSIX_SYNCHRONIZED_IO usage it can be -1 for unsupported, or 0 for runtime detection (which we don't do).	11 years ago
Oswald Buddenhagen	813b4942db	bump version	11 years ago
Oswald Buddenhagen	f9386d0b83	remove apparently obsolete item about Mutt's confusion seems to work just fine ...	11 years ago
Oswald Buddenhagen	760bfa2cc6	pre-release doc updates	11 years ago
Oswald Buddenhagen	8b2bc912b4	elaborate on expunging and trashing	11 years ago
Oswald Buddenhagen	4481702da3	clarify wording in MapInbox doc	11 years ago
Oswald Buddenhagen	4fa5779193	avoid array underflow in IMAP LIST .lock workaround suggested by Mark Wielaard <mark@klomp.org>. fwiw, the workaround really is still necessary with panda imap ...	11 years ago
Oswald Buddenhagen	359091625d	MaxMessages: ignore entries with no master while calculating bulk fetch	11 years ago
Oswald Buddenhagen	2bbd07ec87	adjust comments to new reality	11 years ago
Oswald Buddenhagen	5a21042e98	ensure sequencing of message propagation and store closing by putting the message propagation last, `d3f634702` uncovered a long-standing problem: we might have closed the source store before all messages were propagated from it.	11 years ago
Oswald Buddenhagen	c47ee1c8c4	fix error paths wrt sync drivers, take 3 msgs_copied() was not checked at all, and msgs_flags_set() was doing it wrong (sync_close() was not checked). instead of trying to fix/extend the msgs_flags_set() model (ref-counting and cancelation checking in lower-level functions, and return values to propagate the status), place the refs/derefs around higher-level scopes and do the checking only there. this is effectively simpler, and does away with some obscure macros.	11 years ago
Oswald Buddenhagen	2f0fbcd306	don't use UID EXPUNGE unless trashing a simple CLOSE is way more efficient, so use it if no adverse effects can come from it.	11 years ago
Oswald Buddenhagen	03b3b566f1	reshuffle sources a bit split header and move some code to more logical places.	11 years ago
Oswald Buddenhagen	92b892d247	tag verbose output when channel links two verbose stores otherwise it's pure guesswork to assign the output to particular stores.	11 years ago
Oswald Buddenhagen	27fa63a577	move verbose socket logging out of socket driver the way it's used, it's more of a high-level function.	11 years ago
Oswald Buddenhagen	0b32734693	remove own_store() function from driver model the drivers which support it can abstract it inside open_store() just fine.	11 years ago

... 2 3 4 5 6 ...

772 Commits (7ddd8d173730746d5481019ffd7090b107bec45a) All Branches Search

772 Commits (7ddd8d173730746d5481019ffd7090b107bec45a)

All Branches